From owner-freebsd-rc@FreeBSD.ORG Mon Feb 19 11:08:33 2007 Return-Path: X-Original-To: freebsd-rc@FreeBSD.org Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id B266516A4CA for ; Mon, 19 Feb 2007 11:08:33 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40]) by mx1.freebsd.org (Postfix) with ESMTP id 9CC8D13C471 for ; Mon, 19 Feb 2007 11:08:33 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (linimon@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id l1JB8XGP021467 for ; Mon, 19 Feb 2007 11:08:33 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from linimon@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id l1JB8WYH021463 for freebsd-rc@FreeBSD.org; Mon, 19 Feb 2007 11:08:32 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 19 Feb 2007 11:08:32 GMT Message-Id: <200702191108.l1JB8WYH021463@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: linimon set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-rc@FreeBSD.org Cc: Subject: Current problem reports assigned to you X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Feb 2007 11:08:33 -0000 Current FreeBSD problem reports Critical problems Serious problems S Tracker Resp. Description -------------------------------------------------------------------------------- o conf/48881 rc [PATCH] The influence of /etc/start_ifname on /etc/rc. o conf/98758 rc [patch] Templatize 'jail_fstab' in /etc/rc.d/jail o conf/98846 rc [patch] Templatize 'jail_rootdir' in /etc/rc.d/jail o bin/104623 rc "rc.d/ppp restart" stops all instances of ppp o conf/105689 rc syslogd starts too late at boot o conf/107155 rc /etc/rc.d/ppp-user does not bring up pppoe at boot o conf/107316 rc [rc.d]: [base] [rpc.lockd] nfslocking restart does not o conf/107364 rc pf fails to start on bootup after system update from F o conf/108226 rc second copy of ppp started at boot time 9 problems total. Non-critical problems S Tracker Resp. Description -------------------------------------------------------------------------------- o conf/45226 rc Fix for rc.network, ppp-user annoyance o conf/48870 rc [PATCH] rc.network: allow to cancel interface status d o conf/55916 rc [PATCH] ppp-user options o conf/58939 rc [patch] dumb little hack for /etc/rc.firewall{,6} o conf/73677 rc [patch] add support for powernow states to power_profi o conf/74817 rc [patch] network.subr: fixed automatic configuration of o conf/77663 rc Suggestion: add /etc/rc.d/addnetswap after addcritremo o conf/78906 rc [patch] Allow mixer_enable="NO" in rc.conf o conf/79196 rc [PATCH] configurable dummynet loading from /etc/rc.co o kern/81006 rc ipnat not working with tunnel interfaces on startup o conf/85363 rc syntax error in /etc/rc.d/devfs o conf/85819 rc [patch] script allowing multiuser mode in spite of fsc o conf/88913 rc [patch] wrapper support for rc.subr o conf/89061 rc [patch] IPv6 6to4 auto-configuration enhancement o conf/89870 rc [patch] feature request to make netif verbose rc.conf o conf/92523 rc [patch] allow rc scripts to kill process after a timeo o conf/93815 rc [patch] Adds in the ability to save ipfw rules to rc.d o conf/95162 rc [patch] Missing feature in rc.subr o conf/96343 rc [patch] rc.d order change to start inet6 before pf o conf/99444 rc [patch] Enhancement: rc.subr could easily support star o conf/99595 rc [PATCH] /etc/rc.d/dhclient doesn't interact well with o conf/99721 rc [patch] /etc/rc.initdiskless problem copy dotfile in s o conf/102700 rc [PATCH] Add encrypted /tmp support to GELI/GBDE rc.d s o conf/102722 rc kerberos5 server startupscript should use --detach o conf/102913 rc /etc/rc.d/named killall in jailed OS o conf/103486 rc [rc.d] [patch] rc.d/jail: mount fstab after devfs o conf/103489 rc [rc.d] [patch] named_chroot_autoupdate doesn't work in o conf/103976 rc rc.d/named restart failure o conf/104408 rc command not set in rc.d/isdnd, can't stop isdnd with t o conf/104549 rc [patch] rc.d/nfsd needs special _find_processes functi o conf/105145 rc [PATCH] add redial function to rc.d/ppp o conf/105568 rc [patch] Add more flexibility to rc.conf, to choose "_e o conf/106009 rc [patch] Fix pppoed startup script to process multiply o conf/106873 rc [patch] rc.d/nfslocking does not properly restart o conf/106978 rc "daily run" incorrectly assumes auth.log is rolled mor o conf/107035 rc bridge interface given in rc.conf not taking an (stati 36 problems total. From owner-freebsd-rc@FreeBSD.ORG Tue Feb 20 15:12:02 2007 Return-Path: X-Original-To: freebsd-rc@hub.freebsd.org Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 6095E16E7B2; Tue, 20 Feb 2007 14:50:36 +0000 (UTC) (envelope-from linimon@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40]) by mx1.freebsd.org (Postfix) with ESMTP id 2FF7913C4B9; Tue, 20 Feb 2007 14:50:32 +0000 (UTC) (envelope-from linimon@FreeBSD.org) Received: from freefall.freebsd.org (linimon@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id l1KEoVpp054176; Tue, 20 Feb 2007 14:50:31 GMT (envelope-from linimon@freefall.freebsd.org) Received: (from linimon@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id l1KEoVnu054172; Tue, 20 Feb 2007 14:50:31 GMT (envelope-from linimon) Date: Tue, 20 Feb 2007 14:50:31 GMT From: Mark Linimon Message-Id: <200702201450.l1KEoVnu054172@freefall.freebsd.org> To: linimon@FreeBSD.org, freebsd-bugs@FreeBSD.org, freebsd-rc@FreeBSD.org Cc: Subject: Re: conf/109354: /etc/periodic/daily/110.clean-tmps does not limit its operation to one file system X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Feb 2007 15:12:06 -0000 Synopsis: /etc/periodic/daily/110.clean-tmps does not limit its operation to one file system Responsible-Changed-From-To: freebsd-bugs->freebsd-rc Responsible-Changed-By: linimon Responsible-Changed-When: Tue Feb 20 14:49:50 UTC 2007 Responsible-Changed-Why: Over to maintainer(s). http://www.freebsd.org/cgi/query-pr.cgi?pr=109354 From owner-freebsd-rc@FreeBSD.ORG Tue Feb 20 18:50:22 2007 Return-Path: X-Original-To: freebsd-rc@hub.freebsd.org Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id A5C2916BA9B; Tue, 20 Feb 2007 18:50:22 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40]) by mx1.freebsd.org (Postfix) with ESMTP id 80FF913C4B8; Tue, 20 Feb 2007 18:50:22 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from freefall.freebsd.org (dougb@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id l1KIoMBx076888; Tue, 20 Feb 2007 18:50:22 GMT (envelope-from dougb@freefall.freebsd.org) Received: (from dougb@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id l1KIoM5f076884; Tue, 20 Feb 2007 18:50:22 GMT (envelope-from dougb) Date: Tue, 20 Feb 2007 18:50:22 GMT From: Doug Barton Message-Id: <200702201850.l1KIoM5f076884@freefall.freebsd.org> To: dougb@FreeBSD.org, freebsd-rc@FreeBSD.org, freebsd-bugs@FreeBSD.org Cc: Subject: Re: conf/109354: /etc/periodic/daily/110.clean-tmps does not limit its operation to one file system X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Feb 2007 18:50:22 -0000 Synopsis: /etc/periodic/daily/110.clean-tmps does not limit its operation to one file system Responsible-Changed-From-To: freebsd-rc->freebsd-bugs Responsible-Changed-By: dougb Responsible-Changed-When: Tue Feb 20 18:50:01 UTC 2007 Responsible-Changed-Why: periodic != rc.d http://www.freebsd.org/cgi/query-pr.cgi?pr=109354 From owner-freebsd-rc@FreeBSD.ORG Tue Feb 20 18:53:50 2007 Return-Path: X-Original-To: freebsd-rc@hub.freebsd.org Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id EB57916A6D3; Tue, 20 Feb 2007 18:53:50 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40]) by mx1.freebsd.org (Postfix) with ESMTP id C676913C4A8; Tue, 20 Feb 2007 18:53:50 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from freefall.freebsd.org (dougb@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id l1KIroeh077074; Tue, 20 Feb 2007 18:53:50 GMT (envelope-from dougb@freefall.freebsd.org) Received: (from dougb@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id l1KIroHL077070; Tue, 20 Feb 2007 18:53:50 GMT (envelope-from dougb) Date: Tue, 20 Feb 2007 18:53:50 GMT From: Doug Barton Message-Id: <200702201853.l1KIroHL077070@freefall.freebsd.org> To: dougb@FreeBSD.org, freebsd-rc@FreeBSD.org, freebsd-bugs@FreeBSD.org Cc: Subject: Re: conf/106978: "daily run" incorrectly assumes auth.log is rolled more than once a year! X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Feb 2007 18:53:51 -0000 Synopsis: "daily run" incorrectly assumes auth.log is rolled more than once a year! Responsible-Changed-From-To: freebsd-rc->freebsd-bugs Responsible-Changed-By: dougb Responsible-Changed-When: Tue Feb 20 18:52:49 UTC 2007 Responsible-Changed-Why: periodic != rc.d http://www.freebsd.org/cgi/query-pr.cgi?pr=106978 From owner-freebsd-rc@FreeBSD.ORG Wed Feb 21 23:28:00 2007 Return-Path: X-Original-To: freebsd-rc@hub.freebsd.org Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 801D216A402; Wed, 21 Feb 2007 23:28:00 +0000 (UTC) (envelope-from linimon@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40]) by mx1.freebsd.org (Postfix) with ESMTP id 58DAD13C467; Wed, 21 Feb 2007 23:28:00 +0000 (UTC) (envelope-from linimon@FreeBSD.org) Received: from freefall.freebsd.org (linimon@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id l1LNS0GT045602; Wed, 21 Feb 2007 23:28:00 GMT (envelope-from linimon@freefall.freebsd.org) Received: (from linimon@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id l1LNS0Or045598; Wed, 21 Feb 2007 23:28:00 GMT (envelope-from linimon) Date: Wed, 21 Feb 2007 23:28:00 GMT From: Mark Linimon Message-Id: <200702212328.l1LNS0Or045598@freefall.freebsd.org> To: linimon@FreeBSD.org, freebsd-bugs@FreeBSD.org, freebsd-rc@FreeBSD.org Cc: Subject: Re: conf/109409: [request] Add $rndc_program to specify path to rndc, similar to $named_program X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Feb 2007 23:28:00 -0000 Old Synopsis: Add $rndc_program to specify path to rndc, similar to $named_program New Synopsis: [request] Add $rndc_program to specify path to rndc, similar to $named_program Responsible-Changed-From-To: freebsd-bugs->freebsd-rc Responsible-Changed-By: linimon Responsible-Changed-When: Wed Feb 21 23:27:27 UTC 2007 Responsible-Changed-Why: Over to maintainer(s). http://www.freebsd.org/cgi/query-pr.cgi?pr=109409 From owner-freebsd-rc@FreeBSD.ORG Thu Feb 22 08:45:07 2007 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id B816516A404 for ; Thu, 22 Feb 2007 08:45:07 +0000 (UTC) (envelope-from tataz@tataz.chchile.org) Received: from postfix1-g20.free.fr (postfix1-g20.free.fr [212.27.60.42]) by mx1.freebsd.org (Postfix) with ESMTP id 3FDD213C428 for ; Thu, 22 Feb 2007 08:45:07 +0000 (UTC) (envelope-from tataz@tataz.chchile.org) Received: from smtp5-g19.free.fr (smtp5-g19.free.fr [212.27.42.35]) by postfix1-g20.free.fr (Postfix) with ESMTP id 54EBCA66A29 for ; Thu, 22 Feb 2007 09:22:29 +0100 (CET) Received: from tatooine.tataz.chchile.org (tataz.chchile.org [82.233.239.98]) by smtp5-g19.free.fr (Postfix) with ESMTP id C582B279D0; Thu, 22 Feb 2007 09:22:27 +0100 (CET) Received: from obiwan.tataz.chchile.org (unknown [192.168.1.25]) by tatooine.tataz.chchile.org (Postfix) with ESMTP id 464509BE05; Thu, 22 Feb 2007 08:24:22 +0000 (UTC) Received: by obiwan.tataz.chchile.org (Postfix, from userid 1000) id 11FA6405B; Thu, 22 Feb 2007 09:24:22 +0100 (CET) Date: Thu, 22 Feb 2007 09:24:21 +0100 From: Jeremie Le Hen To: Yar Tikhiy Message-ID: <20070222082421.GG2479@obiwan.tataz.chchile.org> References: <20070221231108.GC2479@obiwan.tataz.chchile.org> <20070222020250.GM54441@comp.chem.msu.su> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070222020250.GM54441@comp.chem.msu.su> User-Agent: Mutt/1.5.13 (2006-08-11) Cc: freebsd-rc@freebsd.org, Jeremie Le Hen Subject: Re: Using /etc/rc.d/devfs from command-line X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Feb 2007 08:45:07 -0000 Yar, all, Thank you for your feedback. Please Cc: me in reply. On Thu, Feb 22, 2007 at 05:02:51AM +0300, Yar Tikhiy wrote: > On Thu, Feb 22, 2007 at 12:11:08AM +0100, Jeremie Le Hen wrote: > > Hi, > > > > The attached patch allows to provide arguments to rc.d/devfs with > > the same syntax as $devfs_set_rulesets. This is then easier to mount > > manually devfs inside a directory and apply some predefined rulesets > > on it. Before this patch you had to manually apply rules to the > > devfs mount point, provided pre-configured rulesets had been loaded > > into the kernel (with rc.subr's devfs_init_rulesets()). > > This topic could be more appropriate on freebsd-rc. Granted. Sorry I haven't thought of it before my first post. > > [...previous patch snipped...] > > Excuse me, but the last part of your patch looks like an unjustified > hack. The proper way is to pass additional arguments to run_rc_command > so that it passes them on to the respective method. If you just > change > > run_rc_command "$1" > > to > > run_rc_command "$@" > > devfs_start() will get the additional arguments as its positional > parameters $1, $2, ... Then you will be able to detect that > there are such arguments and act correspondingly from devfs_start(). > > There are other examples in /etc/rc.d. Note that for some reason > they use $*, not "$@": > > run_rc_command $* > > I cannot think of a good reason to do so. Actually I only knew one rc.d script accepting command-line arguments (rc.d/jail) and wanted to stay as close to it as possible. Unfortunately this involved hijacking $start_cmd here. I've rewritten the script in a less hackish way following your advices. I have one concern though, I wonder whether devfs_init_rulesets() could be called unconditionally at the beginning of devfs_start() or not. The result would be to load pre-defined rulesets from devfs.rules(5) at boot time regardless $devfs_system_ruleset or $devfs_set_rulesets are defined. This surely should not be MFC'd though. Best regards, -- Jeremie Le Hen < jeremie at le-hen dot org >< ttz at chchile dot org > From owner-freebsd-rc@FreeBSD.ORG Thu Feb 22 08:56:35 2007 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id D2B6916A401 for ; Thu, 22 Feb 2007 08:56:35 +0000 (UTC) (envelope-from tataz@tataz.chchile.org) Received: from postfix2-g20.free.fr (postfix2-g20.free.fr [212.27.60.43]) by mx1.freebsd.org (Postfix) with ESMTP id 698DF13C474 for ; Thu, 22 Feb 2007 08:56:35 +0000 (UTC) (envelope-from tataz@tataz.chchile.org) Received: from smtp5-g19.free.fr (smtp5-g19.free.fr [212.27.42.35]) by postfix2-g20.free.fr (Postfix) with ESMTP id AE53BB37020 for ; Thu, 22 Feb 2007 08:23:27 +0100 (CET) Received: from tatooine.tataz.chchile.org (tataz.chchile.org [82.233.239.98]) by smtp5-g19.free.fr (Postfix) with ESMTP id 1464135A94; Thu, 22 Feb 2007 09:23:16 +0100 (CET) Received: from obiwan.tataz.chchile.org (unknown [192.168.1.25]) by tatooine.tataz.chchile.org (Postfix) with ESMTP id 9EDBB9BE05; Thu, 22 Feb 2007 08:25:10 +0000 (UTC) Received: by obiwan.tataz.chchile.org (Postfix, from userid 1000) id 8EE39405B; Thu, 22 Feb 2007 09:25:10 +0100 (CET) Date: Thu, 22 Feb 2007 09:25:10 +0100 From: Jeremie Le Hen To: Yar Tikhiy Message-ID: <20070222082510.GH2479@obiwan.tataz.chchile.org> References: <20070221231108.GC2479@obiwan.tataz.chchile.org> <20070222020250.GM54441@comp.chem.msu.su> <20070222082421.GG2479@obiwan.tataz.chchile.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="OROCMA9jn6tkzFBc" Content-Disposition: inline In-Reply-To: <20070222082421.GG2479@obiwan.tataz.chchile.org> User-Agent: Mutt/1.5.13 (2006-08-11) Cc: freebsd-rc@freebsd.org, Jeremie Le Hen Subject: Re: Using /etc/rc.d/devfs from command-line X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Feb 2007 08:56:36 -0000 --OROCMA9jn6tkzFBc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Feb 22, 2007 at 09:24:21AM +0100, Jeremie Le Hen wrote: > I've rewritten the script in a less hackish way following your advices. Better to attach the patch... -- Jeremie Le Hen < jeremie at le-hen dot org >< ttz at chchile dot org > --OROCMA9jn6tkzFBc Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="rc.d_devfs.patch" Index: devfs =================================================================== RCS file: /home/ncvs/src/etc/rc.d/devfs,v retrieving revision 1.12 diff -u -p -r1.12 devfs --- devfs 21 Jan 2006 14:31:45 -0000 1.12 +++ devfs 22 Feb 2007 08:04:16 -0000 @@ -14,8 +14,27 @@ name="devfs" start_cmd='devfs_start' stop_cmd=':' +set_rulesets() +{ + local _dir_set + local _dir + local _set + for _dir_set in "$@"; do + _dir=${_dir_set%=*} + _set=${_dir_set#*=} + devfs_set_ruleset $_set $_dir + devfs_apply_ruleset $_set $_dir + done +} + devfs_start() { + if [ $# -gt 0 ]; then + devfs_init_rulesets + set_rulesets "$@" + return + fi + if [ -n "$devfs_system_ruleset" -o -n "$devfs_set_rulesets" ]; then devfs_init_rulesets if [ -n "$devfs_system_ruleset" ]; then @@ -23,15 +42,7 @@ devfs_start() devfs_apply_ruleset $devfs_system_ruleset /dev fi if [ -n "$devfs_set_rulesets" ]; then - local _dir_set - local _dir - local _set - for _dir_set in $devfs_set_rulesets; do - _dir=${_dir_set%=*} - _set=${_dir_set#*=} - devfs_set_ruleset $_set $_dir - devfs_apply_ruleset $_set $_dir - done + set_rulesets "$devfs_set_rulesets" fi fi read_devfs_conf @@ -67,4 +78,4 @@ read_devfs_conf() } load_rc_config $name -run_rc_command "$1" +run_rc_command "$@" --OROCMA9jn6tkzFBc-- From owner-freebsd-rc@FreeBSD.ORG Thu Feb 22 09:19:12 2007 Return-Path: X-Original-To: freebsd-rc@hub.freebsd.org Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 788E216A402; Thu, 22 Feb 2007 09:19:12 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40]) by mx1.freebsd.org (Postfix) with ESMTP id 4C6FD13C4A5; Thu, 22 Feb 2007 09:19:12 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from freefall.freebsd.org (dougb@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id l1M9JClo083803; Thu, 22 Feb 2007 09:19:12 GMT (envelope-from dougb@freefall.freebsd.org) Received: (from dougb@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id l1M9JCBf083799; Thu, 22 Feb 2007 09:19:12 GMT (envelope-from dougb) Date: Thu, 22 Feb 2007 09:19:12 GMT From: Doug Barton Message-Id: <200702220919.l1M9JCBf083799@freefall.freebsd.org> To: china@thewrittenword.com, dougb@FreeBSD.org, freebsd-rc@FreeBSD.org, dougb@FreeBSD.org Cc: Subject: Re: conf/109409: [request] Add $rndc_program to specify path to rndc, similar to $named_program X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Feb 2007 09:19:12 -0000 Synopsis: [request] Add $rndc_program to specify path to rndc, similar to $named_program State-Changed-From-To: open->analyzed State-Changed-By: dougb State-Changed-When: Thu Feb 22 09:17:48 UTC 2007 State-Changed-Why: This is definitely not how I want to accomplish this. The proper way to deal with this is to have rc.d/named determine its PREFIX and run it's dependent programs relative to that. Responsible-Changed-From-To: freebsd-rc->dougb Responsible-Changed-By: dougb Responsible-Changed-When: Thu Feb 22 09:17:48 UTC 2007 Responsible-Changed-Why: I'm working on this problem. http://www.freebsd.org/cgi/query-pr.cgi?pr=109409 From owner-freebsd-rc@FreeBSD.ORG Thu Feb 22 17:51:44 2007 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 6179716A400 for ; Thu, 22 Feb 2007 17:51:44 +0000 (UTC) (envelope-from vd@datamax.bg) Received: from jengal.datamax.bg (jengal.datamax.bg [82.103.104.21]) by mx1.freebsd.org (Postfix) with ESMTP id 1E62013C4A7 for ; Thu, 22 Feb 2007 17:51:44 +0000 (UTC) (envelope-from vd@datamax.bg) Received: from qlovarnika.bg.datamax (qlovarnika.bg.datamax [192.168.10.2]) by jengal.datamax.bg (Postfix) with SMTP id 850ADB848; Thu, 22 Feb 2007 19:26:58 +0200 (EET) Received: (nullmailer pid 40689 invoked by uid 1002); Thu, 22 Feb 2007 17:26:58 -0000 Date: Thu, 22 Feb 2007 19:26:58 +0200 From: Vasil Dimov To: freebsd-rc@freebsd.org Message-ID: <20070222172658.GA40593@qlovarnika.bg.datamax> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="jRHKVT23PllUwdXP" Content-Disposition: inline Subject: Setting rc scripts default values X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: vd@FreeBSD.org List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Feb 2007 17:51:44 -0000 --jRHKVT23PllUwdXP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, Is there any special reason to write the rc scripts this way: load_rc_config "$name" : ${rsyncd_enable=3D"NO"} instead of this way: rsyncd_enable=3D"NO" load_rc_config "$name" apache does it this way: apache_enable=3D${apache_enable-"NO"} load_rc_config $name but I think it can safely be changed to apache_enable=3D"NO" load_rc_config $name What did I miss... --=20 Vasil Dimov gro.DSBeerF@dv % If it's green or wiggles, it's biology. If it stinks, it's chemistry. If it doesn't work, it's physics. --jRHKVT23PllUwdXP Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- iD8DBQFF3dJiFw6SP/bBpCARAugxAJwOz53P7fNX+n/gutc8UmEBXZviqwCg0FW6 TFA0V6ft6frwdY3Cjr0HCGU= =EfFV -----END PGP SIGNATURE----- --jRHKVT23PllUwdXP-- From owner-freebsd-rc@FreeBSD.ORG Thu Feb 22 22:25:32 2007 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 4580416A400 for ; Thu, 22 Feb 2007 22:25:32 +0000 (UTC) (envelope-from brooks@lor.one-eyed-alien.net) Received: from lor.one-eyed-alien.net (grnl-static-02-0046.dsl.iowatelecom.net [69.66.56.110]) by mx1.freebsd.org (Postfix) with ESMTP id 0180E13C442 for ; Thu, 22 Feb 2007 22:25:31 +0000 (UTC) (envelope-from brooks@lor.one-eyed-alien.net) Received: from lor.one-eyed-alien.net (localhost [127.0.0.1]) by lor.one-eyed-alien.net (8.13.8/8.13.8) with ESMTP id l1MMPUtx090870; Thu, 22 Feb 2007 16:25:30 -0600 (CST) (envelope-from brooks@lor.one-eyed-alien.net) Received: (from brooks@localhost) by lor.one-eyed-alien.net (8.13.8/8.13.8/Submit) id l1MMPQFU090868; Thu, 22 Feb 2007 16:25:26 -0600 (CST) (envelope-from brooks) Date: Thu, 22 Feb 2007 16:25:26 -0600 From: Brooks Davis To: Vasil Dimov Message-ID: <20070222222526.GA90840@lor.one-eyed-alien.net> References: <20070222172658.GA40593@qlovarnika.bg.datamax> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="oyUTqETQ0mS9luUI" Content-Disposition: inline In-Reply-To: <20070222172658.GA40593@qlovarnika.bg.datamax> User-Agent: Mutt/1.5.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-3.0 (lor.one-eyed-alien.net [127.0.0.1]); Thu, 22 Feb 2007 16:25:31 -0600 (CST) Cc: freebsd-rc@freebsd.org Subject: Re: Setting rc scripts default values X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Feb 2007 22:25:32 -0000 --oyUTqETQ0mS9luUI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Feb 22, 2007 at 07:26:58PM +0200, Vasil Dimov wrote: > Hi, >=20 > Is there any special reason to write the rc scripts this way: >=20 > load_rc_config "$name" > : ${rsyncd_enable=3D"NO"} >=20 > instead of this way: >=20 > rsyncd_enable=3D"NO" > load_rc_config "$name" >=20 > apache does it this way: >=20 > apache_enable=3D${apache_enable-"NO"} > load_rc_config $name >=20 > but I think it can safely be changed to >=20 > apache_enable=3D"NO" > load_rc_config $name >=20 > What did I miss... load_rc_config doesn't reread /etc/rc.conf every time. -- Brooks --oyUTqETQ0mS9luUI Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQFF3hhVXY6L6fI4GtQRArvVAJ9Pw2GmlRf65N/zHLB54qLVRavSrwCgkSjR BBrR8U4qWsRVs11uOk+xDQA= =jdH/ -----END PGP SIGNATURE----- --oyUTqETQ0mS9luUI-- From owner-freebsd-rc@FreeBSD.ORG Fri Feb 23 06:34:29 2007 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 271B716A401; Fri, 23 Feb 2007 06:34:29 +0000 (UTC) (envelope-from vd@datamax.bg) Received: from jengal.datamax.bg (jengal.datamax.bg [82.103.104.21]) by mx1.freebsd.org (Postfix) with ESMTP id CB38113C48D; Fri, 23 Feb 2007 06:34:28 +0000 (UTC) (envelope-from vd@datamax.bg) Received: from qlovarnika.bg.datamax (qlovarnika.bg.datamax [192.168.10.2]) by jengal.datamax.bg (Postfix) with SMTP id 13EFAB848; Fri, 23 Feb 2007 08:34:28 +0200 (EET) Received: (nullmailer pid 96333 invoked by uid 1002); Fri, 23 Feb 2007 06:34:28 -0000 Date: Fri, 23 Feb 2007 08:34:28 +0200 From: Vasil Dimov To: Brooks Davis Message-ID: <20070223063428.GA96292@qlovarnika.bg.datamax> References: <20070222172658.GA40593@qlovarnika.bg.datamax> <20070222222526.GA90840@lor.one-eyed-alien.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="fdj2RfSjLxBAspz7" Content-Disposition: inline In-Reply-To: <20070222222526.GA90840@lor.one-eyed-alien.net> Cc: freebsd-rc@freebsd.org Subject: Re: Setting rc scripts default values X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: vd@FreeBSD.org List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Feb 2007 06:34:29 -0000 --fdj2RfSjLxBAspz7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Feb 22, 2007 at 16:25:26 -0600, Brooks Davis wrote: > On Thu, Feb 22, 2007 at 07:26:58PM +0200, Vasil Dimov wrote: > > Hi, > >=20 > > Is there any special reason to write the rc scripts this way: > >=20 > > load_rc_config "$name" > > : ${rsyncd_enable=3D"NO"} > >=20 > > instead of this way: > >=20 > > rsyncd_enable=3D"NO" > > load_rc_config "$name" > >=20 > > apache does it this way: > >=20 > > apache_enable=3D${apache_enable-"NO"} > > load_rc_config $name > >=20 > > but I think it can safely be changed to > >=20 > > apache_enable=3D"NO" > > load_rc_config $name > >=20 > > What did I miss... >=20 > load_rc_config doesn't reread /etc/rc.conf every time. Hmmz, I see that load_rc_config() does not reread /etc/rc.conf only if _rc_conf_loaded is set. The only place where _rc_conf_loaded is set is in load_rc_config() itself after it reads /etc/rc.conf. load_rc_config() is not called anywhere in rc.subr [1]. Can you show me a scenario where this code: =2E /etc/rc.subr rcvar=3D`set_rcvar` foo_enable=3D"NO" load_rc_config ${name} # foo_enable=3D"YES" is in /etc/rc.conf ends up with foo_enable=3D"NO"? Thanks. [1] actually it is called from load_rc_config_var() but in a subshell. --=20 Vasil Dimov gro.DSBeerF@dv % Testing can show the presense of bugs, but not their absence. -- Edsger W. Dijkstra --fdj2RfSjLxBAspz7 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- iD8DBQFF3or0Fw6SP/bBpCARAtmGAKDh4iwuKYlcXYQqwAL4rbzwZKcvHgCdGw/y POzlu2q3pDsW4D2W8zSwWi4= =LbQZ -----END PGP SIGNATURE----- --fdj2RfSjLxBAspz7-- From owner-freebsd-rc@FreeBSD.ORG Fri Feb 23 06:56:46 2007 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id A7DA616A400; Fri, 23 Feb 2007 06:56:46 +0000 (UTC) (envelope-from brooks@lor.one-eyed-alien.net) Received: from lor.one-eyed-alien.net (grnl-static-02-0046.dsl.iowatelecom.net [69.66.56.110]) by mx1.freebsd.org (Postfix) with ESMTP id 4BEF113C442; Fri, 23 Feb 2007 06:56:46 +0000 (UTC) (envelope-from brooks@lor.one-eyed-alien.net) Received: from lor.one-eyed-alien.net (localhost [127.0.0.1]) by lor.one-eyed-alien.net (8.13.8/8.13.8) with ESMTP id l1N6uiMA094418; Fri, 23 Feb 2007 00:56:44 -0600 (CST) (envelope-from brooks@lor.one-eyed-alien.net) Received: (from brooks@localhost) by lor.one-eyed-alien.net (8.13.8/8.13.8/Submit) id l1N6uiLA094417; Fri, 23 Feb 2007 00:56:44 -0600 (CST) (envelope-from brooks) Date: Fri, 23 Feb 2007 00:56:44 -0600 From: Brooks Davis To: Vasil Dimov Message-ID: <20070223065644.GA94159@lor.one-eyed-alien.net> References: <20070222172658.GA40593@qlovarnika.bg.datamax> <20070222222526.GA90840@lor.one-eyed-alien.net> <20070223063428.GA96292@qlovarnika.bg.datamax> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="n8g4imXOkfNTN/H1" Content-Disposition: inline In-Reply-To: <20070223063428.GA96292@qlovarnika.bg.datamax> User-Agent: Mutt/1.5.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-3.0 (lor.one-eyed-alien.net [127.0.0.1]); Fri, 23 Feb 2007 00:56:44 -0600 (CST) Cc: Brooks Davis , freebsd-rc@freebsd.org Subject: Re: Setting rc scripts default values X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Feb 2007 06:56:46 -0000 --n8g4imXOkfNTN/H1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Feb 23, 2007 at 08:34:28AM +0200, Vasil Dimov wrote: > On Thu, Feb 22, 2007 at 16:25:26 -0600, Brooks Davis wrote: > > On Thu, Feb 22, 2007 at 07:26:58PM +0200, Vasil Dimov wrote: > > > Hi, > > >=20 > > > Is there any special reason to write the rc scripts this way: > > >=20 > > > load_rc_config "$name" > > > : ${rsyncd_enable=3D"NO"} > > >=20 > > > instead of this way: > > >=20 > > > rsyncd_enable=3D"NO" > > > load_rc_config "$name" > > >=20 > > > apache does it this way: > > >=20 > > > apache_enable=3D${apache_enable-"NO"} > > > load_rc_config $name > > >=20 > > > but I think it can safely be changed to > > >=20 > > > apache_enable=3D"NO" > > > load_rc_config $name > > >=20 > > > What did I miss... > >=20 > > load_rc_config doesn't reread /etc/rc.conf every time. >=20 > Hmmz, I see that load_rc_config() does not reread /etc/rc.conf only if > _rc_conf_loaded is set. The only place where _rc_conf_loaded is set is > in load_rc_config() itself after it reads /etc/rc.conf. load_rc_config() > is not called anywhere in rc.subr [1]. >=20 > Can you show me a scenario where this code: >=20 > . /etc/rc.subr > rcvar=3D`set_rcvar` > foo_enable=3D"NO" > load_rc_config ${name} # foo_enable=3D"YES" is in /etc/rc.conf >=20 > ends up with foo_enable=3D"NO"? >=20 > Thanks. load_rc_config is called from /etc/rc before any scripts are run on startup. If that doesn't result in _rc_conf_loaded being set in the script, the code is useless and should be ripped out (I'm not entierly sure it isn't useless, but it's late here and I'm not going to test it now). -- Brooks --n8g4imXOkfNTN/H1 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQFF3pArXY6L6fI4GtQRAtXdAKCLsr+/admCKTBVmKDkM0cUMb7A0gCfTARs Ca1kkhbYPo/f8MSHjJdsaGg= =YgOs -----END PGP SIGNATURE----- --n8g4imXOkfNTN/H1-- From owner-freebsd-rc@FreeBSD.ORG Fri Feb 23 07:18:42 2007 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id BF0E416A400; Fri, 23 Feb 2007 07:18:42 +0000 (UTC) (envelope-from vd@datamax.bg) Received: from jengal.datamax.bg (jengal.datamax.bg [82.103.104.21]) by mx1.freebsd.org (Postfix) with ESMTP id 74EE113C48E; Fri, 23 Feb 2007 07:18:42 +0000 (UTC) (envelope-from vd@datamax.bg) Received: from qlovarnika.bg.datamax (qlovarnika.bg.datamax [192.168.10.2]) by jengal.datamax.bg (Postfix) with SMTP id 53768B848; Fri, 23 Feb 2007 09:18:41 +0200 (EET) Received: (nullmailer pid 96745 invoked by uid 1002); Fri, 23 Feb 2007 07:18:41 -0000 Date: Fri, 23 Feb 2007 09:18:41 +0200 From: Vasil Dimov To: Brooks Davis Message-ID: <20070223071841.GA96708@qlovarnika.bg.datamax> References: <20070222172658.GA40593@qlovarnika.bg.datamax> <20070222222526.GA90840@lor.one-eyed-alien.net> <20070223063428.GA96292@qlovarnika.bg.datamax> <20070223065644.GA94159@lor.one-eyed-alien.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="+HP7ph2BbKc20aGI" Content-Disposition: inline In-Reply-To: <20070223065644.GA94159@lor.one-eyed-alien.net> Cc: freebsd-rc@freebsd.org Subject: Re: Setting rc scripts default values X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: vd@FreeBSD.org List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Feb 2007 07:18:42 -0000 --+HP7ph2BbKc20aGI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Feb 23, 2007 at 00:56:44 -0600, Brooks Davis wrote: > On Fri, Feb 23, 2007 at 08:34:28AM +0200, Vasil Dimov wrote: [...] > > Can you show me a scenario where this code: > >=20 > > . /etc/rc.subr > > rcvar=3D`set_rcvar` > > foo_enable=3D"NO" > > load_rc_config ${name} # foo_enable=3D"YES" is in /etc/rc.conf > >=20 > > ends up with foo_enable=3D"NO"? > >=20 > > Thanks. >=20 > load_rc_config is called from /etc/rc before any scripts are run on > startup. If that doesn't result in _rc_conf_loaded being set in the > script, the code is useless and should be ripped out (I'm not entierly > sure it isn't useless, but it's late here and I'm not going to test it > now). Thanks, I got a clue... --=20 Vasil Dimov gro.DSBeerF@dv % Those who desire to give up freedom in order to gain security, will not hav= e, nor do they deserve, either one. -- Benjamin Franklin --+HP7ph2BbKc20aGI Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- iD8DBQFF3pVRFw6SP/bBpCARAiLQAJsF1j6Wg//B9cGpL2h6azRH5bkznQCgxF5X xMuANQY21pLQfpsxAobng9Q= =41sw -----END PGP SIGNATURE----- --+HP7ph2BbKc20aGI--