From owner-freebsd-scsi@FreeBSD.ORG Sun Sep 16 12:21:18 2007 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3E56916A46D for ; Sun, 16 Sep 2007 12:21:18 +0000 (UTC) (envelope-from uspoerlein@gmail.com) Received: from nf-out-0910.google.com (nf-out-0910.google.com [64.233.182.189]) by mx1.freebsd.org (Postfix) with ESMTP id 7CF1513C469 for ; Sun, 16 Sep 2007 12:21:17 +0000 (UTC) (envelope-from uspoerlein@gmail.com) Received: by nf-out-0910.google.com with SMTP id b2so932824nfb for ; Sun, 16 Sep 2007 05:21:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:received:received:date:from:to:cc:subject:message-id:mail-followup-to:references:mime-version:content-type:content-disposition:in-reply-to:user-agent; bh=7jt5EMNeDiLTsMeliJuwoUCndXf5PYRoooC6utzTGlI=; b=b9/sS/huvuu46E8K8hnqq4HrKSpOLrfV5GRCavTOmVL+jrS+mknoxczP3lTch1KLnilgD3NVCumTqt96JY7k80Bq5bqfKgf17dxR61NelNf/j6vfQ0R+vcBIk2eiqZtf2ESnF/DIMeggf6JkuJ7WmGLdJkhPsUXYXtV+hCTr/Lc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:date:from:to:cc:subject:message-id:mail-followup-to:references:mime-version:content-type:content-disposition:in-reply-to:user-agent; b=WpIHnHhGn+0gsjHVrGe/jpBZX+mXKqtQm1ZP4GLVpdVdMKDGZOWJcGbPper+cLcgIeSZVk/ngDFbu7SpSaQKq+MgasyvulmjtdNEMh9GzZ0d1DtielX8vRIt7Ltk2YBR27vmdfA8UjB/Z7jf4oLE9Mvk5fP6TGZS97UQE2SQ27k= Received: by 10.78.168.1 with SMTP id q1mr1983352hue.1189943674468; Sun, 16 Sep 2007 04:54:34 -0700 (PDT) Received: from roadrunner.spoerlein.net ( [85.180.170.233]) by mx.google.com with ESMTPS id 39sm2847866hug.2007.09.16.04.54.33 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 16 Sep 2007 04:54:33 -0700 (PDT) Received: from roadrunner.spoerlein.net (localhost [127.0.0.1]) by roadrunner.spoerlein.net (8.14.1/8.14.1) with ESMTP id l8GBsSI1001627; Sun, 16 Sep 2007 13:54:28 +0200 (CEST) (envelope-from uspoerlein@gmail.com) Received: (from q@localhost) by roadrunner.spoerlein.net (8.14.1/8.14.1/Submit) id l8GBsSS5001626; Sun, 16 Sep 2007 13:54:28 +0200 (CEST) (envelope-from uspoerlein@gmail.com) Date: Sun, 16 Sep 2007 13:54:27 +0200 From: Ulrich Spoerlein To: Scott Long Message-ID: <20070916115427.GA1427@roadrunner.spoerlein.net> Mail-Followup-To: Scott Long , freebsd-scsi@FreeBSD.ORG, freebsd-current@FreeBSD.ORG, njl@FreeBSD.ORG References: <46E615C4.1010605@samsco.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <46E615C4.1010605@samsco.org> User-Agent: Mutt/1.5.16 (2007-06-09) Cc: freebsd-scsi@FreeBSD.ORG, njl@FreeBSD.ORG, freebsd-current@FreeBSD.ORG Subject: Re: Retirement of CAM_QUIRK_NOSERIAL X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Sep 2007 12:21:18 -0000 On Mon, 10.09.2007 at 22:12:52 -0600, Scott Long wrote: > All, > > The attached patch should make CAM behave properly with regard to > probing device serial numbers only when the device advertises that > it supports it. It will hopefully eliminate the need for the > CAM_QUIRK_NOSERIAL quirk (one instance is left because of an unrelated > legacy problem that may or may not be possible to fix). This should > especially benefit USB-UMASS devices, where the console output should > be less noisy. It might even make more devices work out-of-the-box. While this patch is working fine with my USB/FW HDD enclosure, it breaks my MP3 USB stick kernel: umass0: on uhub5 kernel: umass0: BBB reset failed, IOERROR kernel: umass0: BBB bulk-in clear stall failed, IOERROR kernel: umass0: BBB bulk-out clear stall failed, IOERROR kernel: umass0: BBB reset failed, IOERROR kernel: umass0: BBB bulk-in clear stall failed, IOERROR kernel: umass0: BBB bulk-out clear stall failed, IOERROR kernel: umass0: BBB reset failed, IOERROR kernel: umass0: BBB bulk-in clear stall failed, IOERROR kernel: umass0: BBB bulk-out clear stall failed, IOERROR kernel: umass0: BBB reset failed, IOERROR kernel: umass0: BBB bulk-in clear stall failed, IOERROR kernel: umass0: BBB bulk-out clear stall failed, IOERROR kernel: umass0: BBB reset failed, IOERROR kernel: umass0: BBB bulk-in clear stall failed, IOERROR kernel: umass0: BBB bulk-out clear stall failed, IOERROR kernel: umass0: BBB reset failed, IOERROR kernel: umass0: BBB bulk-in clear stall failed, IOERROR kernel: umass0: BBB bulk-out clear stall failed, IOERROR kernel: umass0: BBB reset failed, IOERROR kernel: umass0: BBB bulk-in clear stall failed, IOERROR kernel: umass0: BBB bulk-out clear stall failed, IOERROR kernel: umass0: BBB reset failed, IOERROR kernel: umass0: BBB bulk-in clear stall failed, IOERROR kernel: umass0: BBB bulk-out clear stall failed, IOERROR kernel: umass0: BBB reset failed, IOERROR kernel: umass0: BBB bulk-in clear stall failed, IOERROR kernel: umass0: BBB bulk-out clear stall failed, IOERROR kernel: umass0: BBB reset failed, IOERROR kernel: umass0: BBB bulk-in clear stall failed, IOERROR kernel: umass0: BBB bulk-out clear stall failed, IOERROR kernel: umass0: BBB reset failed, IOERROR kernel: umass0: BBB bulk-in clear stall failed, IOERROR kernel: umass0: BBB bulk-out clear stall failed, IOERROR kernel: (da0:umass-sim0:0:0:0): got CAM status 0x4 kernel: (da0:umass-sim0:0:0:0): fatal error, failed to attach to device kernel: (da0:umass-sim0:0:0:0): lost device kernel: cam_debug: queuing for immediate ccb kernel: umass0: BBB reset failed, IOERROR kernel: umass0: BBB bulk-in clear stall failed, IOERROR kernel: umass0: BBB bulk-out clear stall failed, IOERROR kernel: umass0: BBB reset failed, IOERROR kernel: umass0: BBB bulk-in clear stall failed, IOERROR kernel: umass0: BBB bulk-out clear stall failed, IOERROR kernel: umass0: BBB reset failed, IOERROR kernel: umass0: BBB bulk-in clear stall failed, IOERROR kernel: umass0: BBB bulk-out clear stall failed, IOERROR kernel: umass0: BBB reset failed, IOERROR kernel: umass0: BBB bulk-in clear stall failed, IOERROR kernel: umass0: BBB bulk-out clear stall failed, IOERROR kernel: umass0: BBB reset failed, IOERROR kernel: umass0: BBB bulk-in clear stall failed, IOERROR kernel: umass0: BBB bulk-out clear stall failed, IOERROR kernel: (da0:umass-sim0:0:0:0): removing device entry This stick needs the SHUTTLE_INIT | NO_GETMAXLUN quirk. Perhaps there is some interdependencies? The patch also, does not magically allow me to read retail DVDs through my Plextor drive when attached via cd(4), but that is not the goal of the patch anyway. It's funny, though. If I quirk this Plextor DVD to NO_INQUIRY, it will attach via da(4) (sic!) and suddenly all kinds of DVD media start working! umass0: on uhub5 da0 at umass-sim0 bus 0 target 0 lun 0 da0: < > Removable Direct Access SCSI-2 device da0: 40.000MB/s transfers da0: 3001MB (1536688 2048 byte sectors: 255H 63S/T 95C) Cheers, Ulrich Spoerlein -- It is better to remain silent and be thought a fool, than to speak, and remove all doubt. From owner-freebsd-scsi@FreeBSD.ORG Sun Sep 16 17:48:04 2007 Return-Path: Delivered-To: freebsd-scsi@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BE45916A419; Sun, 16 Sep 2007 17:48:04 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.freebsd.org (Postfix) with ESMTP id 573E813C458; Sun, 16 Sep 2007 17:48:04 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from [192.168.254.15] (ydesk.samsco.home [192.168.254.15]) (authenticated bits=0) by pooker.samsco.org (8.13.8/8.13.8) with ESMTP id l8GHm0N0080646; Sun, 16 Sep 2007 11:48:00 -0600 (MDT) (envelope-from scottl@samsco.org) Message-ID: <46ED6C50.4040104@samsco.org> Date: Sun, 16 Sep 2007 11:48:00 -0600 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.7) Gecko/20050416 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Ulrich Spoerlein References: <46E615C4.1010605@samsco.org> <20070916115427.GA1427@roadrunner.spoerlein.net> In-Reply-To: <20070916115427.GA1427@roadrunner.spoerlein.net> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (pooker.samsco.org [192.168.254.1]); Sun, 16 Sep 2007 11:48:01 -0600 (MDT) X-Spam-Status: No, score=-1.4 required=5.5 tests=ALL_TRUSTED autolearn=failed version=3.1.8 X-Spam-Checker-Version: SpamAssassin 3.1.8 (2007-02-13) on pooker.samsco.org Cc: freebsd-scsi@FreeBSD.ORG, njl@FreeBSD.ORG, freebsd-current@FreeBSD.ORG Subject: Re: Retirement of CAM_QUIRK_NOSERIAL X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Sep 2007 17:48:04 -0000 Ulrich Spoerlein wrote: > On Mon, 10.09.2007 at 22:12:52 -0600, Scott Long wrote: > >>All, >> >>The attached patch should make CAM behave properly with regard to >>probing device serial numbers only when the device advertises that >>it supports it. It will hopefully eliminate the need for the >>CAM_QUIRK_NOSERIAL quirk (one instance is left because of an unrelated >>legacy problem that may or may not be possible to fix). This should >>especially benefit USB-UMASS devices, where the console output should >>be less noisy. It might even make more devices work out-of-the-box. > > > While this patch is working fine with my USB/FW HDD enclosure, it breaks > my MP3 USB stick > > kernel: umass0: on uhub5 > kernel: umass0: BBB reset failed, IOERROR > kernel: umass0: BBB bulk-in clear stall failed, IOERROR > kernel: umass0: BBB bulk-out clear stall failed, IOERROR Is this a regression of something that works without the patch, or is it something that has never worked? What happens if you use the NO_INQUIRY_EVPD quirk instead? > > This stick needs the SHUTTLE_INIT | NO_GETMAXLUN quirk. Perhaps there is some > interdependencies? Likely only to the extent that this is a pretty difficult device to deal with. > > The patch also, does not magically allow me to read retail DVDs through my > Plextor drive when attached via cd(4), but that is not the goal of the patch > anyway. Actually, I was hoping that it would =-) > > It's funny, though. If I quirk this Plextor DVD to NO_INQUIRY, it will attach > via da(4) (sic!) and suddenly all kinds of DVD media start working! > > umass0: on uhub5 > da0 at umass-sim0 bus 0 target 0 lun 0 > da0: < > Removable Direct Access SCSI-2 device > da0: 40.000MB/s transfers > da0: 3001MB (1536688 2048 byte sectors: 255H 63S/T 95C) > I'm honestly having a really hard time believing that a device could claim to support "SCSI" but not support a basic INQUIRY command. That's the one command that is absolutely essential to any SCSI device. What if you try the NO_INQUIRY_EVPD or FORCE_SHORT_INQUIRY quirks? Scott From owner-freebsd-scsi@FreeBSD.ORG Sun Sep 16 21:12:09 2007 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6B9C116A41A for ; Sun, 16 Sep 2007 21:12:09 +0000 (UTC) (envelope-from uspoerlein@gmail.com) Received: from nf-out-0910.google.com (nf-out-0910.google.com [64.233.182.184]) by mx1.freebsd.org (Postfix) with ESMTP id EB25613C46B for ; Sun, 16 Sep 2007 21:12:08 +0000 (UTC) (envelope-from uspoerlein@gmail.com) Received: by nf-out-0910.google.com with SMTP id b2so993183nfb for ; Sun, 16 Sep 2007 14:12:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:received:received:date:from:to:cc:subject:message-id:mail-followup-to:references:mime-version:content-type:content-disposition:in-reply-to:user-agent; bh=aB/4Fa3E4IC6q0mp+6ihejY/LET9sEL++iQXr/M9oyc=; b=hSb5C23heywC95l+q9+MpQX6rUDutBPQYSHe7frudIe2pp9wBXbmHtr+T4TeGUTpzfGii2cS1JbBLFuXSpB6bJRYhUh4zeTUfjJC46Ts/FPCtchpyWv6d668UtvOvKC78Oz/CNe6tmEp8Y5qFUzhZ1DQuBQmRoroCLZ0fw4WlbQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:date:from:to:cc:subject:message-id:mail-followup-to:references:mime-version:content-type:content-disposition:in-reply-to:user-agent; b=VmxP81sm+e2xxU/sZD2xZdvpPyt5DsRI3C3NLeG1OlxBc2SA6sWGvngD1gs+EfSoLVr2iS3A6dZPmZSEAR2+0ih//s3z1M2JeR/d6F0RQ/J4iClfN04QQGAn0dV0Dl9DrOBlH+gT/3eKlsliJAfa3vqg/8fZxdlYqfCnpXqYEVY= Received: by 10.86.28.5 with SMTP id b5mr3146485fgb.1189977127489; Sun, 16 Sep 2007 14:12:07 -0700 (PDT) Received: from roadrunner.spoerlein.net ( [85.180.170.233]) by mx.google.com with ESMTPS id e32sm6838078fke.2007.09.16.14.12.06 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 16 Sep 2007 14:12:06 -0700 (PDT) Received: from roadrunner.spoerlein.net (localhost [127.0.0.1]) by roadrunner.spoerlein.net (8.14.1/8.14.1) with ESMTP id l8GLBrjX002521; Sun, 16 Sep 2007 23:11:53 +0200 (CEST) (envelope-from uspoerlein@gmail.com) Received: (from q@localhost) by roadrunner.spoerlein.net (8.14.1/8.14.1/Submit) id l8GLBmaU002520; Sun, 16 Sep 2007 23:11:48 +0200 (CEST) (envelope-from uspoerlein@gmail.com) Date: Sun, 16 Sep 2007 23:11:48 +0200 From: Ulrich Spoerlein To: Scott Long Message-ID: <20070916211148.GB1574@roadrunner.spoerlein.net> Mail-Followup-To: Scott Long , freebsd-scsi@FreeBSD.ORG, freebsd-current@FreeBSD.ORG, njl@FreeBSD.ORG References: <46E615C4.1010605@samsco.org> <20070916115427.GA1427@roadrunner.spoerlein.net> <46ED6C50.4040104@samsco.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <46ED6C50.4040104@samsco.org> User-Agent: Mutt/1.5.16 (2007-06-09) Cc: freebsd-scsi@FreeBSD.ORG, njl@FreeBSD.ORG, freebsd-current@FreeBSD.ORG Subject: Re: Retirement of CAM_QUIRK_NOSERIAL X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Sep 2007 21:12:09 -0000 On Sun, 16.09.2007 at 11:48:00 -0600, Scott Long wrote: > Ulrich Spoerlein wrote: > > While this patch is working fine with my USB/FW HDD enclosure, it breaks > > my MP3 USB stick > > kernel: umass0: on uhub5 > > kernel: umass0: BBB reset failed, IOERROR > > kernel: umass0: BBB bulk-in clear stall failed, IOERROR > > kernel: umass0: BBB bulk-out clear stall failed, IOERROR > > Is this a regression of something that works without the patch, or is > it something that has never worked? What happens if you use the > NO_INQUIRY_EVPD quirk instead? This is a regression, I will test the EVPD quirk tomorrow ... > > It's funny, though. If I quirk this Plextor DVD to NO_INQUIRY, it will > > attach > > via da(4) (sic!) and suddenly all kinds of DVD media start working! > > umass0: on uhub5 > > da0 at umass-sim0 bus 0 target 0 lun 0 > > da0: < > Removable Direct Access SCSI-2 device da0: 40.000MB/s transfers > > da0: 3001MB (1536688 2048 byte sectors: 255H 63S/T 95C) > > I'm honestly having a really hard time believing that a device could > claim to support "SCSI" but not support a basic INQUIRY command. That's > the one command that is absolutely essential to any SCSI device. What > if you try the NO_INQUIRY_EVPD or FORCE_SHORT_INQUIRY quirks? Sorry for not making myself clear. The device has always attached via cd(4) and worked for CD and self-burned DVD, but not retail DVD. If I quirk it, it will attach via da(4) *instead* of cd(4), and retail DVD magically start working. If I use atausb(4)/acd(4) some of the retail DVDs work and if I extract the drive from the case and attach it via atapi(4)/acd(4) everything is working fine, too. It is only cd(4) that is not grokking retail DVDs, be it via umass(4) or sbp(4). I doubt your patch is intended to change the runtime behaviour of cd(4) with respect to handling inserted media, right? I'll give those quirks you mentioned a try, but that will only fix the umass(4)/cd(4) issue, not the sbp(4)/cd(4) one. Cheers, Ulrich Spoerlein -- It is better to remain silent and be thought a fool, than to speak, and remove all doubt. From owner-freebsd-scsi@FreeBSD.ORG Mon Sep 17 11:08:17 2007 Return-Path: Delivered-To: freebsd-scsi@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 73F6E16A4D7 for ; Mon, 17 Sep 2007 11:08:17 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 5BC2E13C465 for ; Mon, 17 Sep 2007 11:08:17 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.1/8.14.1) with ESMTP id l8HB8Hak049521 for ; Mon, 17 Sep 2007 11:08:17 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.1/8.14.1/Submit) id l8HB8G3t049517 for freebsd-scsi@FreeBSD.org; Mon, 17 Sep 2007 11:08:16 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 17 Sep 2007 11:08:16 GMT Message-Id: <200709171108.l8HB8G3t049517@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: gnats set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-scsi@FreeBSD.org Cc: Subject: Current problem reports assigned to you X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Sep 2007 11:08:17 -0000 Current FreeBSD problem reports Critical problems Serious problems S Tracker Resp. Description -------------------------------------------------------------------------------- o kern/39388 scsi ncr/sym drivers fail with 53c810 and more than 256MB m o kern/40895 scsi wierd kernel / device driver bug o kern/52638 scsi [panic] SCSI U320 on SMP server won't run faster than s kern/57398 scsi [mly] Current fails to install on mly(4) based RAID di o kern/60598 scsi wire down of scsi devices conflicts with config o kern/60641 scsi [sym] Sporadic SCSI bus resets with 53C810 under load s kern/61165 scsi [panic] kernel page fault after calling cam_send_ccb o kern/74627 scsi [ahc] [hang] Adaptec 2940U2W Can't boot 5.3 o kern/81887 scsi [aac] Adaptec SCSI 2130S aac0: GetDeviceProbeInfo comm o kern/90282 scsi [sym] SCSI bus resets cause loss of ch device o kern/92798 scsi [ahc] SCSI problem with timeouts o kern/93128 scsi [sym] FreeBSD 6.1 BETA 1 has problems with Symbios/LSI o kern/94838 scsi Kernel panic while mounting SD card with lock switch o o kern/99954 scsi [ahc] reading from DVD failes on 6.x (regression) o kern/110847 scsi [ahd] Tyan U320 onboard problem with more than 3 disks 15 problems total. Non-critical problems S Tracker Resp. Description -------------------------------------------------------------------------------- o kern/23314 scsi [aic] aic driver fails to detect Adaptec 1520B unless o kern/35234 scsi World access to /dev/pass? (for scanner) requires acce o kern/38828 scsi [feature request] DPT PM2012B/90 doesn't work o kern/44587 scsi dev/dpt/dpt.h is missing defines required for DPT_HAND o kern/76178 scsi [ahd] Problem with ahd and large SCSI Raid system o kern/114597 scsi [sym] System hangs at SCSI bus reset with dual HBAs 6 problems total. From owner-freebsd-scsi@FreeBSD.ORG Tue Sep 18 20:23:00 2007 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2DF2F16A46B for ; Tue, 18 Sep 2007 20:23:00 +0000 (UTC) (envelope-from uspoerlein@gmail.com) Received: from nf-out-0910.google.com (nf-out-0910.google.com [64.233.182.186]) by mx1.freebsd.org (Postfix) with ESMTP id 00EE113C4B5 for ; Tue, 18 Sep 2007 20:22:58 +0000 (UTC) (envelope-from uspoerlein@gmail.com) Received: by nf-out-0910.google.com with SMTP id b2so1520779nfb for ; Tue, 18 Sep 2007 13:22:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:received:received:date:from:to:cc:subject:message-id:mail-followup-to:references:mime-version:content-type:content-disposition:in-reply-to:user-agent; bh=IoiYFbMKieWHWmAvwq530lFhpUJjcxGGloLsp0qA4eY=; b=EYAFRagqPf9cpVWY/4ddpJl6M8SrB5TFMY1BcJHPijYiDDDupLNeWnlcVlOtVHDww+iSdieL6MSARR2lYWYRmrGmXzAgsZ0viMXXwJyg2Aa9bMB9fHywhqxVVUEIvHdtFpTBuvE+CH8O/c/C3Jn1AO9XI+1mFFVjde7AM1+ti44= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:date:from:to:cc:subject:message-id:mail-followup-to:references:mime-version:content-type:content-disposition:in-reply-to:user-agent; b=BbUIELtpnrghbQ6nKtqWpxB1f2CnL83oY/LOJM7lveWbEYjFOlFS7r6yZiLho07YmJKN/K4kKaE8E2/Q06mCHV3//3LMRsW2Qvn6xQBOl0w/GAoqrI0TdbFFquFNy7GjuxHe4KwRpiGTVWMOqFg7oQBt2bM87eX62T2gPmLtd1g= Received: by 10.86.80.5 with SMTP id d5mr4934642fgb.1190146977585; Tue, 18 Sep 2007 13:22:57 -0700 (PDT) Received: from roadrunner.spoerlein.net ( [85.180.172.144]) by mx.google.com with ESMTPS id b17sm11033940fka.2007.09.18.13.22.56 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 18 Sep 2007 13:22:57 -0700 (PDT) Received: from roadrunner.spoerlein.net (localhost [127.0.0.1]) by roadrunner.spoerlein.net (8.14.1/8.14.1) with ESMTP id l8IKMpKB001445; Tue, 18 Sep 2007 22:22:51 +0200 (CEST) (envelope-from uspoerlein@gmail.com) Received: (from q@localhost) by roadrunner.spoerlein.net (8.14.1/8.14.1/Submit) id l8IKMopD001444; Tue, 18 Sep 2007 22:22:50 +0200 (CEST) (envelope-from uspoerlein@gmail.com) Date: Tue, 18 Sep 2007 22:22:50 +0200 From: Ulrich Spoerlein To: Scott Long Message-ID: <20070918202250.GA1403@roadrunner.spoerlein.net> Mail-Followup-To: Scott Long , freebsd-scsi@FreeBSD.ORG, freebsd-current@FreeBSD.ORG, njl@FreeBSD.ORG References: <46E615C4.1010605@samsco.org> <20070916115427.GA1427@roadrunner.spoerlein.net> <46ED6C50.4040104@samsco.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <46ED6C50.4040104@samsco.org> User-Agent: Mutt/1.5.16 (2007-06-09) Cc: freebsd-scsi@FreeBSD.ORG, njl@FreeBSD.ORG, freebsd-current@FreeBSD.ORG Subject: Re: Retirement of CAM_QUIRK_NOSERIAL X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Sep 2007 20:23:00 -0000 On Sun, 16.09.2007 at 11:48:00 -0600, Scott Long wrote: > Ulrich Spoerlein wrote: > > On Mon, 10.09.2007 at 22:12:52 -0600, Scott Long wrote: > >> All, > >> > >> The attached patch should make CAM behave properly with regard to > >> probing device serial numbers only when the device advertises that > >> it supports it. It will hopefully eliminate the need for the > >> CAM_QUIRK_NOSERIAL quirk (one instance is left because of an unrelated > >> legacy problem that may or may not be possible to fix). This should > >> especially benefit USB-UMASS devices, where the console output should > >> be less noisy. It might even make more devices work out-of-the-box. > > While this patch is working fine with my USB/FW HDD enclosure, it breaks > > my MP3 USB stick > > kernel: umass0: on uhub5 > > kernel: umass0: BBB reset failed, IOERROR > > kernel: umass0: BBB bulk-in clear stall failed, IOERROR > > kernel: umass0: BBB bulk-out clear stall failed, IOERROR > > Is this a regression of something that works without the patch, or is > it something that has never worked? What happens if you use the > NO_INQUIRY_EVPD quirk instead? Ok, I played around a bit and with your patch applied, I have to *remove* the quirk for my Samsung device, then it starts attaching again. That's a good thing, right? :) umass0: on uhub3 da0 at umass-sim0 bus 0 target 0 lun 0 da0: Removable Direct Access SCSI-4 device da0: 40.000MB/s transfers da0: 999MB (511616 2048 byte sectors: 64H 32S/T 249C) There are only two other devices right now, that require a SHUTTLE_INIT quirk, perhaps they are broken by your patch, too. Btw, why are there devices in umass.c with NO_QUIRKS set? Shouldn't those entries be removed? Cheers, Ulrich Spoerlein -- It is better to remain silent and be thought a fool, than to speak, and remove all doubt.