From owner-freebsd-security@FreeBSD.ORG  Wed Apr  7 18:07:35 2010
Return-Path: <owner-freebsd-security@FreeBSD.ORG>
Delivered-To: freebsd-security@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 689AA106566C
	for <freebsd-security@freebsd.org>;
	Wed,  7 Apr 2010 18:07:35 +0000 (UTC)
	(envelope-from delphij@delphij.net)
Received: from tarsier.geekcn.org (tarsier.geekcn.org [IPv6:2001:470:a803::1])
	by mx1.freebsd.org (Postfix) with ESMTP id 124DA8FC08
	for <freebsd-security@freebsd.org>;
	Wed,  7 Apr 2010 18:07:35 +0000 (UTC)
Received: from mail.geekcn.org (tarsier.geekcn.org [211.166.10.233])
	by tarsier.geekcn.org (Postfix) with ESMTP id A9A28A66A11;
	Thu,  8 Apr 2010 02:07:33 +0800 (CST)
X-Virus-Scanned: amavisd-new at geekcn.org
Received: from tarsier.geekcn.org ([211.166.10.233])
	by mail.geekcn.org (mail.geekcn.org [211.166.10.233]) (amavisd-new,
	port 10024)
	with LMTP id 2foQ13mEjMaZ; Thu,  8 Apr 2010 02:07:28 +0800 (CST)
Received: from delta.delphij.net (drawbridge.ixsystems.com [206.40.55.65])
	(using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
	(No client certificate requested)
	by tarsier.geekcn.org (Postfix) with ESMTPSA id 6546CA66A1F;
	Thu,  8 Apr 2010 02:07:27 +0800 (CST)
DomainKey-Signature: a=rsa-sha1; s=default; d=delphij.net; c=nofws; q=dns;
	h=message-id:date:from:reply-to:organization:user-agent:
	mime-version:to:subject:x-enigmail-version:openpgp:content-type:content-transfer-encoding;
	b=OT6CTL1zkmtD255BnPCSYd47eHp4o1W/TwOJP6MChDwPIPaZpH8zBxdSQjlqtpZdb
	PQnlomNum+RpFvK+4GFeQ==
Message-ID: <4BBCC9DB.60403@delphij.net>
Date: Wed, 07 Apr 2010 11:07:23 -0700
From: Xin LI <delphij@delphij.net>
Organization: The Geek China Organization
User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US;
	rv:1.9.1.8) Gecko/20100304 Thunderbird/3.0.3 ThunderBrowse/3.2.8.1
MIME-Version: 1.0
To: freebsd-security@freebsd.org
X-Enigmail-Version: 1.0.1
OpenPGP: id=3FCA37C1;
	url=http://www.delphij.net/delphij.asc
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: priv_check: check against alternative td?
X-BeenThere: freebsd-security@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: d@delphij.net
List-Id: "Security issues \[members-only posting\]"
	<freebsd-security.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-security>, 
	<mailto:freebsd-security-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-security>
List-Post: <mailto:freebsd-security@freebsd.org>
List-Help: <mailto:freebsd-security-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-security>, 
	<mailto:freebsd-security-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Apr 2010 18:07:35 -0000

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

It looks like that we have:

        KASSERT(td == curthread, ("priv_check: td != curthread"));

In priv_check().  I'm wondering why we need this assertion?  i.e.  why
don't we just do priv_check(int priv) and use curthread instead?

Cheers,
- -- 
Xin LI <delphij@delphij.net>	http://www.delphij.net/
FreeBSD - The Power to Serve!	       Live free or die
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (FreeBSD)

iQEcBAEBAgAGBQJLvMnbAAoJEATO+BI/yjfBb6MH/j5yANyXX/zgAHm0fLSh9Sdv
gb78sUDTwLO4H6dI88l0uruVEr5W+yznMplfX5d+yWo9A3QR3DTySEkWj0svOEhO
1LhWc7EPI8W6XbJEZy4vfW1LeK10Z3HLkxEycuv0nUT4g1nUGmRz/SfpRqWP79Na
1IOOUh/MSL+OJdwS7HxiqAXVZrCJmE2GGl200opip1TGd4VRQl0+Aab/9p/NY4TK
J/HGzycWmVzda7RfYmEfKP1iqLYd53IoOMDHmlukcpXR00lXqqwUMzrPm0AOJTGL
tcW7N+AqgmKoP1EL8bjtL/c0DFUijU6qqH1whHEAgMhhi/uLoQsyOMwZsCajWB0=
=uvQn
-----END PGP SIGNATURE-----