From owner-freebsd-chromium@FreeBSD.ORG Sun Apr 3 08:29:10 2011 Return-Path: Delivered-To: chromium@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2B721106564A for ; Sun, 3 Apr 2011 08:29:10 +0000 (UTC) (envelope-from danfe@regency.nsu.ru) Received: from mx.nsu.ru (r2b9.nsu.ru [212.192.164.39]) by mx1.freebsd.org (Postfix) with ESMTP id 9AECD8FC14 for ; Sun, 3 Apr 2011 08:29:09 +0000 (UTC) Received: from regency.nsu.ru ([193.124.210.26]) by mx.nsu.ru with esmtp (Exim 4.69) (envelope-from ) id 1Q5qaR-0003rf-Of for chromium@FreeBSD.org; Sat, 02 Apr 2011 09:29:15 +0700 Received: from regency.nsu.ru (localhost [127.0.0.1]) by regency.nsu.ru (8.14.2/8.14.2) with ESMTP id p322TKup042035 for ; Sat, 2 Apr 2011 09:29:20 +0700 (NOVST) (envelope-from danfe@regency.nsu.ru) Received: (from danfe@localhost) by regency.nsu.ru (8.14.2/8.14.2/Submit) id p322TA02041908 for chromium@FreeBSD.org; Sat, 2 Apr 2011 09:29:10 +0700 (NOVST) (envelope-from danfe) Date: Sat, 2 Apr 2011 09:29:10 +0700 From: Alexey Dokuchaev To: chromium@FreeBSD.org Message-ID: <20110402022910.GA37541@regency.nsu.ru> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="qMm9M+Fa2AknHoGS" Content-Disposition: inline User-Agent: Mutt/1.4.2.1i Cc: Subject: www/chromium/Makefile cleanups X-BeenThere: freebsd-chromium@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD-specific Chromium issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Apr 2011 08:29:10 -0000 --qMm9M+Fa2AknHoGS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi, Please consider attached diff I'd like to commit (or perhaps you want to do it yourself). Proposed commit log: - Consistently use spaces and tabs (get rid of utter mess thereof) - Use PORTNAME in DISTNAME - Wrap some overly long lines - Pad pkg-message with ECHO_CMD's to bring port behavior in line with that of the package ./danfe --qMm9M+Fa2AknHoGS Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="cr.diff" Index: Makefile =================================================================== RCS file: /home/danfe/fbsd/FreeBSD-CVS/ports/www/chromium/Makefile,v retrieving revision 1.17 diff -u -r1.17 Makefile --- Makefile 1 Apr 2011 17:25:31 -0000 1.17 +++ Makefile 2 Apr 2011 02:21:56 -0000 @@ -12,27 +12,27 @@ MASTER_SITES= http://download.goodking.org/downloads/ \ ftp://rene-ladan.nl/pub/distfiles/ \ http://files.etoilebsd.net/goodking/ -DISTNAME= chromium-${DISTVERSIONPREFIX}${DISTVERSION} +DISTNAME= ${PORTNAME}-${DISTVERSIONPREFIX}${DISTVERSION} MAINTAINER= chromium@FreeBSD.org COMMENT= A mostly BSD-licensed web browser based on WebKit and Gtk+ -BUILD_DEPENDS= ${LOCALBASE}/bin/flex:${PORTSDIR}/textproc/flex \ - ${LOCALBASE}/bin/gperf:${PORTSDIR}/devel/gperf \ - bash:${PORTSDIR}/shells/bash \ - pkg-config:${PORTSDIR}/devel/pkg-config \ - yasm:${PORTSDIR}/devel/yasm \ +BUILD_DEPENDS= ${LOCALBASE}/bin/flex:${PORTSDIR}/textproc/flex \ + ${LOCALBASE}/bin/gperf:${PORTSDIR}/devel/gperf \ + bash:${PORTSDIR}/shells/bash \ + pkg-config:${PORTSDIR}/devel/pkg-config \ + yasm:${PORTSDIR}/devel/yasm \ nss>=3.12:${PORTSDIR}/security/nss # minimal version of nss, LIB_DEPENDS does not enforce this -LIB_DEPENDS= execinfo.1:${PORTSDIR}/devel/libexecinfo \ - cairo.2:${PORTSDIR}/graphics/cairo \ - dbus-1.3:${PORTSDIR}/devel/dbus \ - dbus-glib-1.2:${PORTSDIR}/devel/dbus-glib \ - Xss.1:${PORTSDIR}/x11/libXScrnSaver \ - asound.2:${PORTSDIR}/audio/alsa-lib \ - freetype.9:${PORTSDIR}/print/freetype2 \ - nss3.1:${PORTSDIR}/security/nss \ +LIB_DEPENDS= execinfo.1:${PORTSDIR}/devel/libexecinfo \ + cairo.2:${PORTSDIR}/graphics/cairo \ + dbus-1.3:${PORTSDIR}/devel/dbus \ + dbus-glib-1.2:${PORTSDIR}/devel/dbus-glib \ + Xss.1:${PORTSDIR}/x11/libXScrnSaver \ + asound.2:${PORTSDIR}/audio/alsa-lib \ + freetype.9:${PORTSDIR}/print/freetype2 \ + nss3.1:${PORTSDIR}/security/nss \ gnome-keyring.0:${PORTSDIR}/security/libgnome-keyring RUN_DEPENDS= ${LOCALBASE}/lib/alsa-lib/libasound_module_pcm_oss.so:${PORTSDIR}/audio/alsa-plugins \ @@ -68,10 +68,10 @@ #GYP_DEFINES+= use_system_zlib=1 GYP_DEFINES+= python_ver=${PYTHON_VER} -OPTIONS= CODECS "Compile and enable patented codecs like H.264" off \ - GCONF "Use gconf2 for preferences" on \ - SSE2 "Use SSE2, disable this for PIII or older" on \ - VPX "Use system libvpx for VP8 codec" on +OPTIONS= CODECS "Compile and enable patented codecs like H.264" off \ + GCONF "Use GConf2 for preferences" on \ + SSE2 "Use SSE2, disable this for PIII or older" on \ + VPX "Use system libvpx for VP8 codec" on .include @@ -125,9 +125,9 @@ @${ECHO_MSG} post-patch: - @${REINPLACE_CMD} -e "s|/usr/local|${LOCALBASE}|" \ - ${WRKSRC}/base/base.gypi \ - ${WRKSRC}/build/common.gypi \ + @${REINPLACE_CMD} -e "s|/usr/local|${LOCALBASE}|" \ + ${WRKSRC}/base/base.gypi \ + ${WRKSRC}/build/common.gypi \ ${WRKSRC}/third_party/libvpx/libvpx.gyp \ ${WRKSRC}/third_party/WebKit/Source/WebCore/plugins/PluginDatabase.cpp \ ${WRKSRC}/v8/tools/gyp/v8.gyp @@ -139,17 +139,17 @@ ${WRKSRC}/third_party/WebKit/Source/WebCore/bindings/scripts/IDLParser.pm \ ${WRKSRC}/third_party/WebKit/Source/WebCore/dom/make_names.pl @${REINPLACE_CMD} -e "s|'flex'|'${LOCALBASE}/bin/flex'|" \ - ${WRKSRC}/third_party/angle/src/build_angle.gyp \ + ${WRKSRC}/third_party/angle/src/build_angle.gyp \ ${WRKSRC}/third_party/WebKit/Source/WebCore/WebCore.gyp/scripts/action_maketokenizer.py @${REINPLACE_CMD} -e 's|gperf --key-positions|${LOCALBASE}/bin/gperf --key-positions|' \ - ${WRKSRC}/third_party/WebKit/Source/WebCore/css/makeprop.pl \ - ${WRKSRC}/third_party/WebKit/Source/WebCore/css/makevalues.pl \ + ${WRKSRC}/third_party/WebKit/Source/WebCore/css/makeprop.pl \ + ${WRKSRC}/third_party/WebKit/Source/WebCore/css/makevalues.pl \ ${WRKSRC}/third_party/WebKit/Source/WebCore/make-hash-tools.pl - # kludges just to make it progress for now - @${REINPLACE_CMD} -e "s|/usr/lib|${LOCALBASE}/lib|" \ +# kludges just to make it progress for now + @${REINPLACE_CMD} -e "s|/usr/lib|${LOCALBASE}/lib|" \ -e "s|'python_ver%': '2.5'|'python_ver%': '2.6'|" \ - -e "s|.so.1.0|.so.1|" \ - ${WRKSRC}/build/common.gypi + -e "s|.so.1.0|.so.1|" \ + ${WRKSRC}/build/common.gypi @${REINPLACE_CMD} -e "s|'-ldl',|'-lc',|" \ ${WRKSRC}/app/app_base.gypi \ ${WRKSRC}/build/linux/system.gyp \ @@ -158,25 +158,29 @@ do-configure: cd ${WRKSRC} && \ - GYP_DEFINES="${GYP_DEFINES}" ${PYTHON_CMD} ./build/gyp_chromium chrome/chrome.gyp --depth ./ + GYP_DEFINES="${GYP_DEFINES}" ${PYTHON_CMD} \ + ./build/gyp_chromium chrome/chrome.gyp --depth . do-install: - ${MKDIR} ${DATADIR} + @${MKDIR} ${DATADIR} ${INSTALL_MAN} ${WRKSRC}/out/${BUILDTYPE}/chrome.1 ${MANPREFIX}/man/man1 - ${INSTALL_DATA} ${WRKSRC}/out/${BUILDTYPE}/chrome.pak ${DATADIR} - ${INSTALL_DATA} ${WRKSRC}/out/${BUILDTYPE}/product_logo_48.png ${DATADIR} - ${INSTALL_DATA} ${WRKSRC}/out/${BUILDTYPE}/resources.pak ${DATADIR} - ${INSTALL_SCRIPT} ${WRKSRC}/out/${BUILDTYPE}/chrome-wrapper ${DATADIR} - ${INSTALL_SCRIPT} ${WRKSRC}/out/${BUILDTYPE}/xdg-settings ${DATADIR} + ${INSTALL_DATA} ${WRKSRC}/out/${BUILDTYPE}/chrome.pak \ + ${WRKSRC}/out/${BUILDTYPE}/product_logo_48.png \ + ${WRKSRC}/out/${BUILDTYPE}/resources.pak ${DATADIR} + ${INSTALL_SCRIPT} ${WRKSRC}/out/${BUILDTYPE}/chrome-wrapper \ + ${WRKSRC}/out/${BUILDTYPE}/xdg-settings ${DATADIR} .for f in chrome ffmpegsumo_nolink libffmpegsumo.so mksnapshot protoc ${INSTALL_PROGRAM} ${WRKSRC}/out/${BUILDTYPE}/${f} ${DATADIR} .endfor - cd ${WRKSRC}/out/${BUILDTYPE} && ${COPYTREE_SHARE} "locales resources" ${DATADIR} - ${LN} -sf ${DATADIR}/chrome ${PREFIX}/bin/ + cd ${WRKSRC}/out/${BUILDTYPE} && \ + ${COPYTREE_SHARE} "locales resources" ${DATADIR} + ${LN} -sf ${DATADIR}/chrome ${PREFIX}/bin post-install: .if ${OSVERSION} < 900000 + @${ECHO_CMD} @${CAT} ${PKGMESSAGE} + @${ECHO_CMD} .endif .include --qMm9M+Fa2AknHoGS-- From owner-freebsd-chromium@FreeBSD.ORG Mon Apr 4 20:00:43 2011 Return-Path: Delivered-To: chromium@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4759B1065679 for ; Mon, 4 Apr 2011 20:00:43 +0000 (UTC) (envelope-from r.c.ladan@gmail.com) Received: from mail-ey0-f182.google.com (mail-ey0-f182.google.com [209.85.215.182]) by mx1.freebsd.org (Postfix) with ESMTP id C6A4C8FC2B for ; Mon, 4 Apr 2011 20:00:42 +0000 (UTC) Received: by eyg7 with SMTP id 7so1914489eyg.13 for ; Mon, 04 Apr 2011 13:00:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:sender:message-id:date:from:organization :user-agent:mime-version:to:cc:subject:references:in-reply-to :x-enigmail-version:content-type:content-transfer-encoding; bh=rWrYwMPT0szf6x7zgtH82H0C2p5A2JD4SE+ZurxijU8=; b=kt7Hb1n7esSnKvdZuy83t4H7TuLYWB8M2S09UtlBwEFyY25XQzgP5N+OpEpsNvtEzt gizoxr7d+dOwOhjCDJMP8m9fH9uPeuph9YZwy72H0TcnqSw9QJQT/lV3NF5rrIRx0pQn T+FunqQQBhm7HKYDZkdFQWVLKBXAOvn1rHh+8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:organization:user-agent:mime-version:to :cc:subject:references:in-reply-to:x-enigmail-version:content-type :content-transfer-encoding; b=TIq4yBYZpenVmV6ljjq3qBl32yHLf95Aj+TbgFZ2nUjw4WMR+S7+8OP+52+SdOhQr6 M897S4S6xxXmPMvq2FQDddPcgs+9orzE5njsA9y9r1OpC/VvSycBKEWObbv/eVql3wVN 6U1U+AV4kpxdTcQex1cwGLO5YPMq5pXu+sOjg= Received: by 10.213.100.146 with SMTP id y18mr3793615ebn.110.1301947241479; Mon, 04 Apr 2011 13:00:41 -0700 (PDT) Received: from [192.168.1.12] (ip18-43-209-87.adsl2.static.versatel.nl [87.209.43.18]) by mx.google.com with ESMTPS id k51sm335520eei.17.2011.04.04.13.00.38 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 04 Apr 2011 13:00:39 -0700 (PDT) Sender: =?UTF-8?Q?Ren=C3=A9_Ladan?= Message-ID: <4D9A2365.20101@freebsd.org> Date: Mon, 04 Apr 2011 22:00:37 +0200 From: Rene Ladan Organization: The FreeBSD Project User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; nl-NL; rv:1.9.2.15) Gecko/20110305 Thunderbird/3.1.9 MIME-Version: 1.0 To: Alexey Dokuchaev References: <20110402022910.GA37541@regency.nsu.ru> In-Reply-To: <20110402022910.GA37541@regency.nsu.ru> X-Enigmail-Version: 1.1.2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Cc: chromium@FreeBSD.org Subject: Re: www/chromium/Makefile cleanups X-BeenThere: freebsd-chromium@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD-specific Chromium issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Apr 2011 20:00:43 -0000 Op 02-04-2011 04:29, Alexey Dokuchaev schreef: > Hi, > > Please consider attached diff I'd like to commit (or perhaps you want > to do it yourself). Proposed commit log: > > - Consistently use spaces and tabs (get rid of utter mess thereof) > - Use PORTNAME in DISTNAME > - Wrap some overly long lines > - Pad pkg-message with ECHO_CMD's to bring port behavior in line with > that of the package > I committed the patch. Regards, René -- http://www.rene-ladan.nl:8080/ GPG fingerprint = ADBC ECCD EB5F A6B4 549F 600D 8C9E 647A E564 2BFC (subkeys.pgp.net) From owner-freebsd-chromium@FreeBSD.ORG Tue Apr 5 16:03:39 2011 Return-Path: Delivered-To: chromium@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7F950106566C for ; Tue, 5 Apr 2011 16:03:39 +0000 (UTC) (envelope-from danfe@regency.nsu.ru) Received: from mx.nsu.ru (r2b9.nsu.ru [212.192.164.39]) by mx1.freebsd.org (Postfix) with ESMTP id 2D8038FC13 for ; Tue, 5 Apr 2011 16:03:38 +0000 (UTC) Received: from regency.nsu.ru ([193.124.210.26]) by mx.nsu.ru with esmtp (Exim 4.69) (envelope-from ) id 1Q78j5-00061u-Dj; Tue, 05 Apr 2011 23:03:31 +0700 Received: from regency.nsu.ru (localhost [127.0.0.1]) by regency.nsu.ru (8.14.2/8.14.2) with ESMTP id p35G3mVE013021; Tue, 5 Apr 2011 23:03:48 +0700 (NOVST) (envelope-from danfe@regency.nsu.ru) Received: (from danfe@localhost) by regency.nsu.ru (8.14.2/8.14.2/Submit) id p35G3hDn012935; Tue, 5 Apr 2011 23:03:43 +0700 (NOVST) (envelope-from danfe) Date: Tue, 5 Apr 2011 23:03:43 +0700 From: Alexey Dokuchaev To: Rene Ladan Message-ID: <20110405160343.GA11679@regency.nsu.ru> References: <20110402022910.GA37541@regency.nsu.ru> <4D9A2365.20101@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4D9A2365.20101@freebsd.org> User-Agent: Mutt/1.4.2.1i Cc: chromium@freebsd.org Subject: Re: www/chromium/Makefile cleanups X-BeenThere: freebsd-chromium@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD-specific Chromium issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Apr 2011 16:03:39 -0000 On Mon, Apr 04, 2011 at 10:00:37PM +0200, Rene Ladan wrote: > Op 02-04-2011 04:29, Alexey Dokuchaev schreef: > > Hi, > > > > Please consider attached diff I'd like to commit (or perhaps you want > > to do it yourself). Proposed commit log: > > > > - Consistently use spaces and tabs (get rid of utter mess thereof) > > - Use PORTNAME in DISTNAME > > - Wrap some overly long lines > > - Pad pkg-message with ECHO_CMD's to bring port behavior in line with > > that of the package > > > I committed the patch. Thanks! Now maybe I would try Chromium now that port looks visually appealing to my eyes. :-) ./danfe From owner-freebsd-chromium@FreeBSD.ORG Wed Apr 6 14:18:33 2011 Return-Path: Delivered-To: freebsd-chromium@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 67541106564A for ; Wed, 6 Apr 2011 14:18:33 +0000 (UTC) (envelope-from h2+lists2011@fsfe.org) Received: from einhorn.in-berlin.de (einhorn.in-berlin.de [192.109.42.8]) by mx1.freebsd.org (Postfix) with ESMTP id E6BF78FC12 for ; Wed, 6 Apr 2011 14:18:32 +0000 (UTC) X-Envelope-From: h2+lists2011@fsfe.org X-Envelope-To: Received: from localhost (okapi.in-berlin.de [192.109.42.117]) by einhorn.in-berlin.de (8.13.6/8.13.6/Debian-1) with ESMTP id p36EIUFi002269 for ; Wed, 6 Apr 2011 16:18:30 +0200 Received: from brln-4dbab272.pool.mediaWays.net (brln-4dbab272.pool.mediaWays.net [77.186.178.114]) by webmail.in-berlin.de (Horde Framework) with HTTP; Wed, 06 Apr 2011 16:18:30 +0200 Message-ID: <20110406161830.116360nehwuqk4l2@webmail.in-berlin.de> Date: Wed, 06 Apr 2011 16:18:30 +0200 From: "Hannes Hauswedell" To: freebsd-chromium@freebsd.org References: <201104011402.50598.h2+lists2011@fsfe.org> <201104011726.44407.h2+lists2011@fsfe.org> In-Reply-To: <201104011726.44407.h2+lists2011@fsfe.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: 8bit User-Agent: Dynamic Internet Messaging Program (DIMP) H3 (1.0) X-Scanned-By: MIMEDefang_at_IN-Berlin_e.V. on 192.109.42.8 Subject: Re: Current State on 8.2-Release X-BeenThere: freebsd-chromium@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD-specific Chromium issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Apr 2011 14:18:33 -0000 Quoting "Hannes Hauswedell" : > On Friday 01 April 2011 15:05:52 René Ladan wrote: >> 2011/4/1 Hannes Hauswedell : >> > Hi everyone, >> > >> > I just tried building chromium10 on 8.2-Release and it actually >> > succeded, which is a good start :) >> > >> > However, it doesn't start, which is a different issue from the >> > rendering problems, so I thought I'd report it. >> > >> > Here's what it says: >> > >> > hannes@fbsdmain ~> chrome >> > [0330/101349:ERROR:process_util_freebsd.cc(311)] Not implemented >> > reached in void base::EnableTerminationOnOutOfMemory() >> > [71974:66076672:9767029886:FATAL:zygote_host_linux.cc(86)] Check >> > failed: PathService::Get(base::FILE_EXE, &chrome_path). >> > fish: Job 1, 'chrome ' durch Signal SIGABRT (Abbruch) beendet >> > >> > I don't have time for extensive debugging, but will gladly test >> > anything you throw at me ;) >> >> Ah, repost.. > > sorry for that, I got activated for the list after the mail was sent, so > I gave it another shot? > >> Can you try passing the --single-process parameter to chrome? On my >> 8.2-i386 netbook >> this gives a working chrome (with the implied limitations), without >> it I get timeouts but >> no crash. > > Same crash here with the parameter. I have now upgraded the base system to CURRENT (January Image). The issue is exactly the same? Thanks for your help, Regards, Hannes From owner-freebsd-chromium@FreeBSD.ORG Thu Apr 7 10:24:13 2011 Return-Path: Delivered-To: chromium@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DDDF1106564A; Thu, 7 Apr 2011 10:24:12 +0000 (UTC) (envelope-from danfe@regency.nsu.ru) Received: from mx.nsu.ru (r2b9.nsu.ru [212.192.164.39]) by mx1.freebsd.org (Postfix) with ESMTP id 8944B8FC13; Thu, 7 Apr 2011 10:24:12 +0000 (UTC) Received: from regency.nsu.ru ([193.124.210.26]) by mx.nsu.ru with esmtp (Exim 4.69) (envelope-from ) id 1Q7mNg-0003xx-QD; Thu, 07 Apr 2011 17:24:04 +0700 Received: from regency.nsu.ru (localhost [127.0.0.1]) by regency.nsu.ru (8.14.2/8.14.2) with ESMTP id p37AO5At063632; Thu, 7 Apr 2011 17:24:06 +0700 (NOVST) (envelope-from danfe@regency.nsu.ru) Received: (from danfe@localhost) by regency.nsu.ru (8.14.2/8.14.2/Submit) id p37AO0Rb063554; Thu, 7 Apr 2011 17:24:00 +0700 (NOVST) (envelope-from danfe) Date: Thu, 7 Apr 2011 17:24:00 +0700 From: Alexey Dokuchaev To: Rene Ladan Message-ID: <20110407102400.GA60050@regency.nsu.ru> References: <20110402022910.GA37541@regency.nsu.ru> <4D9A2365.20101@freebsd.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="wac7ysb48OaltWcw" Content-Disposition: inline In-Reply-To: <4D9A2365.20101@freebsd.org> User-Agent: Mutt/1.4.2.1i Cc: chromium@freebsd.org Subject: Re: www/chromium/Makefile cleanups X-BeenThere: freebsd-chromium@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD-specific Chromium issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Apr 2011 10:24:13 -0000 --wac7ysb48OaltWcw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Apr 04, 2011 at 10:00:37PM +0200, Rene Ladan wrote: > Op 02-04-2011 04:29, Alexey Dokuchaev schreef: > > Please consider attached diff I'd like to commit (or perhaps you want > > to do it yourself). Proposed commit log: > > > > - Consistently use spaces and tabs (get rid of utter mess thereof) > > - Use PORTNAME in DISTNAME > > - Wrap some overly long lines > > - Pad pkg-message with ECHO_CMD's to bring port behavior in line with > > that of the package > > > I committed the patch. Meanwhile, I have some more: - Convert two explicit dependencies to corresponding USE_GNOME and USE_XORG components - Remove SSE2 option and use proper detection when building instead - Use USE_PYTHON_BUILD as advised by comment - Sort knobs a bit while I'm here ./danfe --wac7ysb48OaltWcw Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="ch.diff" Index: Makefile =================================================================== RCS file: /mnt/fbsd/development/FreeBSD-CVS/ports/www/chromium/Makefile,v retrieving revision 1.18 diff -u -r1.18 Makefile --- Makefile 4 Apr 2011 19:45:48 -0000 1.18 +++ Makefile 7 Apr 2011 05:11:17 -0000 @@ -20,7 +20,6 @@ BUILD_DEPENDS= ${LOCALBASE}/bin/flex:${PORTSDIR}/textproc/flex \ ${LOCALBASE}/bin/gperf:${PORTSDIR}/devel/gperf \ bash:${PORTSDIR}/shells/bash \ - pkg-config:${PORTSDIR}/devel/pkg-config \ yasm:${PORTSDIR}/devel/yasm \ nss>=3.12:${PORTSDIR}/security/nss # minimal version of nss, LIB_DEPENDS does not enforce this @@ -29,7 +28,6 @@ cairo.2:${PORTSDIR}/graphics/cairo \ dbus-1.3:${PORTSDIR}/devel/dbus \ dbus-glib-1.2:${PORTSDIR}/devel/dbus-glib \ - Xss.1:${PORTSDIR}/x11/libXScrnSaver \ asound.2:${PORTSDIR}/audio/alsa-lib \ freetype.9:${PORTSDIR}/print/freetype2 \ nss3.1:${PORTSDIR}/security/nss \ @@ -41,12 +39,12 @@ ONLY_FOR_ARCHS= i386 amd64 USE_XZ= yes USE_BISON= build -USE_PYTHON= 2.6+ # only needed at build time -USE_PERL5_BUILD=yes USE_GMAKE= yes +USE_PERL5_BUILD= yes +USE_PYTHON_BUILD= 2.6+ +USE_XORG= scrnsaverproto x11 xproto xscrnsaver xtst +USE_GNOME= glib20 gtk20 dconf libxslt pkgconfig MAN1= chrome.1 -USE_XORG= scrnsaverproto x11 xproto xtst -USE_GNOME= glib20 gtk20 dconf libxslt LICENSE_COMB= multi LICENSE= BSD LGPL21 MPL @@ -70,7 +68,6 @@ OPTIONS= CODECS "Compile and enable patented codecs like H.264" off \ GCONF "Use GConf2 for preferences" on \ - SSE2 "Use SSE2, disable this for PIII or older" on \ VPX "Use system libvpx for VP8 codec" on .include @@ -95,7 +92,7 @@ GYP_DEFINES+= use_gconf=0 .endif -.if defined(WITHOUT_SSE2) +.if ! ${MACHINE_CPU:Msse2} GYP_DEFINES+= disable_sse2=1 .endif --wac7ysb48OaltWcw--