From owner-freebsd-rc@FreeBSD.ORG Sun Mar 20 04:11:03 2011 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 97AD4106566B; Sun, 20 Mar 2011 04:11:03 +0000 (UTC) (envelope-from jhellenthal@gmail.com) Received: from mail-iy0-f182.google.com (mail-iy0-f182.google.com [209.85.210.182]) by mx1.freebsd.org (Postfix) with ESMTP id 45D498FC08; Sun, 20 Mar 2011 04:11:02 +0000 (UTC) Received: by iyj12 with SMTP id 12so6357254iyj.13 for ; Sat, 19 Mar 2011 21:11:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:sender:date:from:to:cc:subject:in-reply-to :message-id:references:user-agent:x-openpgp-key-id :x-openpgp-key-fingerprint:mime-version:content-type; bh=+DY9BpaMhrieRCcwg3wcFLrTDEYsf5E7/zBmVNoE330=; b=Rg7g8c40BK9I8gvjgSwTTSHiZQPI1+gyCAMdA3uqvrxk4iniy+5lnSHaPzHVZfl5kg TJp1rKmMvfHrfaBq+vGfWCnbzx3jNZWWwqKSz4ZqltUoLAnjJYZtqTE1a7uM5SOFk0st C6Vo2YMt3nEnxpQiMd85N3yshWpulMw1Z3M5w= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:x-openpgp-key-id:x-openpgp-key-fingerprint:mime-version :content-type; b=KApOZvdmxCEKeCIUfhie7cUBxSn4h2eYEd9bT6yMSzTSQMKQprfZjD8LZ9jiX7CWXo JknSjq7ndlZICpc3OoT1ZlnBrJRea8rWa+4ZQ39nWkBiAUo6u0jc16Kxzyoo9hjxf+76 yXJWz7JcTr8S1EpDAYvHdwVwox4tkUKGQ8mU4= Received: by 10.231.143.129 with SMTP id v1mr2729320ibu.78.1300592800644; Sat, 19 Mar 2011 20:46:40 -0700 (PDT) Received: from disbatch.dataix.local (adsl-99-181-154-144.dsl.klmzmi.sbcglobal.net [99.181.154.144]) by mx.google.com with ESMTPS id 14sm2681240ibo.63.2011.03.19.20.46.38 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 19 Mar 2011 20:46:39 -0700 (PDT) Sender: "J. Hellenthal" Date: Sat, 19 Mar 2011 23:46:23 -0400 From: "J. Hellenthal" To: Wesley Shields In-Reply-To: <20110319013155.GB39929@atarininja.org> Message-ID: References: <20110319012959.GA39929@atarininja.org> <20110319013155.GB39929@atarininja.org> User-Agent: Alpine 2.00 (BSF 1167 2008-08-23) X-OpenPGP-Key-Id: 0x89D8547E X-OpenPGP-Key-Fingerprint: 85EF E26B 07BB 3777 76BE B12A 9057 8789 89D8 547E MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="80310268-1944442781-1300592799=:3999" Cc: freebsd-rc@freebsd.org Subject: Re: status cleanup X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Mar 2011 04:11:03 -0000 This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --80310268-1944442781-1300592799=:3999 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Fri, 18 Mar 2011 21:31, wxs@ wrote: > On Fri, Mar 18, 2011 at 09:29:59PM -0400, Wesley Shields wrote: >> A co-worker noticed that the pf rc script has 'status' listed twice when >> run without any arguments. The attached patch fixes that and two other >> cases where this also happens. I've only tested the pf changes. I'd >> appreciate a review of this and maybe a commit? I can file a PR if it >> would make people feel better. >> >> I'm not subscribed to this list so I would appreciate being CC'ed on any >> replies. >> > > This time with the patch attached, or you can get it at: > > http://people.freebsd.org/~wxs/rc-status-cleanup.diff > While on this subject since it has to do with status messages I might as well take a moment and share the following patch [1] that changes the stupid "Enabling pfpf enabled" & "Disabling pfpf disabled" messages. 1. http://patches.jhell.googlecode.com/hg/pf-rc-startstop.patch - -- Regards, J. Hellenthal (0x89D8547E) JJH48-ARIN -----BEGIN PGP SIGNATURE----- Comment: THIS SOFTWARE AND/OR CONTENTS IS PROVIDED BY THE AUTHOR ``AS IS'' AND Comment: ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE Comment: IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR Comment: PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY Comment: DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL Comment: DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS Comment: OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) Comment: HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, Comment: STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING Comment: IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE Comment: POSSIBILITY OF SUCH DAMAGE. iQEcBAEBAgAGBQJNhXiYAAoJEJBXh4mJ2FR+CKAH/296rcCVoYDH3pUqwentnUHR 2T4ocIbJ+76/z/HgCl257sV3iWGhrQxPy/LbcEGPZ1JrxyhTtyfAPMO4uG8I95sO R3mlA6fBtt5PVOexPuPRIIjmjK4zUBQimRreUCRDng+AyKxoi+/pIwAiaSBnUitD PdCeHHNvotB4zffjc9Kq1KJol9hyhwpzMnHBPywQ8NKgt1mETNYUrdUbLBBjCdgP KkDIlMy2/pzi6garrPdW02G8fV4co9jLha0zWZmVo2oOy7/iUrdnbT8URY5l7EfU /fkQFPmTwTq9OGi5WBuvX581S0F2n6xlVjoP3hcEGeSSPNw1t+qMebLeUvveJXk= =MiOn -----END PGP SIGNATURE----- --80310268-1944442781-1300592799=:3999 Content-Type: TEXT/PLAIN; charset=US-ASCII; name=pf-rc-startstop.patch Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Start Stop Status relief. Content-Disposition: attachment; filename=pf-rc-startstop.patch IyBIRyBjaGFuZ2VzZXQgcGF0Y2gNCiMgUGFyZW50IDc1MjgzNzZiYmM3YmRl YWU2NDJlMzFjYmEyYmRiM2U1MjkzMGM2NGINCkZpeHVwIHBmIHN0YXJ0L3N0 b3AgbWVzc2FnZXMgb24gdGhlIGNvbnNvbGUsIEVuYWJsaW5nIHBmcGYgZW5h YmxlZA0KDQpkaWZmIC1yIDc1MjgzNzZiYmM3YiBldGMvcmMuZC9wZg0KLS0t IGEvZXRjL3JjLmQvcGYNCisrKyBiL2V0Yy9yYy5kL3BmDQpAQCAtMjUsNyAr MjUsNyBAQA0KIA0KIHBmX3N0YXJ0KCkNCiB7DQotCWNoZWNrX3N0YXJ0bXNn cyAmJiBlY2hvIC1uICdFbmFibGluZyBwZicNCisJY2hlY2tfc3RhcnRtc2dz ICYmIGVjaG8gLW4gJ0VuYWJsaW5nIHBmOiAnDQogCSRwZl9wcm9ncmFtIC1G IGFsbCA+IC9kZXYvbnVsbCAyPiYxDQogCSRwZl9wcm9ncmFtIC1mICIkcGZf cnVsZXMiICRwZl9mbGFncw0KIAlpZiAhICRwZl9wcm9ncmFtIC1zIGluZm8g fCBncmVwIC1xICJFbmFibGVkIiA7IHRoZW4NCkBAIC0zNyw3ICszNyw3IEBA DQogcGZfc3RvcCgpDQogew0KIAlpZiAkcGZfcHJvZ3JhbSAtcyBpbmZvIHwg Z3JlcCAtcSAiRW5hYmxlZCIgOyB0aGVuDQotCQllY2hvIC1uICdEaXNhYmxp bmcgcGYnDQorCQllY2hvIC1uICdEaXNhYmxpbmcgcGY6ICcNCiAJCSRwZl9w cm9ncmFtIC1kDQogCQllY2hvICcuJw0KIAlmaQ0K --80310268-1944442781-1300592799=:3999-- From owner-freebsd-rc@FreeBSD.ORG Mon Mar 21 11:07:05 2011 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8330A106566C for ; Mon, 21 Mar 2011 11:07:05 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 72E678FC1F for ; Mon, 21 Mar 2011 11:07:05 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p2LB75aD086097 for ; Mon, 21 Mar 2011 11:07:05 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p2LB74gu086094 for freebsd-rc@FreeBSD.org; Mon, 21 Mar 2011 11:07:04 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 21 Mar 2011 11:07:04 GMT Message-Id: <201103211107.p2LB74gu086094@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: gnats set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-rc@FreeBSD.org Cc: Subject: Current problem reports assigned to freebsd-rc@FreeBSD.org X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Mar 2011 11:07:05 -0000 Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). The following is a listing of current problems submitted by FreeBSD users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Tracker Resp. Description -------------------------------------------------------------------------------- o conf/154554 rc [rc.d] [patch] statd and lockd fail to start o conf/153666 rc [rc.d][patch] mount filesystems from fstab over zfs da o conf/153200 rc post-boot /etc/rc.d/network_ipv6 start can miss neighb o conf/153123 rc [rc] [patch] add gsched rc file to automatically inser o conf/152784 rc services provide himself instead providing class of se o conf/151063 rc [rc.subr] Verify network link and packet flow before s o conf/150752 rc [rc.subr] [patch] be not needed to eval $_pidcmd on re o conf/150474 rc [patch] rc.d/accounting: Add ability to set location o o conf/149867 rc [PATCH] rc.d script to manage multiple FIBS (kern opti o conf/149831 rc [PATCH] add support to /etc/rc.d/jail for delegating Z o conf/148656 rc rc.firewall(8): {oip} and {iip} variables in rc.firewa o conf/147685 rc [rc.d] [patch] new feature for /etc/rc.d/fsck o conf/147444 rc [rc.d] [patch] /etc/rc.d/zfs stop not called on reboot o conf/146053 rc [patch] [request] shutdown of jails breaks inter-jail o conf/145445 rc [rc.d] error in /etc/rc.d/jail (bad logic) o conf/145440 rc [rc.d] [patch] add multiple fib support (setfib) in /e o conf/145399 rc [patch] rc.d scripts are unable to start/stop programs o conf/145344 rc [patch] Fix kitchen sink approach for rc.d scripts ins o conf/145009 rc [patch] rc.subr(8): rc.conf should allow mac label con o conf/144213 rc [rc.d] [patch] Disappearing zvols on reboot o conf/143637 rc [patch] ntpdate(8) support for ntp-servers supplied by o conf/143085 rc [patch] ftp-proxy(8) rc(8) with multiple instances o conf/143084 rc [jail] [patch]: fix rc.d/jail creating stray softlinks o conf/142973 rc [jail] [patch] Strange counter init value in jail rc o conf/142434 rc [patch] Add cpuset(1) support to rc.subr(8) o conf/142304 rc rc.conf(5): mdconfig and mdconfig2 rc.d scripts lack e o conf/141909 rc rc.subr(8): [patch] add rc.conf.d support to /usr/loca o conf/141907 rc [rc.d] Bug if mtu (maybe others?) is set as first argu o conf/141678 rc [patch] A minor enhancement to how /etc/rc.d/jail dete o conf/141275 rc [request] dhclient(8) rc script should print something o conf/140440 rc [patch] allow local command files in rc.{suspend,resum o conf/140261 rc [patch] Improve flexibility of mdconfig2 startup scrip o conf/138208 rc [rc.d] [patch] Making rc.firewall (workstation) IPv6 a o conf/137629 rc [rc.d] background_dhclient rc.conf option causing doub o conf/137470 rc [PATCH] /etc/rc.d/mdconfig2 : prioritize cli parameter o conf/137271 rc [rc.d] Cannot update /etc/host.conf when root filesyst o conf/136875 rc [request] _flags appending o conf/136624 rc [rc.d] sysctl variables for ipnat are not applied on b o conf/135338 rc [rc.d] pf startup order seems broken [regression] o conf/134918 rc [patch] rc.subr fails to detect perl daemons o conf/134660 rc [patch] rc-script for initializing ng_netflow+ng_ipfw o conf/134333 rc PPP configuration problem in the rc.d scripts in combi o conf/134006 rc [patch] Unload console screensaver kernel modules if s o conf/133987 rc [rc.d] defaultroute broken with DHCP in some cases o conf/133890 rc [patch] sshd(8): add multiple profiles to the rc.d scr o conf/132483 rc rc.subr(8) [patch] setfib(1) support for rc.subr o conf/132476 rc [rc.d] [patch] add support setfib(1) in rc.d/routing o conf/128299 rc [patch] /etc/rc.d/geli does not mount partitions using o bin/126562 rc rcorder(8) fails to run unrelated startup scripts when o conf/126392 rc [patch] rc.conf ifconfig_xx keywords cannot be escaped p bin/126324 rc [patch] rc.d/tmp: Prevent mounting /tmp in second tim o conf/124747 rc [patch] savecore can't create dump from encrypted swap o conf/124248 rc [jail] [patch] add support for nice value for rc.d/jai o conf/123734 rc [patch] Chipset VIA CX700 requires extra initializatio o conf/123222 rc [patch] Add rtprio(1)/idprio(1) support to rc.subr(8). o conf/122968 rc [rc.d] /etc/rc.d/addswap: md swapfile multiplication a o conf/122477 rc [patch] /etc/rc.d/mdconfig and mdconfig2 are ignoring o conf/122170 rc [patch] [request] New feature: notify admin via page o o kern/121566 rc [nfs] [request] [patch] ethernet iface should be broug o conf/120431 rc [patch] devfs.rules are not initialized under certain o conf/120406 rc [devd] [patch] Handle newly attached pcm devices (eg. o conf/119874 rc [patch] "/etc/rc.d/pf reload" fails if there are macro o conf/119076 rc [patch] [rc.d] /etc/rc.d/netif tries to remove alias a o bin/118325 rc [patch] [request] new periodic script to test statuses o conf/118255 rc savecore never finding kernel core dumps (rcorder prob o conf/117935 rc [patch] ppp fails to start at boot because of missing o conf/113915 rc [patch] ndis wireless driver fails to associate when i o conf/109980 rc /etc/rc.d/netif restart doesn't destroy cloned_interfa o conf/109562 rc [rc.d] [patch] [request] Make rc.d/devfs usable from c o conf/108589 rc rtsol(8) fails due to default ipfw rules o conf/106009 rc [ppp] [patch] [request] Fix pppoed startup script to p o conf/105689 rc [ppp] [request] syslogd starts too late at boot o conf/105568 rc [patch] [request] Add more flexibility to rc.conf, to o conf/105145 rc [ppp] [patch] [request] add redial function to rc.d/pp o conf/104549 rc [patch] rc.d/nfsd needs special _find_processes functi o conf/102700 rc [geli] [patch] Add encrypted /tmp support to GELI/GBDE o conf/99721 rc [patch] /etc/rc.initdiskless problem copy dotfile in s o conf/99444 rc [patch] Enhancement: rc.subr could easily support star o conf/96343 rc [patch] rc.d order change to start inet6 before pf o conf/93815 rc [patch] Adds in the ability to save ipfw rules to rc.d o conf/92523 rc [patch] allow rc scripts to kill process after a timeo o conf/89870 rc [patch] [request] make netif verbose rc.conf toggle o conf/89061 rc [patch] IPv6 6to4 auto-configuration enhancement o conf/88913 rc [patch] wrapper support for rc.subr o conf/85819 rc [patch] script allowing multiuser mode in spite of fsc o kern/81006 rc ipnat not working with tunnel interfaces on startup o conf/77663 rc Suggestion: add /etc/rc.d/addnetswap after addcritremo o conf/73677 rc [patch] add support for powernow states to power_profi o conf/58939 rc [patch] dumb little hack for /etc/rc.firewall{,6} o conf/56934 rc [patch] rc.firewall rules for natd expect an interface o conf/45226 rc [patch] Fix for rc.network, ppp-user annoyance o conf/44170 rc [patch] Add ability to run multiple pppoed(8) on start 92 problems total.