From owner-freebsd-toolchain@FreeBSD.ORG Mon Mar 25 11:06:52 2013 Return-Path: Delivered-To: freebsd-toolchain@FreeBSD.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 3076CE8 for ; Mon, 25 Mar 2013 11:06:52 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 0A5A9D9 for ; Mon, 25 Mar 2013 11:06:52 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.6/8.14.6) with ESMTP id r2PB6pWf007328 for ; Mon, 25 Mar 2013 11:06:51 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.6/8.14.6/Submit) id r2PB6pPc007325 for freebsd-toolchain@FreeBSD.org; Mon, 25 Mar 2013 11:06:51 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 25 Mar 2013 11:06:51 GMT Message-Id: <201303251106.r2PB6pPc007325@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: gnats set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-toolchain@FreeBSD.org Subject: Current problem reports assigned to freebsd-toolchain@FreeBSD.org X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Mar 2013 11:06:52 -0000 Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). The following is a listing of current problems submitted by FreeBSD users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Tracker Resp. Description -------------------------------------------------------------------------------- o bin/175930 toolchain [headers] clang does not define __STDC_ISO_10646__, de 1 problem total. From owner-freebsd-toolchain@FreeBSD.ORG Sat Mar 30 08:10:52 2013 Return-Path: Delivered-To: toolchain@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 996B5DDC; Sat, 30 Mar 2013 08:10:52 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id B29F66E6; Sat, 30 Mar 2013 08:10:51 +0000 (UTC) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id KAA29589; Sat, 30 Mar 2013 10:10:43 +0200 (EET) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1ULqs7-000OOh-HX; Sat, 30 Mar 2013 10:10:43 +0200 Message-ID: <51569DFF.5080708@FreeBSD.org> Date: Sat, 30 Mar 2013 10:10:39 +0200 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/20130321 Thunderbird/17.0.4 MIME-Version: 1.0 To: freebsd-hackers@FreeBSD.org, toolchain@FreeBSD.org Subject: clang: -mno-omit-leaf-frame-pointer X-Enigmail-Version: 1.5.1 Content-Type: text/plain; charset=X-VIET-VPS Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 Mar 2013 08:10:52 -0000 It seems that, unlike gcc, for clang -fno-omit-frame-pointer does not imply -mno-omit-leaf-frame-pointer. This is probably a bug. Meanwhile I would like to propose the following amd64-specific patch. Perhaps the same type of change would be useful for powerpc as well. I would like this change primarily for DTrace (fbt), but other debugging/profiling code may benefit from it as well. I chose to make -mno-omit-leaf-frame-pointer not conditional on clang, because with gcc it is just a nop (i.e. it doesn't hurt anything). --- a/sys/conf/Makefile.amd64 +++ b/sys/conf/Makefile.amd64 @@ -32,7 +32,7 @@ S= ../../.. .include "$S/conf/kern.pre.mk" .if !empty(DDB_ENABLED) || !empty(DTR_ENABLED) || !empty(HWPMC_ENABLED) -CFLAGS+= -fno-omit-frame-pointer +CFLAGS+= -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer .endif MKMODULESENV+= MACHINE=amd64 diff --git a/sys/conf/kmod.mk b/sys/conf/kmod.mk index f0d3d4d..7eaba85 100644 --- a/sys/conf/kmod.mk +++ b/sys/conf/kmod.mk @@ -122,7 +122,7 @@ LDFLAGS+= -d -warn-common CFLAGS+= ${DEBUG_FLAGS} .if ${MACHINE_CPUARCH} == amd64 -CFLAGS+= -fno-omit-frame-pointer +CFLAGS+= -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer .endif .if ${MACHINE_CPUARCH} == powerpc -- Andriy Gapon From owner-freebsd-toolchain@FreeBSD.ORG Sat Mar 30 19:43:06 2013 Return-Path: Delivered-To: toolchain@FreeBSD.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 9A08428B; Sat, 30 Mar 2013 19:43:06 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) by mx1.freebsd.org (Postfix) with ESMTP id 5651A8A9; Sat, 30 Mar 2013 19:43:06 +0000 (UTC) Received: from [IPv6:2001:7b8:3a7::e015:1126:f5aa:89a8] (unknown [IPv6:2001:7b8:3a7:0:e015:1126:f5aa:89a8]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 4E9165C44; Sat, 30 Mar 2013 20:42:59 +0100 (CET) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 6.3 \(1503\)) Subject: Re: clang: -mno-omit-leaf-frame-pointer From: Dimitry Andric In-Reply-To: <51569DFF.5080708@FreeBSD.org> Date: Sat, 30 Mar 2013 20:42:52 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <0F14AC3C-6C38-4041-8775-F5E65C20EEB0@FreeBSD.org> References: <51569DFF.5080708@FreeBSD.org> To: Andriy Gapon X-Mailer: Apple Mail (2.1503) Cc: freebsd-hackers@FreeBSD.org, toolchain@FreeBSD.org X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 Mar 2013 19:43:06 -0000 On Mar 30, 2013, at 09:10, Andriy Gapon wrote: > It seems that, unlike gcc, for clang -fno-omit-frame-pointer does not = imply > -mno-omit-leaf-frame-pointer. This is probably a bug. Yes, this is indeed the case. There is even a rather old unresolved PR for it in LLVM's Bugzilla: http://llvm.org/bugs/show_bug.cgi?id=3D9825 > Meanwhile I would like to propose the following amd64-specific patch. = Perhaps > the same type of change would be useful for powerpc as well. Most likely yes. > I would like this change primarily for DTrace (fbt), but other > debugging/profiling code may benefit from it as well. >=20 > I chose to make -mno-omit-leaf-frame-pointer not conditional on clang, = because > with gcc it is just a nop (i.e. it doesn't hurt anything). The patch looks good to me, please commit.