From owner-freebsd-xen@freebsd.org Tue Mar 29 13:07:15 2016 Return-Path: Delivered-To: freebsd-xen@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DE87CAE0D67 for ; Tue, 29 Mar 2016 13:07:15 +0000 (UTC) (envelope-from gustau.perez@gmail.com) Received: from mail-wm0-x233.google.com (mail-wm0-x233.google.com [IPv6:2a00:1450:400c:c09::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6F9D5172F for ; Tue, 29 Mar 2016 13:07:15 +0000 (UTC) (envelope-from gustau.perez@gmail.com) Received: by mail-wm0-x233.google.com with SMTP id r72so56167643wmg.0 for ; Tue, 29 Mar 2016 06:07:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=y7KiErH+WgkOhipcz6aMhxM0hgaJrSdy5T729eD2sqY=; b=vqAbUesJg/6GRHuGH8qbbizGWWrAoCaHazXaNnJKUgNQ07RvNTCq5RbTJoDMCJ16tE hYdiHQPibvk44u9I8F99UZ259tYDvzsb/6xxNsvbHZbqMeaou/lqRC9UKAkJgrHOFveY 8nyoBNkBmRhjDuLMr/065Qtcy5vcnEK0qfRK0XLptwLJcghIW5VSi8zowlWVJTyZdY1F YGi295h4yURiwagg5sRnMJDaP9nroi94iKJw2eGhXRLj28+SnFKga1nzVrvsEnLwtNPR JdTTNjpjqI8R2yBzS8w5sI5rfmEGiLhxZcosiPzmxSvSVY4u0mhaJ0MdRFSwrS0qekLM oqJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=y7KiErH+WgkOhipcz6aMhxM0hgaJrSdy5T729eD2sqY=; b=iVKxJ2IO6MYbiWXu26362xHXJeao0pfpi7Mb5wKNFCjED1+A1/DO766U05hqGoGoU4 pQWiTQjg1kgtH+QP+CN5VrY1NREZhOj68NolO+LItWovWRhIrP5cIGUzqRP1jh1k7Tyy WJ2YVHVQTSn1lwKASFtsGNX2/7kVhL4N+kSwvKCjTnTKO1B8bZGWUrNdPavIRd0su43q IFnvWIvcS9UNLu0LK5Q4MtOWMc9j3qUEdPC8g9kFz5vjETtJVKoYl/tGSZWOLeLYLY5h loIUUCMQUEE+w9DLU8GL2c9lCS48MRyK34IhOYuO7IBxbs7ikSCRV8KCljm2SHfPfxq/ cZlQ== X-Gm-Message-State: AD7BkJIuQ3lBBR+vLjNAfonMZ78l9vamz80/F8lEmsnkyK2tPqSyrdDUgDme6Ft5nC+2FQ== X-Received: by 10.28.107.9 with SMTP id g9mr17010968wmc.34.1459256833867; Tue, 29 Mar 2016 06:07:13 -0700 (PDT) Received: from [10.0.2.151] ([147.83.40.10]) by smtp.googlemail.com with ESMTPSA id v2sm14679541wmd.24.2016.03.29.06.07.13 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 29 Mar 2016 06:07:13 -0700 (PDT) Subject: Re: Porting the block-iscsi hotplug script To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <553DEB97.5000300@entel.upc.edu> <56CAC8CB.8030107@gmail.com> <56CADEDA.4050007@citrix.com> <56CB0057.1060509@gmail.com> <56CB041E.1020009@citrix.com> <56CB2D90.5080809@gmail.com> <56CB34BA.6060809@citrix.com> <56CC24BD.6050609@gmail.com> <56CC32E5.5010101@citrix.com> <56CC7637.3080408@gmail.com> <56CF5668.6090605@citrix.com> <56D0091F.80408@gmail.com> <56D02863.7040100@citrix.com> <56D03D95.9090509@gmail.com> <56D04E5F.8070901@citrix.com> <56D42A28.8050701@gmail.com> <56D434FC.8030905@citrix.com> <56D57110.2060406@gmail.com> <56D587D8.6030702@citrix.com> <56D590EA.609@gmail.com> <56D591BA.4020303@gmail.com> <56D5929F.7040001@citrix.com> <56D5C722.3080205@gmail.com> <56D6B68D.8080809@citrix.com> <56D7FEFE.9050000@gmail.com> <56D97762.7000908@gmail.com> <56E84043.4060602@gmail.com> <56EAA788.3020404@gmail.com> Cc: FreeBSD XEN From: =?UTF-8?Q?Gustau_P=c3=a9rez?= Message-ID: <56FA7E00.6030309@gmail.com> Date: Tue, 29 Mar 2016 15:07:12 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:38.0) Gecko/20100101 Thunderbird/38.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-xen@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Discussion of the freebsd port to xen - implementation and usage List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Mar 2016 13:07:16 -0000 > Hello, > > I've been on vacations last week and I'm trying to catch up with my email > backlog, sorry for the delay in the reply. > > OTOH, George Dunlap from Citrix has posted the series that should enable > hotplug scripts to work with HVM domains. I need to rebase my FreeBSD > hotplug script support on top of it, so you can try it. George's series > can be found at: > > http://lists.xenproject.org/archives/html/xen-devel/2016-03/msg02739.html > > I will try to rebase my work on top of this and provide you with a git > branch so you can easily test it. > > Regarding your questions about the locking mechanism, I'm not that > familiar with it, but I'm not sure why a lock array is need. AFAICT only > one lock should be needed, that prevents multiple hotplug scripts from > travessing the xenstore disk information at the same time. Please bring > this question to xen-devel. > >> [1] http://pastebin.com/FhaQeuG1 >> [2] http://pastebin.com/ZHWKRg5f > LGTM :). You will have to formally submit this as patches when the hotplug > work is committed to upstream Xen. > Hi Roger, I've been checking the changes to eventually send them upstream and there are a bits that I thinkg you would also need to commit upstream before I can send mine. Those changes are in the sysutils/xen-tools port (I see those signed patches in the files/ directory but I can't find them in xenbits repo). I did the signed patch containing my changes [1], if you want to check it. I could add your changes, but I fear I may miss something along the way. Best, Gustau [1] http://dpaste.com/2FGK8XN