From owner-freebsd-java  Sun Mar 10  2:27:11 2002
Delivered-To: freebsd-java@freebsd.org
Received: from azrael.xs4all.nl (azrael.xs4all.nl [213.84.50.139])
	by hub.freebsd.org (Postfix) with ESMTP
	id 895AC37B400; Sun, 10 Mar 2002 02:27:06 -0800 (PST)
Received: (from remco@localhost)
	by azrael.xs4all.nl (8.11.6/8.11.6) id g2AAR2899339;
	Sun, 10 Mar 2002 11:27:02 +0100 (CET)
	(envelope-from remco)
Date: Sun, 10 Mar 2002 11:27:02 +0100
From: "Remco van 't Veer" <rwvtveer@xs4all.nl>
To: Greg Lewis <glewis@eyesbeyond.com>
Cc: znerd@FreeBSD.ORG, freebsd-java@FreeBSD.ORG
Subject: Re: ports/35658: java/jdk13 creates too small src.jar
Message-ID: <20020310102702.GC374@azrael.xs4all.nl>
References: <20020310052111.A14684@misty.eyesbeyond.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20020310052111.A14684@misty.eyesbeyond.com>
User-Agent: Mutt/1.3.27i
X-Spook: Toffler JAVA ammunition sweep stakeout ANZUS NMIC number key SABC
Sender: owner-freebsd-java@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-java.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-java>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-java>
X-Loop: FreeBSD.org

Using cpio might be a better option for copying a lot of files
and should be a lot faster.  Here is an example:

  $(FIND) $(SOURCES) -name CVS -prune -o -name SCCS -prune -o -name '*.java' -print \
  | $(CPIO) -p $(JDK_IMAGE_DIR)/src

I am not sure if CPIO is defined though.  Otherwise just using CP
instead of TAR might speed up things.

HTH,
Remco


On Sun, Mar 10, 2002 at 05:21, Greg Lewis wrote:

> Attached patch works for me.  Put it in
> 
> /ports/java/jdk13/files/patch-common::Release.gmk
> 
> and you should be right.
> 
> Obviously this is less efficient, but compared to the entire build process
> the impact is very minimal.
> 
> -- 
> Greg Lewis                            Email : glewis@eyesbeyond.com
> Eyes Beyond                           Web   : http://www.eyesbeyond.com
> Information Technology
> 

> Index: Release.gmk
> ===================================================================
> RCS file: /data/java/JDK2/javasrc_1_3_scsl/j2sdk1.3.1/make/common/Release.gmk,v
> retrieving revision 1.7
> diff -u -r1.7 common/Release.gmk
> --- common/Release.gmk	21 Jan 2002 22:40:08 -0000	1.7
> +++ common/Release.gmk	9 Mar 2002 18:01:51 -0000
> @@ -521,10 +521,18 @@
>  	@# src.jar
>  	@#
>  	$(MKDIR) -p $(JDK_IMAGE_DIR)/src
> +ifeq ($(PLATFORM), bsd) 
> +	# Avoid the "argument list too long" problem.
> +	($(CD) $(SHARE_SRC)/classes; \
> +	    for list in `$(FIND) $(SOURCES) -name CVS -prune -o -name SCCS -prune -o  -name '*.java' -print`; do \
> +	        $(TAR) cf - $$list | ($(CD) $(JDK_IMAGE_DIR)/src; $(TAR) xvf -); \
> +	    done)
> +else
>  	($(CD) $(SHARE_SRC)/classes; $(TAR) cf - \
>  	    `$(FIND) $(SOURCES) -name CVS -prune -o -name SCCS -prune -o \
>  	    -name '*.java' -print`)| \
>  	    ($(CD) $(JDK_IMAGE_DIR)/src; $(TAR) xvf -)
> +endif
>  	@# We do not want to ship this, it isn't part of the build yet.
>  	$(RM) -r $(JDK_IMAGE_DIR)/src/javax/swing/pending
>  	$(MKDIR) -p $(JDK_IMAGE_DIR)/src/launcher


-- 
It's our goal to continue to conveniently facilitate our relationship
corridors and swiftly innovate skill sets to market a weak product
that creates us a lot of simoleons.

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-java" in the body of the message