From owner-cvs-src@FreeBSD.ORG  Sun Jun  8 00:13:54 2003
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 931)
	id 11EFC37B401; Sun,  8 Jun 2003 00:13:54 -0700 (PDT)
Date: Sun, 8 Jun 2003 02:13:54 -0500
From: Juli Mallett <jmallett@FreeBSD.org>
To: Greg Lehey <grog@FreeBSD.org>
Message-ID: <20030608021354.A40746@FreeBSD.org>
References: <200306080618.h586ID4a026484@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5.1i
In-Reply-To: <200306080618.h586ID4a026484@repoman.freebsd.org>;
	from grog@FreeBSD.org on Sat, Jun 07, 2003 at 11:18:13PM -0700
X-Title: Code Maven
X-Towel: Yes
X-Negacore: Yes
X-Authentication-Warning: localhost: juli pwned teh intarweb
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/usr.sbin/asf Makefile asf.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 08 Jun 2003 07:13:54 -0000

* Greg Lehey <grog@FreeBSD.org> [ Date: 2003-06-08 ]
	[ w.r.t. cvs commit: src/usr.sbin/asf Makefile asf.c ]
> grog        2003/06/07 23:18:13 PDT
> 
>   FreeBSD src repository
> 
>   Added files:
>     usr.sbin/asf         Makefile asf.c 
>   Log:
>   Introducing asf, a helper program for kernel debugging.

This looks pretty messy and doesn't even have a license on it.
Will it be tied to the build?  Any reason it doesn't use the
getopt(3) function, or in any way look like the normal BSD
style for utilities?  Please use a paths.h instead of the
evilly hardcoded program paths.

If this won't be tied up to the build it should probably be
in src/tools, and I'd argue it should be there anyway.

Thanx,
juli.
-- 
juli mallett. email: jmallett@freebsd.org; efnet: juli;