From owner-freebsd-ports@FreeBSD.ORG Sun Aug 10 00:01:30 2003 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D72D637B401; Sun, 10 Aug 2003 00:01:30 -0700 (PDT) Received: from smtp-send.myrealbox.com (smtp-send.myrealbox.com [192.108.102.143]) by mx1.FreeBSD.org (Postfix) with ESMTP id 557A043FA3; Sun, 10 Aug 2003 00:01:30 -0700 (PDT) (envelope-from qhwt@myrealbox.com) Received: from me qhwt@smtp-send.myrealbox.com [220.13.16.139] $ on Novell NetWare; Sun, 10 Aug 2003 01:01:33 -0600 Date: Sun, 10 Aug 2003 16:01:29 +0900 From: qhwt@myrealbox.com To: questions@FreeBSD.org Message-ID: <20030810070129.GA1045@myrealbox.com> References: <20030804023319.GA969@myrealbox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030804023319.GA969@myrealbox.com> User-Agent: Mutt/1.5.4i cc: ports@FreeBSD.org cc: qhwt@myrealbox.com Subject: Who to report bugs in wide-dhcp? (was Re: wide-dhcps dumps core freeing modified pointer) X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 10 Aug 2003 07:01:31 -0000 Hello. On Mon, Aug 04, 2003 at 11:33:19AM +0900, qhwt@myrealbox.com wrote: > wide-dhcps dumps core upon boot if the bind file exists and non-empty > (actually I haven't tested if it dumps core even when the file exists > AND is empty, but who cares... :) > The bind file sometimes contains garbage (malloc error message) > after the core dump, but even if I delete the garbage and try to start dhcps > result in the same core dump. > The core dump occurs in function read_subnet() defined in server/database.c, > trying to free() a line buffer via a pointer already modified by prs_inaddr() > called from get_ip(). > The following patch seem to remedie the core dump. > > (I believe MIHIRA-san is the original author of this software, right?) > Regards. > > --- database.c.orig Fri Jan 1 22:35:33 1999 > +++ database.c Sun Aug 3 19:55:32 2003 > @@ -560,15 +560,15 @@ > char **cp; > struct in_addr *subnet; > { > - char *tmpstr; > + char *tmpstr, *line; > struct in_addr *tmpaddr; > > - if ((tmpstr = get_string(cp)) == NULL) { > + if ((line = get_string(cp)) == NULL) { > errno = 0; > syslog(LOG_WARNING, "Can't get strings"); > return(-1); > } > - > + tmpstr = line; > if ((tmpaddr = get_ip(&tmpstr)) == NULL) { > errno = 0; > syslog(LOG_WARNING, "get_ip() error in read_subnet()"); > @@ -576,7 +576,7 @@ > } > > *subnet = *tmpaddr; > - free(tmpstr); > + free(line); > free(tmpaddr); > > return(0); > > Does anyone know who to report bugs in wide-dhcp? I've found a bug in wide-dhcp ports the other day, and reported to ports@FreeBSD.org because the Makefile says it's the maintainer of the port. However, I've received no responses from anyone since then. Shortly after that, I realized that the bug itself is in the original code rather than FreeBSD patches, so I must have sent it to the original author, and that MIHIRA-san is not, because I had no responses from him, even though I Cc:'d on him. Then I found in one of installed documents that bug report should be sent to dhcp-dist@wide.ad.jp . I did, and the mail server at wide.ad.jp said there's no such account there. Or, should I send-pr even if I'm sure the bug is in the orignal code rather than in the FreeBSD ports? But I don't feel like using it because I don't know(and not interested in) how to configure it use my mailer instead of sendmail(1), Regards.