From owner-freebsd-advocacy@FreeBSD.ORG Mon Jun 14 05:40:19 2004 Return-Path: Delivered-To: freebsd-advocacy@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6D99E16A4D0 for ; Mon, 14 Jun 2004 05:40:19 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 501B543D5D for ; Mon, 14 Jun 2004 05:40:19 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) i5E5eJgv047946 for ; Mon, 14 Jun 2004 05:40:19 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i5E5eJDX047945; Mon, 14 Jun 2004 05:40:19 GMT (envelope-from gnats) Resent-Date: Mon, 14 Jun 2004 05:40:19 GMT Resent-Message-Id: <200406140540.i5E5eJDX047945@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-advocacy@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, "Tom McLaughlin" Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A5E6F16A4CE for ; Mon, 14 Jun 2004 05:39:54 +0000 (GMT) Received: from straycat.dhs.org (h0050da134090.ne.client2.attbi.com [24.91.148.154]) by mx1.FreeBSD.org (Postfix) with SMTP id D9B4743D1D for ; Mon, 14 Jun 2004 05:39:53 +0000 (GMT) (envelope-from tmclaugh@sdf.lonestar.org) Received: (qmail 372 invoked from network); 14 Jun 2004 05:39:53 -0000 Received: from compass.straycat.dhs.org (192.168.1.32) by alexandria.straycat.dhs.org with SMTP; 14 Jun 2004 05:39:53 -0000 Message-Id: <1087191593.0@compass.straycat.dhs.org> Date: Mon, 14 Jun 2004 01:39:53 -0400 From: "Tom McLaughlin" To: "FreeBSD gnats submit" X-Send-Pr-Version: gtk-send-pr 0.3.3 cc: riggs@rrr.de Subject: advocacy/67923: [PATCH] muiltimedia/mplayer: Fails to build when WITH_GTK1 knob not set. X-BeenThere: freebsd-advocacy@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: FreeBSD Evangelism List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jun 2004 05:40:19 -0000 >Number: 67923 >Category: advocacy >Synopsis: [PATCH] muiltimedia/mplayer: Fails to build when WITH_GTK1 knob not set. >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-advocacy >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Jun 14 05:40:18 GMT 2004 >Closed-Date: >Last-Modified: >Originator: Tom McLaughlin >Release: FreeBSD 5.2-CURRENT i386 >Organization: >Environment: System: FreeBSD 5.2-CURRENT #1: Sat Jun 12 22:09:46 EDT 2004 root@compass.straycat.dhs.org:/usr/obj/usr/src/sys/COMPASS >Description: Mplayer fails to build when the WITH_GTK1 knob is not set because the videx radeon and rage128 drivers require X11 include files. The WITH_GTK1 knob adds the --enable-gui configure argument which automatically adds their location when compiling. If this is not set then currently the build will fail. Attached patch corrects the Makefile for these drivers so that the X11 includes are always used when compiling them. This is the same problem reported in PR 67913 but that patch does not fix the problem when building with the WITHOUT_GUI knob set. Maintainer CC'ed on PR. Port build error output: cc -c -I../libvo/ -I../../libvo -O -pipe -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -I/usr/local/include/freetype2 -I/usr/local/include -fPIC -I. -I.. -o radeon_vid.o radeon_vid.c radeon_vid.c:29:22: X11/Xlib.h: No such file or directory radeon_vid.c: In function `probe_fireGL_driver': radeon_vid.c:925: error: `Display' undeclared (first use in this function) radeon_vid.c:925: error: (Each undeclared identifier is reported only once radeon_vid.c:925: error: for each function it appears in.) radeon_vid.c:925: error: `dp' undeclared (first use in this function) radeon_vid.c:927: warning: initialization makes pointer from integer without a cast gmake[2]: *** [radeon_vid.o] Error 1 gmake[2]: Leaving directory `/usr/ports/multimedia/mplayer.old/work/MPlayer-1.0pre4/vidix/drivers' gmake[1]: *** [all] Error 2 gmake[1]: Leaving directory `/usr/ports/multimedia/mplayer.old/work/MPlayer-1.0pre4/vidix' gmake: *** [vidix/libvidix.a] Error 2 *** Error code 2 >How-To-Repeat: >Fix: --- mplayer_radeon.diff begins here --- diff -Nur mplayer.orig/files/patch-videx_drivers_Makefile mplayer/files/patch-videx_drivers_Makefile --- mplayer.orig/files/patch-videx_drivers_Makefile Wed Dec 31 19:00:00 1969 +++ mplayer/files/patch-videx_drivers_Makefile Mon Jun 14 01:05:44 2004 @@ -0,0 +1,18 @@ +--- vidix/drivers/Makefile.orig Wed Oct 22 12:45:33 2003 ++++ vidix/drivers/Makefile Mon Jun 14 01:04:55 2004 +@@ -14,13 +14,13 @@ + RADEON_SRCS=radeon_vid.c + RADEON_OBJS=radeon_vid.o + RADEON_LIBS=-L../../libdha -ldha -lm +-RADEON_CFLAGS=$(OPTFLAGS) -fPIC -I. -I.. ++RADEON_CFLAGS=$(OPTFLAGS) $(X11_INC) -fPIC -I. -I.. + + RAGE128_VID=rage128_vid.so + RAGE128_SRCS=radeon_vid.c + RAGE128_OBJS=rage128_vid.o + RAGE128_LIBS=-L../../libdha -ldha +-RAGE128_CFLAGS=$(OPTFLAGS) -fPIC -I. -I.. -DRAGE128 ++RAGE128_CFLAGS=$(OPTFLAGS) $(X11_INC) -fPIC -I. -I.. -DRAGE128 + + PM3_VID=pm3_vid.so + PM3_SRCS=pm3_vid.c --- mplayer_radeon.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted: From owner-freebsd-advocacy@FreeBSD.ORG Mon Jun 14 08:41:11 2004 Return-Path: Delivered-To: freebsd-advocacy@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B5BED16A4CE; Mon, 14 Jun 2004 08:41:11 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 98BCA43D41; Mon, 14 Jun 2004 08:41:11 +0000 (GMT) (envelope-from pav@FreeBSD.org) Received: from freefall.freebsd.org (pav@localhost [127.0.0.1]) i5E8fBPM058269; Mon, 14 Jun 2004 08:41:11 GMT (envelope-from pav@freefall.freebsd.org) Received: (from pav@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i5E8fBW1058265; Mon, 14 Jun 2004 08:41:11 GMT (envelope-from pav) Date: Mon, 14 Jun 2004 08:41:11 GMT From: Pav Lucistnik Message-Id: <200406140841.i5E8fBW1058265@freefall.freebsd.org> To: pav@FreeBSD.org, freebsd-advocacy@FreeBSD.org, freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/67923: [PATCH] muiltimedia/mplayer: Fails to build when WITH_GTK1 knob not set. X-BeenThere: freebsd-advocacy@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: FreeBSD Evangelism List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jun 2004 08:41:11 -0000 Synopsis: [PATCH] muiltimedia/mplayer: Fails to build when WITH_GTK1 knob not set. Responsible-Changed-From-To: freebsd-advocacy->freebsd-ports-bugs Responsible-Changed-By: pav Responsible-Changed-When: Mon Jun 14 08:40:55 GMT 2004 Responsible-Changed-Why: Reclassify http://www.freebsd.org/cgi/query-pr.cgi?pr=67923 From owner-freebsd-advocacy@FreeBSD.ORG Mon Jun 14 11:01:47 2004 Return-Path: Delivered-To: freebsd-advocacy@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3501316A4D0 for ; Mon, 14 Jun 2004 11:01:47 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 175CE43D31 for ; Mon, 14 Jun 2004 11:01:47 +0000 (GMT) (envelope-from owner-bugmaster@freebsd.org) Received: from freefall.freebsd.org (peter@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.11/8.12.11) with ESMTP id i5EB1XqY072510 for ; Mon, 14 Jun 2004 11:01:33 GMT (envelope-from owner-bugmaster@freebsd.org) Received: (from peter@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i5EB1W9T072504 for freebsd-advocacy@freebsd.org; Mon, 14 Jun 2004 11:01:32 GMT (envelope-from owner-bugmaster@freebsd.org) Date: Mon, 14 Jun 2004 11:01:32 GMT Message-Id: <200406141101.i5EB1W9T072504@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: peter set sender to owner-bugmaster@freebsd.org using -f From: FreeBSD bugmaster To: freebsd-advocacy@FreeBSD.org Subject: Current problem reports assigned to you X-BeenThere: freebsd-advocacy@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: FreeBSD Evangelism List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jun 2004 11:01:47 -0000 Current FreeBSD problem reports Critical problems Serious problems Non-critical problems S Submitted Tracker Resp. Description ------------------------------------------------------------------------------- o [2004/06/04] advocacy/67580advocacy Hints for boot failures. 1 problem total.