From owner-freebsd-apache@FreeBSD.ORG Sun Jan 29 10:54:20 2006 Return-Path: X-Original-To: apache@freebsd.org Delivered-To: freebsd-apache@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8FD0C16A420 for ; Sun, 29 Jan 2006 10:54:20 +0000 (GMT) (envelope-from w@expro.pl) Received: from mailin1.expro.pl (mailin1.expro.pl [193.25.166.20]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3017E43D48 for ; Sun, 29 Jan 2006 10:54:19 +0000 (GMT) (envelope-from w@expro.pl) Received: from miranda-1.dmz.exprozone ([10.0.16.20] helo=miranda.expro.pl) (envelope-sender ) by mailin1.expro.pl with esmtp (Exim 4.50) id 1F3ACI-0002vL-2m for apache@freebsd.org; Sun, 29 Jan 2006 11:54:18 +0100 Received: by miranda.expro.pl (Postfix, from userid 1001) id 33EBA54818; Sun, 29 Jan 2006 11:54:18 +0100 (CET) Date: Sun, 29 Jan 2006 11:54:18 +0100 From: Jan Srzednicki To: apache@freebsd.org Message-ID: <20060129105418.GL34989@miranda.expro.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.11 Cc: Subject: mod_curb ridiculously unsafe tmp file creation X-BeenThere: freebsd-apache@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Support of apache-related ports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Jan 2006 10:54:20 -0000 Hi, I've discovered that mod_curb (ports/www/mod_curb) uses a ridiculously unsafe method to access a file in /tmp: file mod_curb.c, line 42: log = fopen( "/tmp/modcurb.log","a" ); The same issue exists in other software written by this author, but fortunately there's nothing more of it in ports. :) -- Jan Srzednicki w@expro.pl From owner-freebsd-apache@FreeBSD.ORG Sun Jan 29 10:57:23 2006 Return-Path: X-Original-To: apache@freebsd.org Delivered-To: freebsd-apache@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F182416A420 for ; Sun, 29 Jan 2006 10:57:23 +0000 (GMT) (envelope-from eriam@eriamschaffter.info) Received: from web.mediavirtuel.com (web.mediavirtuel.com [62.73.1.171]) by mx1.FreeBSD.org (Postfix) with ESMTP id E748843D53 for ; Sun, 29 Jan 2006 10:57:22 +0000 (GMT) (envelope-from eriam@eriamschaffter.info) Received: from localhost (unknown [127.0.0.1]) by web.mediavirtuel.com (Postfix) with ESMTP id 3D7BB21929D; Sun, 29 Jan 2006 13:02:29 +0000 (UTC) Received: from web.mediavirtuel.com ([127.0.0.1]) by localhost (web.mediavirtuel.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 94730-01-3; Sun, 29 Jan 2006 13:02:25 +0000 (UTC) Received: from eriam (cable-62-205-111-142.upc.chello.be [62.205.111.142]) by web.mediavirtuel.com (Postfix) with ESMTP id 105BB2190FD; Sun, 29 Jan 2006 13:02:25 +0000 (UTC) From: "Eriam Schaffter" To: "'Jan Srzednicki'" Date: Sun, 29 Jan 2006 11:57:04 +0100 X-Mailer: Microsoft Office Outlook, Build 11.0.5510 In-Reply-To: <20060129105418.GL34989@miranda.expro.pl> X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.2180 Thread-Index: AcYk0+lzpbJ2nbi0RVyYWcyil8O1lQAEWIUw Message-Id: <20060129130225.105BB2190FD@web.mediavirtuel.com> X-Virus-Scanned: amavisd-new at web.mediavirtuel.org Cc: apache@freebsd.org Subject: RE: mod_curb ridiculously unsafe tmp file creation X-BeenThere: freebsd-apache@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Support of apache-related ports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Jan 2006 10:57:24 -0000 Hello Why is that so unsafe ? Thanks > -----Message d'origine----- > De : owner-freebsd-apache@freebsd.org > [mailto:owner-freebsd-apache@freebsd.org] De la part de Jan Srzednicki > Envoyé : dimanche, 29. janvier 2006 11:54 > À : apache@freebsd.org > Objet : mod_curb ridiculously unsafe tmp file creation > > Hi, > > I've discovered that mod_curb (ports/www/mod_curb) uses a > ridiculously unsafe method to access a file in /tmp: > > file mod_curb.c, line 42: > > log = fopen( "/tmp/modcurb.log","a" ); > > The same issue exists in other software written by this > author, but fortunately there's nothing more of it in ports. :) > > -- > Jan Srzednicki > w@expro.pl > > _______________________________________________ > freebsd-apache@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-apache > To unsubscribe, send any mail to > "freebsd-apache-unsubscribe@freebsd.org" > > -- > No virus found in this incoming message. > Checked by AVG Free Edition. > Version: 7.1.375 / Virus Database: 267.14.23/243 - Release > Date: 27.01.2006 > > -- No virus found in this outgoing message. Checked by AVG Free Edition. Version: 7.1.375 / Virus Database: 267.14.23/243 - Release Date: 27.01.2006 From owner-freebsd-apache@FreeBSD.ORG Sun Jan 29 11:04:37 2006 Return-Path: X-Original-To: apache@freebsd.org Delivered-To: freebsd-apache@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D805716A420 for ; Sun, 29 Jan 2006 11:04:37 +0000 (GMT) (envelope-from w@expro.pl) Received: from mailin1.expro.pl (mailin1.expro.pl [193.25.166.20]) by mx1.FreeBSD.org (Postfix) with ESMTP id 702F543D45 for ; Sun, 29 Jan 2006 11:04:37 +0000 (GMT) (envelope-from w@expro.pl) Received: from miranda-1.dmz.exprozone ([10.0.16.20] helo=miranda.expro.pl) (envelope-sender ) by mailin1.expro.pl with esmtp (Exim 4.50) id 1F3AMF-0003OF-Jy; Sun, 29 Jan 2006 12:04:36 +0100 Received: by miranda.expro.pl (Postfix, from userid 1001) id A462A54817; Sun, 29 Jan 2006 12:04:35 +0100 (CET) Date: Sun, 29 Jan 2006 12:04:35 +0100 From: Jan Srzednicki To: Eriam Schaffter Message-ID: <20060129110435.GM34989@miranda.expro.pl> References: <20060129105418.GL34989@miranda.expro.pl> <20060129130225.105BB2190FD@web.mediavirtuel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060129130225.105BB2190FD@web.mediavirtuel.com> User-Agent: Mutt/1.5.11 Cc: apache@freebsd.org Subject: Re: mod_curb ridiculously unsafe tmp file creation X-BeenThere: freebsd-apache@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Support of apache-related ports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Jan 2006 11:04:38 -0000 On Sun, Jan 29, 2006 at 11:57:04AM +0100, Eriam Schaffter wrote: > Hello > > Why is that so unsafe ? If I (as any unprivileged user) symlink /tmp/modcurb.log to anything that the Apache user has access to, the module will blindly append it's log data to that file, which can corrupt binary or structuralized text files of any kind. No checking if /tmp/modcurb.log exists is done at all. Anyway, /tmp is a pretty dumb location for a log file. -- Jan Srzednicki w@expro.pl From owner-freebsd-apache@FreeBSD.ORG Mon Jan 30 11:01:02 2006 Return-Path: X-Original-To: apache@freebsd.org Delivered-To: freebsd-apache@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 08BAB16A420 for ; Mon, 30 Jan 2006 11:01:02 +0000 (GMT) (envelope-from owner-bugmaster@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id C88D143D4C for ; Mon, 30 Jan 2006 11:01:01 +0000 (GMT) (envelope-from owner-bugmaster@freebsd.org) Received: from freefall.freebsd.org (peter@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k0UB11xW018387 for ; Mon, 30 Jan 2006 11:01:01 GMT (envelope-from owner-bugmaster@freebsd.org) Received: (from peter@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k0UB10KF018375 for apache@freebsd.org; Mon, 30 Jan 2006 11:01:00 GMT (envelope-from owner-bugmaster@freebsd.org) Date: Mon, 30 Jan 2006 11:01:00 GMT Message-Id: <200601301101.k0UB10KF018375@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: peter set sender to owner-bugmaster@freebsd.org using -f From: FreeBSD bugmaster To: apache@FreeBSD.org Cc: Subject: Current problem reports assigned to you X-BeenThere: freebsd-apache@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Support of apache-related ports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Jan 2006 11:01:02 -0000 Current FreeBSD problem reports Critical problems Serious problems S Submitted Tracker Resp. Description ------------------------------------------------------------------------------- o [2005/11/20] ports/89308 apache [patch] www/mod_accounting crash on reque 1 problem total. Non-critical problems S Submitted Tracker Resp. Description ------------------------------------------------------------------------------- o [2004/12/09] ports/74907 apache [PATCH] www/mod_perl: cleanups o [2005/05/18] ports/81183 apache apache13-modperl can not compile with por o [2005/12/05] ports/89972 apache portupgrade apache+ssl fails on dependenc 3 problems total. From owner-freebsd-apache@FreeBSD.ORG Thu Feb 2 18:27:36 2006 Return-Path: X-Original-To: apache@FreeBSD.org Delivered-To: freebsd-apache@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3289A16A420 for ; Thu, 2 Feb 2006 18:27:36 +0000 (GMT) (envelope-from msoulier@gmail.com) Received: from uproxy.gmail.com (uproxy.gmail.com [66.249.92.193]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2D7AC43D49 for ; Thu, 2 Feb 2006 18:27:34 +0000 (GMT) (envelope-from msoulier@gmail.com) Received: by uproxy.gmail.com with SMTP id o2so28283uge for ; Thu, 02 Feb 2006 10:27:33 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:sender:to:subject:mime-version:content-type:content-transfer-encoding:content-disposition; b=SWd68Zta2S5mAAhqVfLnmSSX/afl8rGqDuUCo65cdpbWVG7oGtn0yV4PjmcwWFPWdJosi5WoC8KV2BH8EH4tCNjiK9+5GoIS+GwSSWbAWh5IqjRZ2r4P8acuJe/lH8lSN7dj2ctzhcGxUGI84l3dZrr9hrBMU4IPEg44VOJi6YQ= Received: by 10.48.108.7 with SMTP id g7mr225663nfc; Thu, 02 Feb 2006 10:27:33 -0800 (PST) Received: by 10.49.75.16 with HTTP; Thu, 2 Feb 2006 10:27:33 -0800 (PST) Message-ID: Date: Thu, 2 Feb 2006 13:27:33 -0500 From: "Michael P. Soulier" Sender: msoulier@gmail.com To: apache@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Cc: Subject: fails to build X-BeenThere: freebsd-apache@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Support of apache-related ports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Feb 2006 18:27:36 -0000 Hello, I'm on FreeBSD 5.4, trying to build mod_mp3 out of ports for apache2 & mod_perl2, and I'm having this failure. =3D=3D=3D> Building for mod_mp3-0.40 `/usr/local/sbin/apxs -q CC` `/usr/local/sbin/apxs -q CFLAGS_SHLIB` -I`/usr/local/sbin/apxs -q INCLUDEDIR` `/usr/local/sbin/apxs -q CFLAGS` -DCONTENT_DISPOSITION -DSELECT_ENABLED -c src/mod_mp3.c -DCONTENT_DISPOSITION -DSELECT_ENABLED -o src/mod_mp3.lo In file included from src/mod_mp3.c:6: src/mod_mp3.h:43: error: syntax error before "mp3_module" src/mod_mp3.h:108: error: syntax error before "table" src/mod_mp3.h:119: error: syntax error before "array_header" src/mod_mp3.h:132: error: syntax error before '*' token src/mod_mp3.h:133: error: syntax error before "pool" src/mod_mp3.h:134: error: syntax error before "pool" src/mod_mp3.h:135: error: syntax error before "pool" src/mod_mp3.h:136: error: syntax error before "pool" src/mod_mp3.h:137: error: syntax error before "pool" src/mod_mp3.h:138: error: syntax error before "pool" src/mod_mp3.h:162: error: syntax error before "array_header" In file included from src/mod_mp3.h:169, from src/mod_mp3.c:6: I have WITH_APACHE2=3D"yes" in my make.conf file. Any idea what's causing the issue? Thanks, Mike -- Michael P. Soulier "Any intelligent fool can make things bigger and more complex... It takes a touch of genius - and a lot of courage to move in the opposite direction." --Albert Einstein