From owner-freebsd-bugs@FreeBSD.ORG Sun Dec 6 03:00:15 2009 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6E1721065696 for ; Sun, 6 Dec 2009 03:00:15 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 0E16A8FC18 for ; Sun, 6 Dec 2009 03:00:15 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id nB630Etv024102 for ; Sun, 6 Dec 2009 03:00:14 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id nB630EOU024094; Sun, 6 Dec 2009 03:00:14 GMT (envelope-from gnats) Date: Sun, 6 Dec 2009 03:00:14 GMT Message-Id: <200912060300.nB630EOU024094@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: Alexander Best Cc: Subject: Re: kern/140752: [ata] HDD power-off procedure is not clean X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Alexander Best List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Dec 2009 03:00:15 -0000 The following reply was made to PR kern/140752; it has been noted by GNATS. From: Alexander Best To: , Cc: Subject: Re: kern/140752: [ata] HDD power-off procedure is not clean Date: Sun, 06 Dec 2009 03:58:14 +0100 (CET) This is a MIME encoded multipart message. --+permail-2009120602581480e26a0b000071f6-a_best01+ Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit this issue has been discussed in a few threads already, but i don't think an agreement about how to handle the issue was made. see http://lists.freebsd.org/pipermail/freebsd-hackers/2009-March/027879.html attached is a small patch against HEAD which should set any hdd into standby immediate state (if supported) before shutdown. before that however hdds get their cache flushed which isn't recommended by the document you refer to in your pr. so you might want to remove that code from ad_shutdown(). this issue needs to finally get solved imo. the technical part is quite simple actually. however discussing this issue has always led to bikesheds. :( cheers. alex --+permail-2009120602581480e26a0b000071f6-a_best01+ Content-Type: text/plain Content-Transfer-Encoding: Base64 Content-Disposition: attachment; filename="atadisk.c.patch.txt" SW5kZXg6IHN5cy9kZXYvYXRhL2F0YS1kaXNrLmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gc3lzL2Rldi9hdGEv YXRhLWRpc2suYwkocmV2aXNpb24gMjAwMTc2KQorKysgc3lzL2Rldi9hdGEvYXRhLWRpc2suYwko d29ya2luZyBjb3B5KQpAQCAtMTg5LDYgKzE4OSwxMCBAQAogCiAgICAgaWYgKGF0YWRldi0+cGFy YW0uc3VwcG9ydC5jb21tYW5kMiAmIEFUQV9TVVBQT1JUX0ZMVVNIQ0FDSEUpCiAJYXRhX2NvbnRy b2xjbWQoZGV2LCBBVEFfRkxVU0hDQUNIRSwgMCwgMCwgMCk7CisKKyAgICBpZiAoYXRhZGV2LT5w YXJhbS5zdXBwb3J0LmNvbW1hbmQyICYgQVRBX1NVUFBPUlRfU1RBTkRCWSkKKwlhdGFfY29udHJv bGNtZChkZXYsIEFUQV9TVEFOREJZX0lNTUVESUFURSwgMCwgMCwgMCk7CisKICAgICByZXR1cm4g MDsKIH0KIAo= --+permail-2009120602581480e26a0b000071f6-a_best01+--