From owner-freebsd-bluetooth@FreeBSD.ORG Mon Jan 25 16:13:42 2010 Return-Path: Delivered-To: freebsd-bluetooth@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1E7621065692 for ; Mon, 25 Jan 2010 16:13:42 +0000 (UTC) (envelope-from masoom.shaikh@gmail.com) Received: from mail-pz0-f202.google.com (mail-pz0-f202.google.com [209.85.222.202]) by mx1.freebsd.org (Postfix) with ESMTP id E0D7A8FC1B for ; Mon, 25 Jan 2010 16:13:41 +0000 (UTC) Received: by pzk40 with SMTP id 40so763989pzk.7 for ; Mon, 25 Jan 2010 08:13:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type; bh=bscKKoTkmH4XsCGiFbhqLL6vTt3q+SrHkvVoHFtdKbg=; b=dIpElKHDAODwjaKqXthodutK491nEqccAxbidJvAg2opHtlgbjRoTJXBxNMlAh7i4d +Sn4EmNJZ4G5Jpe7OsgT7LNo++ZliIUWo2+U4+dW3MXIJzXQ1YmOWztjXXIstxGvUe0D DlNoYtMvF01Q5RVndYeDr8wVuOcWpJXOYfFS4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=U6SZXHZMEa5iL+tGv9gRxkAXfb71AqwO1+gdwCPFNa6X054fiIiShD1H3Lq8wDCEN3 JQoFvl2ERhNavPuNquzBep6aQh2zSGLBb3zV0CYgzs3uDS9xkfVyNSauQ0rwwVl56s7P +T+zONv/hgNpytY97WmdPgVcX6HAjtzYvTXyA= MIME-Version: 1.0 Received: by 10.114.21.1 with SMTP id 1mr4668678wau.16.1264436021336; Mon, 25 Jan 2010 08:13:41 -0800 (PST) In-Reply-To: References: <1254763597.419838.805.nullmailer@galant.ukfsn.org> Date: Mon, 25 Jan 2010 16:13:41 +0000 Message-ID: From: Masoom Shaikh To: Maksim Yevmenkin Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: freebsd-bluetooth@freebsd.org Subject: Re: bluetooth.h, c++ include error X-BeenThere: freebsd-bluetooth@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Using Bluetooth in FreeBSD environments List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Jan 2010 16:13:42 -0000 On Mon, Oct 26, 2009 at 5:43 PM, Maksim Yevmenkin < maksim.yevmenkin@gmail.com> wrote: > On Tue, Oct 6, 2009 at 8:48 AM, Masoom Shaikh > wrote: > > > > > > On Mon, Oct 5, 2009 at 5:26 PM, Iain Hibbert > wrote: > >> > >> On Mon, 5 Oct 2009, Masoom Shaikh wrote: > >> > >> > what i am requesting is just variable name change ;-) my tree is at > >> > revision 197571, thus the patch i am presenting is also generated > >> > against it reject this if you want patch against latest revision > >> > > >> > renamed second argument of bt_devfilter() from 'new' to 'dfnew'. df > for > >> > device filter to maintain uniformity renamed third argument from 'old' > >> > to 'dfold'. > >> > >> style(9) mentions that for kernel include files exposed to userland > >> (technically, this is always in userland but perhaps the same rules > apply) > >> the prototype tag arguments should be made safe, eg starting with a _ > >> perhaps for much this reason.. > >> > >> so, my suggestion would be to use _new and _old etc.. > >> > >> iain > >> > >> (or, just don't use them, they are not especially required :) > >> > > so this shall work > > i just renamed bt_devfilter() variable names, because it was the one > which > > caused trouble > > will someone commit this ? > > i just committed fix for this. > > thanks > max > I am using FreeBSD raptor 8.0-RELEASE FreeBSD 8.0-RELEASE #0 r201047:201048M: Mon Dec 28 10:42:01 UTC 2009 root@raptor:/usr/obj/usr/src/sys/GENERIC amd64 still I see the same variable names,