From owner-freebsd-current@FreeBSD.ORG Sat Aug 21 22:49:47 2010 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C259810656A5; Sat, 21 Aug 2010 22:49:47 +0000 (UTC) (envelope-from sektie@gmail.com) Received: from mail-qw0-f54.google.com (mail-qw0-f54.google.com [209.85.216.54]) by mx1.freebsd.org (Postfix) with ESMTP id 57F9F8FC21; Sat, 21 Aug 2010 22:49:46 +0000 (UTC) Received: by qwg5 with SMTP id 5so4640608qwg.13 for ; Sat, 21 Aug 2010 15:49:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:references:message-id:from:to :in-reply-to:content-type:content-transfer-encoding:x-mailer :mime-version:subject:date:cc; bh=DliOtuYO3Twj2Mmpet2fwK3sLt+nwKc5FF6QVNzyCt4=; b=aihmDUoWhX2DPqJ2AViIgSROZQ4xRu3aCh2oCV4LpryFWK8+/TT6p0zpnU2hSMYzOW gzHHnRGt4CtDf6tTDoO0Y1biXWuyon/hGZ2w73EY2bahjDRMedUE9V4SpCAsTGL2fLO8 /U3HI83UhcWVaj28H22ef0RFNxefT3zbwWBCM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=references:message-id:from:to:in-reply-to:content-type :content-transfer-encoding:x-mailer:mime-version:subject:date:cc; b=nMG5cduwnUNX68WpFD+bONN4MMSnhD8mmgK0RpOOuxKiFxOOgm2IN5vwVxTrKXNNam svuSPqmC2SlSHml3cwK7zmfbKA5TotUfe873TukVn3KaHuim28hX9wfc7t1+fj9b5YB6 TGTShV022HZKEOqIRBMWdS6z4GRQIek4ph0g4= Received: by 10.229.251.210 with SMTP id mt18mr2290055qcb.151.1282429379256; Sat, 21 Aug 2010 15:22:59 -0700 (PDT) Received: from [192.168.0.34] ([173.156.245.188]) by mx.google.com with ESMTPS id l8sm5011232qck.30.2010.08.21.15.22.56 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sat, 21 Aug 2010 15:22:58 -0700 (PDT) References: <9674C06D-DC2D-40C3-B523-E397C9ADC37B@christianserving.org> <641B7F47-CD12-415D-A808-861F4E85F60C@FreeBSD.org> Message-Id: From: Randi Harper To: Rui Paulo In-Reply-To: <641B7F47-CD12-415D-A808-861F4E85F60C@FreeBSD.org> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Mailer: iPad Mail (7B367) Mime-Version: 1.0 (iPad Mail 7B367) Date: Sat, 21 Aug 2010 15:24:22 -0700 X-Mailman-Approved-At: Sun, 22 Aug 2010 00:15:27 +0000 Cc: "freebsd-current@freebsd.org" , Jim Riggs Subject: Re: CD/DVD ejecting after sysinstall X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Aug 2010 22:49:47 -0000 On Aug 20, 2010, at 14:21, Rui Paulo wrote: >=20 > On 20 Aug 2010, at 20:46, Jim Riggs wrote: >=20 >> References: >>=20 >> http://www.mail-archive.com/svn-src-all@freebsd.org/msg24380.html >> http://forums.freebsd.org/showthread.php?t=3D17126 >>=20 >>=20 >> This commit automatically ejects the CD when sysinstall exits which = almost had dire consequences for me this week. As described in the = forum post, I keep a LiveFS CD in all of my servers so that I can = remotely diagnose and fix issues. I have done this for several years = now, and it has saved my tail many times. >>=20 >> However, I got a surprise when I tried it today with the new 8.1 = LiveFS CDs I had just burned. After attempting to fix a problem from = the LiveFS and rebooting back to the HD, the problem still existed. No = problem. I just tried to boot back to the CD only to find that it was = gone. Luckily, this was on a box in-house, so I was quickly able to see = what was wrong. >>=20 >> Now that I have the commit, I can roll my own patched sysinstall and = CDs, but the question is: Should we be ejecting the media without any = prompt? Obviously, for my use case, I liked the old behavior of just = reminding the user to eject the media when rebooting. I understand that = may not be optimal for some users. Can we present a dialog asking the = user if they want the media to be ejected? That still leaves me at risk = of selecting the wrong answer, I suppose. I would rather not have to = roll my own LiveFS CDs every time, though. >>=20 >> Thoughts from anyone else? (Please copy me on responses.) >=20 > You are correct. We should not be ejecting the CD without a prompt. If = the commit is reverted, it should be explicitly noted in the code so = that we don't do this mistake again. >=20 > Regards, > -- > Rui Paulo >=20 >=20 That's a judgement call, not an absolute. I think what we are doing = isn't a problem for 99.999% of use cases. -- randi=