From owner-freebsd-rc@FreeBSD.ORG Mon Mar 22 11:07:11 2010 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 46E3C1065677 for ; Mon, 22 Mar 2010 11:07:11 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 35B568FC08 for ; Mon, 22 Mar 2010 11:07:11 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o2MB7BGP015145 for ; Mon, 22 Mar 2010 11:07:11 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o2MB7A6W015143 for freebsd-rc@FreeBSD.org; Mon, 22 Mar 2010 11:07:10 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 22 Mar 2010 11:07:10 GMT Message-Id: <201003221107.o2MB7A6W015143@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: gnats set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-rc@FreeBSD.org Cc: Subject: Current problem reports assigned to freebsd-rc@FreeBSD.org X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Mar 2010 11:07:11 -0000 Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). The following is a listing of current problems submitted by FreeBSD users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Tracker Resp. Description -------------------------------------------------------------------------------- o conf/144213 rc [rc.d] [patch] Disappearing zvols on reboot o conf/143637 rc [patch] ntpdate(8) support for ntp-servers supplied by o conf/143085 rc [patch] ftp-proxy(8) rc(8) with multiple instances o conf/143084 rc [jail] [patch]: fix rc.d/jail creating stray softlinks o conf/142973 rc [jail] [patch] Strange counter init value in jail rc o conf/142434 rc [patch] Add cpuset(1) support to rc.subr(8) o conf/142304 rc rc.conf(5): mdconfig and mdconfig2 rc.d scripts lack e o conf/141909 rc rc.subr(8): [patch] add rc.conf.d support to /usr/loca o conf/141907 rc [rc.d] Bug if mtu (maybe others?) is set as first argu o conf/141678 rc [patch] A minor enhancement to how /etc/rc.d/jail dete o conf/141275 rc [request] dhclient(8) rc script should print something o conf/140440 rc [patch] allow local command files in rc.{suspend,resum o conf/140261 rc [patch] Improve flexibility of mdconfig2 startup scrip o conf/138208 rc [rc] [patch] Making rc.firewall (workstation) IPv6 awa o conf/137629 rc [rc] background_dhclient rc.conf option causing double o conf/137470 rc [PATCH] /etc/rc.d/mdconfig2 : prioritize cli parameter o conf/136875 rc [request] _flags appending o conf/136624 rc [rc.d] sysctl variables for ipnat are not applied on b o conf/135338 rc [rc.d] pf startup order seems broken [regression] o conf/134918 rc [patch] rc.subr fails to detect perl daemons o conf/134660 rc [patch] rc-script for initializing ng_netflow+ng_ipfw o conf/134333 rc PPP configuration problem in the rc.d scripts in combi o conf/134006 rc [patch] Unload console screensaver kernel modules if s o conf/133987 rc [rc.d] defaultroute broken with DHCP in some cases o conf/133890 rc [patch] sshd(8): add multiple profiles to the rc.d scr o conf/132483 rc rc.subr(8) [patch] setfib(1) support for rc.subr o conf/132476 rc [rc.d] [patch] add support setfib(1) in rc.d/routing o conf/130414 rc [patch] rc services started with onestart are not stop o conf/128299 rc [patch] /etc/rc.d/geli does not mount partitions using o conf/127917 rc [patch] dumpon rejects on start with physmem>swap even o bin/126562 rc rcorder(8) fails to run unrelated startup scripts when o conf/126392 rc [patch] rc.conf ifconfig_xx keywords cannot be escaped p bin/126324 rc [patch] rc.d/tmp: Prevent mounting /tmp in second tim o conf/124747 rc [patch] savecore can't create dump from encrypted swap o conf/124248 rc [jail] [patch] add support for nice value for rc.d/jai o conf/123734 rc [patch] Chipset VIA CX700 requires extra initializatio o conf/123222 rc [patch] Add rtprio(1)/idprio(1) support to rc.subr(8). o conf/122477 rc [patch] /etc/rc.d/mdconfig and mdconfig2 are ignoring o conf/122170 rc [patch] [request] New feature: notify admin via page o o kern/121566 rc [nfs] [request] [patch] ethernet iface should be broug o conf/120431 rc [patch] devfs.rules are not initialized under certain o conf/120406 rc [devd] [patch] Handle newly attached pcm devices (eg. o conf/119874 rc [patch] "/etc/rc.d/pf reload" fails if there are macro o conf/119076 rc [patch] [rc.d] /etc/rc.d/netif tries to remove alias a o bin/118325 rc [patch] [request] new periodic script to test statuses o conf/118255 rc savecore never finding kernel core dumps (rcorder prob o conf/117935 rc [patch] ppp fails to start at boot because of missing o conf/113915 rc [patch] ndis wireless driver fails to associate when i o conf/109980 rc /etc/rc.d/netif restart doesn't destroy cloned_interfa o conf/109562 rc [rc.d] [patch] [request] Make rc.d/devfs usable from c o conf/108589 rc rtsol(8) fails due to default ipfw rules o conf/106009 rc [ppp] [patch] [request] Fix pppoed startup script to p o conf/105689 rc [ppp] [request] syslogd starts too late at boot o conf/105568 rc [patch] [request] Add more flexibility to rc.conf, to o conf/105145 rc [ppp] [patch] [request] add redial function to rc.d/pp o conf/104549 rc [patch] rc.d/nfsd needs special _find_processes functi o conf/102700 rc [geli] [patch] Add encrypted /tmp support to GELI/GBDE o conf/99721 rc [patch] /etc/rc.initdiskless problem copy dotfile in s o conf/99444 rc [patch] Enhancement: rc.subr could easily support star o conf/96343 rc [patch] rc.d order change to start inet6 before pf o conf/93815 rc [patch] Adds in the ability to save ipfw rules to rc.d o conf/92523 rc [patch] allow rc scripts to kill process after a timeo o conf/89870 rc [patch] [request] make netif verbose rc.conf toggle o conf/89061 rc [patch] IPv6 6to4 auto-configuration enhancement o conf/88913 rc [patch] wrapper support for rc.subr o conf/85819 rc [patch] script allowing multiuser mode in spite of fsc o kern/81006 rc ipnat not working with tunnel interfaces on startup o conf/77663 rc Suggestion: add /etc/rc.d/addnetswap after addcritremo o conf/73677 rc [patch] add support for powernow states to power_profi o conf/58939 rc [patch] dumb little hack for /etc/rc.firewall{,6} o conf/56934 rc [patch] rc.firewall rules for natd expect an interface o conf/45226 rc [patch] Fix for rc.network, ppp-user annoyance o conf/44170 rc [patch] Add ability to run multiple pppoed(8) on start 73 problems total. From owner-freebsd-rc@FreeBSD.ORG Wed Mar 24 23:21:45 2010 Return-Path: Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 801C4106564A; Wed, 24 Mar 2010 23:21:45 +0000 (UTC) (envelope-from linimon@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 5780B8FC12; Wed, 24 Mar 2010 23:21:45 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o2ONLjPp005665; Wed, 24 Mar 2010 23:21:45 GMT (envelope-from linimon@freefall.freebsd.org) Received: (from linimon@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o2ONLj57005661; Wed, 24 Mar 2010 23:21:45 GMT (envelope-from linimon) Date: Wed, 24 Mar 2010 23:21:45 GMT Message-Id: <201003242321.o2ONLj57005661@freefall.freebsd.org> To: linimon@FreeBSD.org, freebsd-bugs@FreeBSD.org, freebsd-rc@FreeBSD.org From: linimon@FreeBSD.org Cc: Subject: Re: conf/145009: [patch] rc.subr(8): rc.conf should allow mac label configuration X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Mar 2010 23:21:45 -0000 Old Synopsis: rc.conf should allow mac label configuration New Synopsis: [patch] rc.subr(8): rc.conf should allow mac label configuration Responsible-Changed-From-To: freebsd-bugs->freebsd-rc Responsible-Changed-By: linimon Responsible-Changed-When: Wed Mar 24 23:21:15 UTC 2010 Responsible-Changed-Why: Over to maintainer(s). http://www.freebsd.org/cgi/query-pr.cgi?pr=145009 From owner-freebsd-rc@FreeBSD.ORG Fri Mar 26 19:02:45 2010 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8FB41106564A for ; Fri, 26 Mar 2010 19:02:45 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 636168FC16 for ; Fri, 26 Mar 2010 19:02:45 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 004C946B45 for ; Fri, 26 Mar 2010 15:02:45 -0400 (EDT) Received: from jhbbsd.localnet (smtp.hudson-trading.com [209.249.190.9]) by bigwig.baldwin.cx (Postfix) with ESMTPA id 30A098A01F for ; Fri, 26 Mar 2010 15:02:44 -0400 (EDT) From: John Baldwin To: freebsd-rc@freebsd.org Date: Fri, 26 Mar 2010 14:10:35 -0400 User-Agent: KMail/1.12.1 (FreeBSD/7.3-CBSD-20100217; KDE/4.3.1; amd64; ; ) MIME-Version: 1.0 Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Message-Id: <201003261410.35830.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Fri, 26 Mar 2010 15:02:44 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-1.7 required=4.2 tests=AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Subject: mountd and reload X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Mar 2010 19:02:45 -0000 FYI, it would be nice if someone could fix it so that /etc/rc.d/mountd reload works when nfs_server_enable="YES" is set in /etc/rc.conf but mountd_enable="YES" is not explicitly set. -- John Baldwin From owner-freebsd-rc@FreeBSD.ORG Fri Mar 26 19:14:11 2010 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F3ADE1065670 for ; Fri, 26 Mar 2010 19:14:10 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.freebsd.org (Postfix) with ESMTP id 81C8C8FC0C for ; Fri, 26 Mar 2010 19:14:10 +0000 (UTC) Received: (qmail 22436 invoked by uid 399); 26 Mar 2010 19:14:09 -0000 Received: from localhost (HELO foreign.dougb.net) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 26 Mar 2010 19:14:09 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Message-ID: <4BAD0780.10602@FreeBSD.org> Date: Fri, 26 Mar 2010 12:14:08 -0700 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.9.1.7) Gecko/20100218 Thunderbird/3.0.1 MIME-Version: 1.0 To: freebsd-rc@freebsd.org References: <201003261410.35830.jhb@freebsd.org> In-Reply-To: <201003261410.35830.jhb@freebsd.org> X-Enigmail-Version: 1.0.1 OpenPGP: id=D5B2F0FB Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: mountd and reload X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Mar 2010 19:14:11 -0000 On 03/26/10 11:10, John Baldwin wrote: > FYI, it would be nice if someone could fix it so that /etc/rc.d/mountd reload > works when nfs_server_enable="YES" is set in /etc/rc.conf but > mountd_enable="YES" is not explicitly set. You want to do onereload there, at least that should work. hth, Doug -- ... and that's just a little bit of history repeating. -- Propellerheads Improve the effectiveness of your Internet presence with a domain name makeover! http://SupersetSolutions.com/ From owner-freebsd-rc@FreeBSD.ORG Fri Mar 26 19:45:31 2010 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 647F91065670 for ; Fri, 26 Mar 2010 19:45:31 +0000 (UTC) (envelope-from delphij@gmail.com) Received: from mail-pw0-f54.google.com (mail-pw0-f54.google.com [209.85.160.54]) by mx1.freebsd.org (Postfix) with ESMTP id 3B4668FC17 for ; Fri, 26 Mar 2010 19:45:31 +0000 (UTC) Received: by pwj4 with SMTP id 4so7025601pwj.13 for ; Fri, 26 Mar 2010 12:45:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:received:message-id:subject:from:to:cc:content-type; bh=lNAOeRDA9tKM4+hzT2AogzHNkqVkNYAF/maau5vaV/I=; b=j4ujh4F+cdtMQm0TAejoDJNKN5gIWlBGd9g621/66No70zof84rqYe9sLARkgIeLwy OkTmAIdGzpeyVL5ojLR08wuJEV9s7ZtgjxEhXg5F+zcUy1TonWcz5wjLlfmXQb8pbjP1 U5z6xrBGApmH69gCYziFyitS50nb3cFOVKs/w= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=mS43aJoW6c7IbbiCeo5ss8U43GvxJGlTQOkZabGzjPBqXGXU0AprmZKgjNgNgOgr/P izwQ6gS2ONKF6LHb29rV6fEUiYX8aD2ScpIQC1IE/0Y97RyeBZ76/SEBYhq9jrzNoD91 ZH6B3fHfRwaPCaEi3ezcH7T9XkRK8enmlqQ+U= MIME-Version: 1.0 Received: by 10.140.127.14 with HTTP; Fri, 26 Mar 2010 12:18:00 -0700 (PDT) In-Reply-To: <201003261410.35830.jhb@freebsd.org> References: <201003261410.35830.jhb@freebsd.org> Date: Fri, 26 Mar 2010 12:18:00 -0700 Received: by 10.141.1.6 with SMTP id d6mr1452008rvi.175.1269631080173; Fri, 26 Mar 2010 12:18:00 -0700 (PDT) Message-ID: From: Xin LI To: John Baldwin Content-Type: text/plain; charset=UTF-8 Cc: freebsd-rc@freebsd.org Subject: Re: mountd and reload X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Mar 2010 19:45:31 -0000 On Fri, Mar 26, 2010 at 11:10 AM, John Baldwin wrote: > FYI, it would be nice if someone could fix it so that /etc/rc.d/mountd reload > works when nfs_server_enable="YES" is set in /etc/rc.conf but > mountd_enable="YES" is not explicitly set. How would you think about something like this (hackish, though... I think we should perhaps make a 'rcvars' list): Index: mountd =================================================================== --- mountd (revision 205651) +++ mountd (working copy) @@ -10,7 +10,15 @@ . /etc/rc.subr name="mountd" -rcvar=`set_rcvar` +if ! checkyesno mountd_enable 1>/dev/null 2>&1 ; then + if ! checkyesno nfsd_enable 1>/dev/null 2>&1; then + rcvar=nfs_server_enable + else + rcvar=nfsd_enable + fi +else + rcvar=`set_rcvar` +fi command="/usr/sbin/${name}" pidfile="/var/run/${name}.pid" required_files="/etc/exports" Cheers, -- Xin LI http://www.delphij.net From owner-freebsd-rc@FreeBSD.ORG Fri Mar 26 20:03:46 2010 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B5888106564A for ; Fri, 26 Mar 2010 20:03:46 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 8965D8FC15 for ; Fri, 26 Mar 2010 20:03:46 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 2ED6246B37; Fri, 26 Mar 2010 16:03:46 -0400 (EDT) Received: from jhbbsd.localnet (smtp.hudson-trading.com [209.249.190.9]) by bigwig.baldwin.cx (Postfix) with ESMTPA id 332F68A01F; Fri, 26 Mar 2010 16:03:45 -0400 (EDT) From: John Baldwin To: Xin LI Date: Fri, 26 Mar 2010 15:57:28 -0400 User-Agent: KMail/1.12.1 (FreeBSD/7.3-CBSD-20100217; KDE/4.3.1; amd64; ; ) References: <201003261410.35830.jhb@freebsd.org> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201003261557.28279.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Fri, 26 Mar 2010 16:03:45 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-1.7 required=4.2 tests=AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: freebsd-rc@freebsd.org Subject: Re: mountd and reload X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Mar 2010 20:03:46 -0000 On Friday 26 March 2010 3:18:00 pm Xin LI wrote: > On Fri, Mar 26, 2010 at 11:10 AM, John Baldwin wrote: > > FYI, it would be nice if someone could fix it so that /etc/rc.d/mountd reload > > works when nfs_server_enable="YES" is set in /etc/rc.conf but > > mountd_enable="YES" is not explicitly set. > > How would you think about something like this (hackish, though... I > think we should perhaps make a 'rcvars' list): > > Index: mountd > =================================================================== > --- mountd (revision 205651) > +++ mountd (working copy) > @@ -10,7 +10,15 @@ > . /etc/rc.subr > > name="mountd" > -rcvar=`set_rcvar` > +if ! checkyesno mountd_enable 1>/dev/null 2>&1 ; then > + if ! checkyesno nfsd_enable 1>/dev/null 2>&1; then > + rcvar=nfs_server_enable > + else > + rcvar=nfsd_enable > + fi > +else > + rcvar=`set_rcvar` > +fi > command="/usr/sbin/${name}" > pidfile="/var/run/${name}.pid" > required_files="/etc/exports" Hmm, that might work. I think you can drop the stdio redirection for checkyesno as other parts of this script don't do that when invoking checkyesno. -- John Baldwin From owner-freebsd-rc@FreeBSD.ORG Fri Mar 26 20:06:02 2010 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BA02C106566B; Fri, 26 Mar 2010 20:06:02 +0000 (UTC) (envelope-from delphij@gmail.com) Received: from mail-pw0-f54.google.com (mail-pw0-f54.google.com [209.85.160.54]) by mx1.freebsd.org (Postfix) with ESMTP id 8723A8FC15; Fri, 26 Mar 2010 20:06:02 +0000 (UTC) Received: by pwj4 with SMTP id 4so7047323pwj.13 for ; Fri, 26 Mar 2010 13:06:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:received:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=dvTVga3iPRL+b+tP0jRrfMHP9/iVFijU535XfDKHtnE=; b=gH1NmEkJZhgYb6H+XuqP0uFr9U2xaiKMv9lyt81NmcVYTnveVXj9hFiVVpKkHSsdGR p5dbJsAiGar6tX7xWKfmuD89ybA+MDrSlVe82dGEa71BGoXbosgwHZfQTlqaIT1LFr8D jLNCDlb8mBzq5cAd+V8dD2AdxObS5mKg4djcY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=ph2wYhWVlG2g85Bwoc0PxgNOnjK8redCryCaLaYquAopcuzA/quGK3VwNzTiDO0OXl LIF9w3/C7q1egGHgo/6QkzdJPoWKmIoEkXBG/8w3+GmqXkMQvH8ZTXB2HsRhuWMkvcvh cLmEb7Gux/zJL80x9u2M46auPyXS2KaKzDLpU= MIME-Version: 1.0 Received: by 10.140.127.14 with HTTP; Fri, 26 Mar 2010 13:06:01 -0700 (PDT) In-Reply-To: <201003261557.28279.jhb@freebsd.org> References: <201003261410.35830.jhb@freebsd.org> <201003261557.28279.jhb@freebsd.org> Date: Fri, 26 Mar 2010 13:06:01 -0700 Received: by 10.141.89.4 with SMTP id r4mr1560952rvl.79.1269633961954; Fri, 26 Mar 2010 13:06:01 -0700 (PDT) Message-ID: From: Xin LI To: John Baldwin Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: freebsd-rc@freebsd.org Subject: Re: mountd and reload X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Mar 2010 20:06:02 -0000 On Fri, Mar 26, 2010 at 12:57 PM, John Baldwin wrote: > On Friday 26 March 2010 3:18:00 pm Xin LI wrote: >> On Fri, Mar 26, 2010 at 11:10 AM, John Baldwin wrote: >> > FYI, it would be nice if someone could fix it so that /etc/rc.d/mountd= reload >> > works when nfs_server_enable=3D"YES" is set in /etc/rc.conf but >> > mountd_enable=3D"YES" is not explicitly set. >> >> How would you think about something like this (hackish, though... =C2=A0= I >> think we should perhaps make a 'rcvars' list): >> >> Index: mountd >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> --- mountd =C2=A0 =C2=A0(revision 205651) >> +++ mountd =C2=A0 =C2=A0(working copy) >> @@ -10,7 +10,15 @@ >> =C2=A0. /etc/rc.subr >> >> =C2=A0name=3D"mountd" >> -rcvar=3D`set_rcvar` >> +if ! checkyesno mountd_enable 1>/dev/null 2>&1 ; then >> + =C2=A0 =C2=A0 if ! checkyesno nfsd_enable 1>/dev/null 2>&1; then >> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 rcvar=3Dnfs_server_enable >> + =C2=A0 =C2=A0 else >> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 rcvar=3Dnfsd_enable >> + =C2=A0 =C2=A0 fi >> +else >> + =C2=A0 =C2=A0 rcvar=3D`set_rcvar` >> +fi >> =C2=A0command=3D"/usr/sbin/${name}" >> =C2=A0pidfile=3D"/var/run/${name}.pid" >> =C2=A0required_files=3D"/etc/exports" > > Hmm, that might work. =C2=A0I think you can drop the stdio redirection fo= r > checkyesno as other parts of this script don't do that when invoking > checkyesno. checkyesno would give a warning if the given variable is not being set. I'm thinking another way of doing this, presumably cleaner (by the way why do we use ${name}_enable=3D"YES" instead of ${name}=3D"YES"?) Cheers, --=20 Xin LI http://www.delphij.net From owner-freebsd-rc@FreeBSD.ORG Sat Mar 27 20:18:05 2010 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0508B1065670 for ; Sat, 27 Mar 2010 20:18:05 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.freebsd.org (Postfix) with ESMTP id 9D1E78FC12 for ; Sat, 27 Mar 2010 20:18:04 +0000 (UTC) Received: (qmail 16641 invoked by uid 399); 27 Mar 2010 20:18:03 -0000 Received: from localhost (HELO foreign.dougb.net) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 27 Mar 2010 20:18:03 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Message-ID: <4BAE67FA.6070609@FreeBSD.org> Date: Sat, 27 Mar 2010 13:18:02 -0700 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.9.1.7) Gecko/20100218 Thunderbird/3.0.1 MIME-Version: 1.0 To: Xin LI References: <201003261410.35830.jhb@freebsd.org> In-Reply-To: X-Enigmail-Version: 1.0.1 OpenPGP: id=D5B2F0FB Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: freebsd-rc@freebsd.org, John Baldwin Subject: Re: mountd and reload X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Mar 2010 20:18:05 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: RIPEMD160 On 03/26/10 12:18, Xin LI wrote: > On Fri, Mar 26, 2010 at 11:10 AM, John Baldwin wrote: >> FYI, it would be nice if someone could fix it so that /etc/rc.d/mountd reload >> works when nfs_server_enable="YES" is set in /etc/rc.conf but >> mountd_enable="YES" is not explicitly set. > > How would you think about something like this (hackish, though... I > think we should perhaps make a 'rcvars' list): I am opposed to it. We already have a mechanism for starting things that don't have _enable set. OTOH I agree that there is a more general problem that our rc.d system should be smarter about what dependent services need to be enabled for a given service but that problem should be solved generally. One-off hacks like this will create a lot of drama and confusion that I would really prefer to avoid. Doug > Index: mountd > =================================================================== > --- mountd (revision 205651) > +++ mountd (working copy) > @@ -10,7 +10,15 @@ > . /etc/rc.subr > > name="mountd" > -rcvar=`set_rcvar` > +if ! checkyesno mountd_enable 1>/dev/null 2>&1 ; then > + if ! checkyesno nfsd_enable 1>/dev/null 2>&1; then > + rcvar=nfs_server_enable > + else > + rcvar=nfsd_enable > + fi > +else > + rcvar=`set_rcvar` > +fi > command="/usr/sbin/${name}" > pidfile="/var/run/${name}.pid" > required_files="/etc/exports" > > Cheers, - -- ... and that's just a little bit of history repeating. -- Propellerheads Improve the effectiveness of your Internet presence with a domain name makeover! http://SupersetSolutions.com/ -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEAREDAAYFAkuuZ/oACgkQyIakK9Wy8Pt17ACeJUdrNgHDeJmaKw70LGPhPA1D VVEAn2Fv8i5DX+tO2hvBNnT/0Gn08UFi =qfVe -----END PGP SIGNATURE-----