From owner-freebsd-scsi@FreeBSD.ORG Sun Nov 21 00:54:18 2010 Return-Path: Delivered-To: freebsd-scsi@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7B08B1065670; Sun, 21 Nov 2010 00:54:18 +0000 (UTC) (envelope-from marius@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 511F58FC1C; Sun, 21 Nov 2010 00:54:18 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id oAL0sIkI080985; Sun, 21 Nov 2010 00:54:18 GMT (envelope-from marius@freefall.freebsd.org) Received: (from marius@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id oAL0sItx080981; Sun, 21 Nov 2010 00:54:18 GMT (envelope-from marius) Date: Sun, 21 Nov 2010 00:54:18 GMT Message-Id: <201011210054.oAL0sItx080981@freefall.freebsd.org> To: aboyer@averesystems.com, marius@FreeBSD.org, freebsd-scsi@FreeBSD.org From: marius@FreeBSD.org Cc: Subject: Re: kern/149502: [mpt] Latent buglet in debug print code X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Nov 2010 00:54:18 -0000 Synopsis: [mpt] Latent buglet in debug print code State-Changed-From-To: open->closed State-Changed-By: marius State-Changed-When: Sun Nov 21 00:54:00 UTC 2010 State-Changed-Why: close http://www.freebsd.org/cgi/query-pr.cgi?pr=149502 From owner-freebsd-scsi@FreeBSD.ORG Sun Nov 21 01:00:22 2010 Return-Path: Delivered-To: freebsd-scsi@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7E6331065670 for ; Sun, 21 Nov 2010 01:00:22 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 5388E8FC1D for ; Sun, 21 Nov 2010 01:00:22 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id oAL10L14082039 for ; Sun, 21 Nov 2010 01:00:21 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id oAL10Ltd082016; Sun, 21 Nov 2010 01:00:21 GMT (envelope-from gnats) Date: Sun, 21 Nov 2010 01:00:21 GMT Message-Id: <201011210100.oAL10Ltd082016@freefall.freebsd.org> To: freebsd-scsi@FreeBSD.org From: dfilter@FreeBSD.ORG (dfilter service) Cc: Subject: Re: kern/149502: commit references a PR X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: dfilter service List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Nov 2010 01:00:22 -0000 The following reply was made to PR kern/149502; it has been noted by GNATS. From: dfilter@FreeBSD.ORG (dfilter service) To: bug-followup@FreeBSD.org Cc: Subject: Re: kern/149502: commit references a PR Date: Sun, 21 Nov 2010 00:53:26 +0000 (UTC) Author: marius Date: Sun Nov 21 00:53:19 2010 New Revision: 215602 URL: http://svn.freebsd.org/changeset/base/215602 Log: MFC: r215325 Use the correct variable for determining the verbosity level in mpt_lprtc(). While at it, fix the whitespace of that macro. PR: 149502 Submitted by: Andrew Boyer Modified: stable/8/sys/dev/mpt/mpt.h Directory Properties: stable/8/sys/ (props changed) stable/8/sys/amd64/include/xen/ (props changed) stable/8/sys/cddl/contrib/opensolaris/ (props changed) stable/8/sys/contrib/dev/acpica/ (props changed) stable/8/sys/contrib/pf/ (props changed) stable/8/sys/dev/xen/xenpci/ (props changed) Modified: stable/8/sys/dev/mpt/mpt.h ============================================================================== --- stable/8/sys/dev/mpt/mpt.h Sun Nov 21 00:50:31 2010 (r215601) +++ stable/8/sys/dev/mpt/mpt.h Sun Nov 21 00:53:19 2010 (r215602) @@ -1112,10 +1112,10 @@ do { \ mpt_prt(mpt, __VA_ARGS__); \ } while (0) -#define mpt_lprtc(mpt, level, ...) \ -do { \ - if (level <= (mpt)->debug_level) \ - mpt_prtc(mpt, __VA_ARGS__); \ +#define mpt_lprtc(mpt, level, ...) \ +do { \ + if (level <= (mpt)->verbose) \ + mpt_prtc(mpt, __VA_ARGS__); \ } while (0) #else void mpt_lprt(struct mpt_softc *, int, const char *, ...) _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" From owner-freebsd-scsi@FreeBSD.ORG Sun Nov 21 01:00:26 2010 Return-Path: Delivered-To: freebsd-scsi@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7A7541065674 for ; Sun, 21 Nov 2010 01:00:26 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 4F8868FC16 for ; Sun, 21 Nov 2010 01:00:26 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id oAL10Qg8082943 for ; Sun, 21 Nov 2010 01:00:26 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id oAL10QfQ082916; Sun, 21 Nov 2010 01:00:26 GMT (envelope-from gnats) Date: Sun, 21 Nov 2010 01:00:26 GMT Message-Id: <201011210100.oAL10QfQ082916@freefall.freebsd.org> To: freebsd-scsi@FreeBSD.org From: dfilter@FreeBSD.ORG (dfilter service) Cc: Subject: Re: kern/149502: commit references a PR X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: dfilter service List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Nov 2010 01:00:26 -0000 The following reply was made to PR kern/149502; it has been noted by GNATS. From: dfilter@FreeBSD.ORG (dfilter service) To: bug-followup@FreeBSD.org Cc: Subject: Re: kern/149502: commit references a PR Date: Sun, 21 Nov 2010 00:53:33 +0000 (UTC) Author: marius Date: Sun Nov 21 00:53:27 2010 New Revision: 215603 URL: http://svn.freebsd.org/changeset/base/215603 Log: MFC: r215325 Use the correct variable for determining the verbosity level in mpt_lprtc(). While at it, fix the whitespace of that macro. PR: 149502 Submitted by: Andrew Boyer Modified: stable/7/sys/dev/mpt/mpt.h Directory Properties: stable/7/sys/ (props changed) stable/7/sys/cddl/contrib/opensolaris/ (props changed) stable/7/sys/contrib/dev/acpica/ (props changed) stable/7/sys/contrib/pf/ (props changed) Modified: stable/7/sys/dev/mpt/mpt.h ============================================================================== --- stable/7/sys/dev/mpt/mpt.h Sun Nov 21 00:53:19 2010 (r215602) +++ stable/7/sys/dev/mpt/mpt.h Sun Nov 21 00:53:27 2010 (r215603) @@ -1110,10 +1110,10 @@ do { \ mpt_prt(mpt, __VA_ARGS__); \ } while (0) -#define mpt_lprtc(mpt, level, ...) \ -do { \ - if (level <= (mpt)->debug_level) \ - mpt_prtc(mpt, __VA_ARGS__); \ +#define mpt_lprtc(mpt, level, ...) \ +do { \ + if (level <= (mpt)->verbose) \ + mpt_prtc(mpt, __VA_ARGS__); \ } while (0) #else void mpt_lprt(struct mpt_softc *, int, const char *, ...) _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" From owner-freebsd-scsi@FreeBSD.ORG Sun Nov 21 16:57:10 2010 Return-Path: Delivered-To: freebsd-scsi@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EB285106566C; Sun, 21 Nov 2010 16:57:10 +0000 (UTC) (envelope-from linimon@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id C1A4A8FC1B; Sun, 21 Nov 2010 16:57:10 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id oALGvA54089016; Sun, 21 Nov 2010 16:57:10 GMT (envelope-from linimon@freefall.freebsd.org) Received: (from linimon@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id oALGvAGq089012; Sun, 21 Nov 2010 16:57:10 GMT (envelope-from linimon) Date: Sun, 21 Nov 2010 16:57:10 GMT Message-Id: <201011211657.oALGvAGq089012@freefall.freebsd.org> To: linimon@FreeBSD.org, freebsd-bugs@FreeBSD.org, freebsd-scsi@FreeBSD.org From: linimon@FreeBSD.org Cc: Subject: Re: kern/151564: [ciss] ciss(4) should increase CISS_MAX_LOGICAL to 107 X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Nov 2010 16:57:11 -0000 Old Synopsis: ciss(4) should increase CISS_MAX_LOGICAL to 107 New Synopsis: [ciss] ciss(4) should increase CISS_MAX_LOGICAL to 107 Responsible-Changed-From-To: freebsd-bugs->freebsd-scsi Responsible-Changed-By: linimon Responsible-Changed-When: Sun Nov 21 16:56:34 UTC 2010 Responsible-Changed-Why: Over to maintainer(s). http://www.freebsd.org/cgi/query-pr.cgi?pr=151564 From owner-freebsd-scsi@FreeBSD.ORG Mon Nov 22 11:07:13 2010 Return-Path: Delivered-To: freebsd-scsi@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8C1A0106567A for ; Mon, 22 Nov 2010 11:07:13 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 72D7E8FC2D for ; Mon, 22 Nov 2010 11:07:13 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id oAMB7DNL051838 for ; Mon, 22 Nov 2010 11:07:13 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id oAMB7CPQ051833 for freebsd-scsi@FreeBSD.org; Mon, 22 Nov 2010 11:07:12 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 22 Nov 2010 11:07:12 GMT Message-Id: <201011221107.oAMB7CPQ051833@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: gnats set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-scsi@FreeBSD.org Cc: Subject: Current problem reports assigned to freebsd-scsi@FreeBSD.org X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Nov 2010 11:07:13 -0000 Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). The following is a listing of current problems submitted by FreeBSD users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Tracker Resp. Description -------------------------------------------------------------------------------- o kern/152250 scsi [ciss] [patch] Kernel panic when hw.ciss.expose_hidden o kern/151564 scsi [ciss] ciss(4) should increase CISS_MAX_LOGICAL to 10 o docs/151336 scsi Missing documentation of scsi_ and ata_ functions in c o kern/148083 scsi [aac] Strange device reporting o kern/147704 scsi [mpt] sys/dev/mpt: new chip revision, partially unsupp o kern/146287 scsi [ciss] ciss(4) cannot see more than one SmartArray con o kern/145768 scsi [mpt] can't perform I/O on SAS based SAN disk in freeb o kern/144648 scsi [aac] Strange values of speed and bus width in dmesg o kern/144301 scsi [ciss] [hang] HP proliant server locks when using ciss o kern/142351 scsi [mpt] LSILogic driver performance problems o kern/141934 scsi [cam] [patch] add support for SEAGATE DAT Scopion 130 o kern/134488 scsi [mpt] MPT SCSI driver probes max. 8 LUNs per device o kern/132250 scsi [ciss] ciss driver does not support more then 15 drive o kern/132206 scsi [mpt] system panics on boot when mirroring and 2nd dri o kern/130621 scsi [mpt] tranfer rate is inscrutable slow when use lsi213 o kern/129602 scsi [ahd] ahd(4) gets confused and wedges SCSI bus o kern/128452 scsi [sa] [panic] Accessing SCSI tape drive randomly crashe o kern/128245 scsi [scsi] "inquiry data fails comparison at DV1 step" [re o kern/127927 scsi [isp] isp(4) target driver crashes kernel when set up o kern/127717 scsi [ata] [patch] [request] - support write cache toggling o kern/124667 scsi [amd] [panic] FreeBSD-7 kernel page faults at amd-scsi o kern/123674 scsi [ahc] ahc driver dumping o sparc/121676 scsi [iscsi] iscontrol do not connect iscsi-target on sparc o kern/120487 scsi [sg] scsi_sg incompatible with scanners o kern/120247 scsi [mpt] FreeBSD 6.3 and LSI Logic 1030 = only 3.300MB/s o kern/119668 scsi [cam] [patch] certain errors are too verbose comparing o kern/114597 scsi [sym] System hangs at SCSI bus reset with dual HBAs o kern/110847 scsi [ahd] Tyan U320 onboard problem with more than 3 disks o kern/99954 scsi [ahc] reading from DVD failes on 6.x [regression] o kern/94838 scsi Kernel panic while mounting SD card with lock switch o o kern/92798 scsi [ahc] SCSI problem with timeouts o kern/90282 scsi [sym] SCSI bus resets cause loss of ch device o kern/76178 scsi [ahd] Problem with ahd and large SCSI Raid system o kern/74627 scsi [ahc] [hang] Adaptec 2940U2W Can't boot 5.3 s kern/61165 scsi [panic] kernel page fault after calling cam_send_ccb o kern/60641 scsi [sym] Sporadic SCSI bus resets with 53C810 under load o kern/60598 scsi wire down of scsi devices conflicts with config s kern/57398 scsi [mly] Current fails to install on mly(4) based RAID di o bin/57088 scsi [cam] [patch] for a possible fd leak in libcam.c o kern/52638 scsi [panic] SCSI U320 on SMP server won't run faster than o kern/44587 scsi dev/dpt/dpt.h is missing defines required for DPT_HAND o kern/40895 scsi wierd kernel / device driver bug o kern/39388 scsi ncr/sym drivers fail with 53c810 and more than 256MB m o kern/35234 scsi World access to /dev/pass? (for scanner) requires acce 44 problems total. From owner-freebsd-scsi@FreeBSD.ORG Tue Nov 23 22:53:24 2010 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A45041065675 for ; Tue, 23 Nov 2010 22:53:24 +0000 (UTC) (envelope-from bruce@cran.org.uk) Received: from muon.cran.org.uk (muon.cran.org.uk [IPv6:2a01:348:0:15:5d59:5c40:0:1]) by mx1.freebsd.org (Postfix) with ESMTP id 062C48FC13 for ; Tue, 23 Nov 2010 22:53:24 +0000 (UTC) Received: from muon.cran.org.uk (localhost [127.0.0.1]) by muon.cran.org.uk (Postfix) with ESMTP id 609A4E7224 for ; Tue, 23 Nov 2010 22:53:23 +0000 (GMT) Received: from core.draftnet (client-86-29-107-54.glfd.adsl.virginmedia.com [86.29.107.54]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by muon.cran.org.uk (Postfix) with ESMTPSA for ; Tue, 23 Nov 2010 22:53:22 +0000 (GMT) Date: Tue, 23 Nov 2010 22:52:59 +0000 From: Bruce Cran To: freebsd-scsi@freebsd.org Message-ID: <20101123225259.35bf33e1@core.draftnet> X-Mailer: Claws Mail 3.7.6 (GTK+ 2.22.1; amd64-portbld-freebsd9.0) Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_/efBNnrXszm2vVrBZA8kY52b" Subject: cam patch: reducing logging output for 'normal' failures X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Nov 2010 22:53:24 -0000 --MP_/efBNnrXszm2vVrBZA8kY52b Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline Hi, I came across http://www.freebsd.org/cgi/query-pr.cgi?pr=kern/119668 which contains a patch to reduce the verbosity of output from the cam subsystem. cam has a tendancy to be a bit spammy when it comes across fairly normal situations such as the tray having been left open, or there just not being a disc present. For example: (probe0:umass-sim0:0:0:0): TEST UNIT READY. CDB: 0 0 0 0 0 0 (probe0:umass-sim0:0:0:0): CAM status: SCSI Status Error (probe0:umass-sim0:0:0:0): SCSI status: Check Condition (probe0:umass-sim0:0:0:0): SCSI sense: NOT READY asc:3a,1 (Medium not present - tray closed) cd0 at umass-sim0 bus 0 scbus9 target 0 lun 0 cd0: Removable CD-ROM SCSI-0 device cd0: 40.000MB/s transfers cd0: Attempt to query device size failed: NOT READY, Medium not present - tray closed The first message, "Medium not present - tray closed" is unnecessary since it's repeated a few lines later and can look as though there's a real problem. I've attached an updated patch which adds the the tray open warning too. Any comments? -- Bruce Cran --MP_/efBNnrXszm2vVrBZA8kY52b Content-Type: text/x-patch Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename=cam_nonfatal.diff Index: sys/cam/cam_periph.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- sys/cam/cam_periph.c (revision 215717) +++ sys/cam/cam_periph.c (working copy) @@ -1630,7 +1630,8 @@ } =20 sense_error_done: - if ((err_action & SSQ_PRINT_SENSE) !=3D 0 + if (((err_action & SSQ_PRINT_SENSE) !=3D 0 + || ((err_action & SSQ_PRINT_SENSE_VERBOSE) !=3D 0 && bootverbose)) && (ccb->ccb_h.status & CAM_AUTOSNS_VALID) !=3D 0) cam_error_print(orig_ccb, CAM_ESF_ALL, CAM_EPF_ALL); } Index: sys/cam/scsi/scsi_all.h =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- sys/cam/scsi/scsi_all.h (revision 215717) +++ sys/cam/scsi/scsi_all.h (working copy) @@ -90,6 +90,7 @@ * and text. */ SSQ_PRINT_SENSE =3D 0x0800, + SSQ_PRINT_SENSE_VERBOSE =3D 0x1000, SSQ_MASK =3D 0xff00 } scsi_sense_action_qualifier; =20 @@ -105,6 +106,12 @@ /* Fatal error action, with table specified error code */ #define SS_FATAL SS_FAIL|SSQ_PRINT_SENSE =20 +/* Fatal error action, with table specified error code + * This type of error does not imply malfunction of hardware and + * indicates conditions that can occur in "normal" circumstances + */ +#define SS_FATAL_NORMAL SS_FAIL|SSQ_PRINT_SENSE_VERBOSE + struct scsi_generic { u_int8_t opcode; Index: sys/cam/scsi/scsi_all.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- sys/cam/scsi/scsi_all.c (revision 215717) +++ sys/cam/scsi/scsi_all.c (working copy) @@ -1431,7 +1431,7 @@ { SST(0x27, 0x06, SS_RDEF, /* XXX TBD */ "Conditional write protect") }, /* DTLPWROMAEBKVF */ - { SST(0x28, 0x00, SS_FATAL | ENXIO, + { SST(0x28, 0x00, SS_FATAL_NORMAL | ENXIO, "Not ready to ready change, medium may have changed") }, /* DT WROM B */ { SST(0x28, 0x01, SS_FATAL | ENXIO, @@ -1691,13 +1691,13 @@ { SST(0x39, 0x00, SS_RDEF, "Saving parameters not supported") }, /* DTL WROM BK */ - { SST(0x3A, 0x00, SS_FATAL | ENXIO, + { SST(0x3A, 0x00, SS_FATAL_NORMAL | ENXIO, "Medium not present") }, /* DT WROM BK */ - { SST(0x3A, 0x01, SS_FATAL | ENXIO, + { SST(0x3A, 0x01, SS_FATAL_NORMAL | ENXIO, "Medium not present - tray closed") }, /* DT WROM BK */ - { SST(0x3A, 0x02, SS_FATAL | ENXIO, + { SST(0x3A, 0x02, SS_FATAL_NORMAL | ENXIO, "Medium not present - tray open") }, /* DT WROM B */ { SST(0x3A, 0x03, SS_RDEF, /* XXX TBD */ @@ -2376,7 +2376,7 @@ { SST(0x63, 0x01, SS_FATAL | ENOSPC, "Packet does not fit in available space") }, /* R */ - { SST(0x64, 0x00, SS_FATAL | ENXIO, + { SST(0x64, 0x00, SS_FATAL_NORMAL | ENXIO, "Illegal mode for this track") }, /* R */ { SST(0x64, 0x01, SS_RDEF, --MP_/efBNnrXszm2vVrBZA8kY52b-- From owner-freebsd-scsi@FreeBSD.ORG Wed Nov 24 08:51:02 2010 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C399E106566B for ; Wed, 24 Nov 2010 08:51:02 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-fx0-f54.google.com (mail-fx0-f54.google.com [209.85.161.54]) by mx1.freebsd.org (Postfix) with ESMTP id 50EBC8FC0C for ; Wed, 24 Nov 2010 08:51:01 +0000 (UTC) Received: by fxm19 with SMTP id 19so7319026fxm.13 for ; Wed, 24 Nov 2010 00:51:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=fE9EuXa7Mzj0KNvPhmbNtGGbfFKB8XYUTtUEKBX/Gzw=; b=K1osBPx4mFOGzJH0NiHyPVrQI1xPXS8SqU1UsfqJxVyQI6v7JD+yINPXm0oeze/iu1 GyvPcfWV2zes/Y/UJ3JXIdmJlNZttwpe3rtA4jC2lDvQ3HO3aj+TnvgZw7BvL9wdFEmo rvDa6OWXA6kweCGenz04taipgdg2glYu5rz/w= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:subject :references:in-reply-to:content-type:content-transfer-encoding; b=NIqi/TIz1lAMfH1T/e+cOa6oKsb0LrYiVeiAp0EPCkHDwi3JycAQ7pDt9c51nyXW13 LoCegDsWRsCeTBqsfYd+6GHQIqHsVth7YRIa1+zfuFNc05bvVJqUMryjAadg4MhkBI0r 65dpB6p2G1RwREKftTQpZMqnhEhN3Krbor7EU= Received: by 10.223.74.198 with SMTP id v6mr2146331faj.4.1290588661219; Wed, 24 Nov 2010 00:51:01 -0800 (PST) Received: from mavbook2.mavhome.dp.ua (pc.mavhome.dp.ua [212.86.226.226]) by mx.google.com with ESMTPS id a25sm2096924fak.20.2010.11.24.00.50.57 (version=SSLv3 cipher=RC4-MD5); Wed, 24 Nov 2010 00:51:00 -0800 (PST) Sender: Alexander Motin Message-ID: <4CECD1E5.7080005@FreeBSD.org> Date: Wed, 24 Nov 2010 10:50:45 +0200 From: Alexander Motin User-Agent: Thunderbird 2.0.0.23 (X11/20091212) MIME-Version: 1.0 To: Bruce Cran , freebsd-scsi@freebsd.org References: In-Reply-To: Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit Cc: Subject: Re: cam patch: reducing logging output for 'normal' failures X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Nov 2010 08:51:02 -0000 Bruce Cran wrote: > I came across http://www.freebsd.org/cgi/query-pr.cgi?pr=kern/119668 > which contains a patch to reduce the verbosity of output from the cam > subsystem. cam has a tendancy to be a bit spammy when it > comes across fairly normal situations such as the tray having been left > open, or there just not being a disc present. For example: > > (probe0:umass-sim0:0:0:0): TEST UNIT READY. CDB: 0 0 0 0 0 0 > (probe0:umass-sim0:0:0:0): CAM status: SCSI Status Error > (probe0:umass-sim0:0:0:0): SCSI status: Check Condition > (probe0:umass-sim0:0:0:0): SCSI sense: NOT READY asc:3a,1 (Medium not present - tray closed) > cd0 at umass-sim0 bus 0 scbus9 target 0 lun 0 > cd0: Removable CD-ROM SCSI-0 device > cd0: 40.000MB/s transfers > cd0: Attempt to query device size failed: NOT READY, Medium not present > - tray closed > > The first message, "Medium not present - tray closed" is unnecessary > since it's repeated a few lines later and can look as though > there's a real problem. I've attached an updated patch which adds the > the tray open warning too. > > Any comments? I have feeling that it could depend on consumer: whether it wants kernel should log it's errors or not. For example, it could be reasonable to log errors for kernel drivers not doing it by themselves, such as "ad" or "ada" (another question why they couldn't do it). Same time it is probably impractical to log errors for requests coming from user-level via "pass" driver. -- Alexander Motin From owner-freebsd-scsi@FreeBSD.ORG Wed Nov 24 12:37:09 2010 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 22337106566B for ; Wed, 24 Nov 2010 12:37:09 +0000 (UTC) (envelope-from avg@freebsd.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 689598FC14 for ; Wed, 24 Nov 2010 12:37:07 +0000 (UTC) Received: from odyssey.starpoint.kiev.ua (alpha-e.starpoint.kiev.ua [212.40.38.101]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id OAA11536; Wed, 24 Nov 2010 14:23:09 +0200 (EET) (envelope-from avg@freebsd.org) Message-ID: <4CED03AC.2040106@freebsd.org> Date: Wed, 24 Nov 2010 14:23:08 +0200 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.12) Gecko/20101029 Lightning/1.0b2 Thunderbird/3.1.6 MIME-Version: 1.0 To: Alexander Motin References: <4CECD1E5.7080005@FreeBSD.org> In-Reply-To: <4CECD1E5.7080005@FreeBSD.org> X-Enigmail-Version: 1.1.2 Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit Cc: freebsd-scsi@freebsd.org Subject: Re: cam patch: reducing logging output for 'normal' failures X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Nov 2010 12:37:09 -0000 on 24/11/2010 10:50 Alexander Motin said the following: > Bruce Cran wrote: >> I came across http://www.freebsd.org/cgi/query-pr.cgi?pr=kern/119668 >> which contains a patch to reduce the verbosity of output from the cam >> subsystem. cam has a tendancy to be a bit spammy when it >> comes across fairly normal situations such as the tray having been left >> open, or there just not being a disc present. For example: >> >> (probe0:umass-sim0:0:0:0): TEST UNIT READY. CDB: 0 0 0 0 0 0 >> (probe0:umass-sim0:0:0:0): CAM status: SCSI Status Error >> (probe0:umass-sim0:0:0:0): SCSI status: Check Condition >> (probe0:umass-sim0:0:0:0): SCSI sense: NOT READY asc:3a,1 (Medium not present - tray closed) >> cd0 at umass-sim0 bus 0 scbus9 target 0 lun 0 >> cd0: Removable CD-ROM SCSI-0 device >> cd0: 40.000MB/s transfers >> cd0: Attempt to query device size failed: NOT READY, Medium not present >> - tray closed >> >> The first message, "Medium not present - tray closed" is unnecessary >> since it's repeated a few lines later and can look as though >> there's a real problem. I've attached an updated patch which adds the >> the tray open warning too. >> >> Any comments? > > I have feeling that it could depend on consumer: whether it wants kernel > should log it's errors or not. For example, it could be reasonable to > log errors for kernel drivers not doing it by themselves, such as "ad" > or "ada" (another question why they couldn't do it). Same time it is > probably impractical to log errors for requests coming from user-level > via "pass" driver. So how would kernel know would a consumer wants? I think that kernel should log only the conditions that it knows to be fatal and serious. The rest is up to the consumers. Which, BTW, should have a better picture of what's going and should be able to produce a more meaningful message. I think that Bruce's example above demonstrates this quite good - compare "umass-sim0" messages with "cd0" messages. -- Andriy Gapon From owner-freebsd-scsi@FreeBSD.ORG Wed Nov 24 12:38:38 2010 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 380B4106566B; Wed, 24 Nov 2010 12:38:38 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-fx0-f54.google.com (mail-fx0-f54.google.com [209.85.161.54]) by mx1.freebsd.org (Postfix) with ESMTP id 90CDE8FC19; Wed, 24 Nov 2010 12:38:37 +0000 (UTC) Received: by fxm19 with SMTP id 19so7507326fxm.13 for ; Wed, 24 Nov 2010 04:38:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :x-enigmail-version:content-type:content-transfer-encoding; bh=O8RavS1W6c/vdkTVgojMy/j1kQXNgzQDMNdp+QcULCA=; b=MWpx4m32efXxs9Iv0gseCal5ZB8wGieO7kgfY0tIBURRXM16AOcIvfQs1WCBuwT5BW GZNDXoorbCm+CmWb2NJ7KOj+h9JvvFzg/2AwHYFUI0LuGVmNOhlBSdRj+9TWZuCCwcp1 E4od+gfag+A55nsG0bdJOmX3Y/X+Ygg6WeNwM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:content-type :content-transfer-encoding; b=mcA2EQ8coon8scRUHEF5tfxowA0TfTMXlocBnLhZjaKJhV4KJNfTmFqUdTcKML0EyQ u1bwEHJTvm6uTHfCE79nU3lo2Zyd6QiVDrpEwZUcRZGAPjwpc543DONQseD/mwh1ljUQ 14O40PNTlipX8WT84QdEzE6N1m15SYCHlOqX0= Received: by 10.223.72.207 with SMTP id n15mr6867231faj.46.1290602315647; Wed, 24 Nov 2010 04:38:35 -0800 (PST) Received: from mavbook2.mavhome.dp.ua (pc.mavhome.dp.ua [212.86.226.226]) by mx.google.com with ESMTPS id n6sm1805906faa.28.2010.11.24.04.38.33 (version=SSLv3 cipher=RC4-MD5); Wed, 24 Nov 2010 04:38:34 -0800 (PST) Sender: Alexander Motin Message-ID: <4CED0739.6010207@FreeBSD.org> Date: Wed, 24 Nov 2010 14:38:17 +0200 From: Alexander Motin User-Agent: Thunderbird 2.0.0.23 (X11/20091212) MIME-Version: 1.0 To: Andriy Gapon References: <4CECD1E5.7080005@FreeBSD.org> <4CED03AC.2040106@freebsd.org> In-Reply-To: <4CED03AC.2040106@freebsd.org> X-Enigmail-Version: 0.96.0 Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit Cc: freebsd-scsi@freebsd.org Subject: Re: cam patch: reducing logging output for 'normal' failures X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Nov 2010 12:38:38 -0000 Andriy Gapon wrote: > on 24/11/2010 10:50 Alexander Motin said the following: >> Bruce Cran wrote: >>> I came across http://www.freebsd.org/cgi/query-pr.cgi?pr=kern/119668 >>> which contains a patch to reduce the verbosity of output from the cam >>> subsystem. cam has a tendancy to be a bit spammy when it >>> comes across fairly normal situations such as the tray having been left >>> open, or there just not being a disc present. For example: >>> >>> (probe0:umass-sim0:0:0:0): TEST UNIT READY. CDB: 0 0 0 0 0 0 >>> (probe0:umass-sim0:0:0:0): CAM status: SCSI Status Error >>> (probe0:umass-sim0:0:0:0): SCSI status: Check Condition >>> (probe0:umass-sim0:0:0:0): SCSI sense: NOT READY asc:3a,1 (Medium not present - tray closed) >>> cd0 at umass-sim0 bus 0 scbus9 target 0 lun 0 >>> cd0: Removable CD-ROM SCSI-0 device >>> cd0: 40.000MB/s transfers >>> cd0: Attempt to query device size failed: NOT READY, Medium not present >>> - tray closed >>> >>> The first message, "Medium not present - tray closed" is unnecessary >>> since it's repeated a few lines later and can look as though >>> there's a real problem. I've attached an updated patch which adds the >>> the tray open warning too. >>> >>> Any comments? >> I have feeling that it could depend on consumer: whether it wants kernel >> should log it's errors or not. For example, it could be reasonable to >> log errors for kernel drivers not doing it by themselves, such as "ad" >> or "ada" (another question why they couldn't do it). Same time it is >> probably impractical to log errors for requests coming from user-level >> via "pass" driver. > > So how would kernel know would a consumer wants? > I think that kernel should log only the conditions that it knows to be fatal and > serious. The rest is up to the consumers. Which, BTW, should have a better > picture of what's going and should be able to produce a more meaningful message. Reasonable. The only question is about situations when CAM does some error recovery, visible to consumer only as retries without any details until finally completed. Such cases include: sense fetching, media load waiting, device busy retrying, etc. We may want to add some option to make CAM log these things for debugging purposes. These messages could be somehow integrated with CAM_DEBUG output. I would really like last one to be cleaned/refactored somehow, because last times I tried to read it -- it was real pain. > I think that Bruce's example above demonstrates this quite good - compare > "umass-sim0" messages with "cd0" messages. Sure. -- Alexander Motin From owner-freebsd-scsi@FreeBSD.ORG Fri Nov 26 15:49:17 2010 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 63AF3106566C for ; Fri, 26 Nov 2010 15:49:17 +0000 (UTC) (envelope-from rysto32@gmail.com) Received: from mail-ey0-f182.google.com (mail-ey0-f182.google.com [209.85.215.182]) by mx1.freebsd.org (Postfix) with ESMTP id ECDEC8FC1D for ; Fri, 26 Nov 2010 15:49:16 +0000 (UTC) Received: by eyb7 with SMTP id 7so1034704eyb.13 for ; Fri, 26 Nov 2010 07:49:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:date:message-id :subject:from:to:content-type; bh=sAHCQuwRXJqRMFmiew7QcYRgc+gH3bdf26OjZFs85Eo=; b=ApEV9ISNRDkgl3hA8lpzyZyyLVVnA1OGej44nKbGJ21e8/eNHMBTkDPPfactMw1zy3 eVVXxtMLJ9K4TFvrnVCfDQMxH5tR4XDdIEjYbshQJmVuOKyziN8ojywVmKLfU3dkik3d ZfkqCtszhfqp4vBK+l0dTBQz+LdFX3YoNFgIw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type; b=obAsrKwEnHbeRxBt06H9Xn6mM2910iyK4J+woE2pDwVKqzj9G3F/nIRbAi+CqVbOuy AmB6gMnMBKoS4NYD5wEqFqCafro9QO/LuXAHsRIqbsX7OOv7zIAD3iQvc+EG4vAW/3WF bp4LmqW6SxlijpW7DJs6+jAjvCdaTkjERYuWE= MIME-Version: 1.0 Received: by 10.213.3.68 with SMTP id 4mr2500528ebm.0.1290786555470; Fri, 26 Nov 2010 07:49:15 -0800 (PST) Received: by 10.213.14.138 with HTTP; Fri, 26 Nov 2010 07:49:15 -0800 (PST) Date: Fri, 26 Nov 2010 10:49:15 -0500 Message-ID: From: Ryan Stone To: freebsd-scsi@freebsd.org Content-Type: text/plain; charset=ISO-8859-1 Subject: CAM_XPT_PATH_ID vs. CAM_BUS_WILDCARD X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Nov 2010 15:49:17 -0000 What is the correct procedure for enumerating all CAM busses via XPT_DEV_MATCH? When I asked last October(1) I was told to use CAM_BUS_WILDCARD, but when I committed my patch someone else suggested CAM_XPT_PATH_ID. Which is correct? 1 -- http://lists.freebsd.org/pipermail/freebsd-scsi/2010-October/004580.html 2 -- http://lists.freebsd.org/pipermail/svn-src-head/2010-November/022601.html