From owner-freebsd-current@FreeBSD.ORG Sun Jul 17 01:22:03 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 10E9D106566C for ; Sun, 17 Jul 2011 01:22:03 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id D7F148FC0A for ; Sun, 17 Jul 2011 01:22:02 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 7031A46B29; Sat, 16 Jul 2011 21:22:02 -0400 (EDT) Received: from kavik.baldwin.cx (c-68-36-150-83.hsd1.nj.comcast.net [68.36.150.83]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id EFAB68A02E; Sat, 16 Jul 2011 21:22:01 -0400 (EDT) From: John Baldwin To: freebsd-current@freebsd.org, Ed Schouten Date: Sat, 16 Jul 2011 21:22:00 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.2-RELEASE-p2; KDE/4.5.5; i386; ; ) References: <200909191756.n8JHuQCq031719@svn.freebsd.org> <20090925123911.GP95398@hoeg.nl> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201107162122.00466.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (bigwig.baldwin.cx); Sat, 16 Jul 2011 21:22:02 -0400 (EDT) Cc: Kostik Belousov , Anonymous , Ben Kaduk Subject: Re: [Patch] [regression] libvgl and r197330 (kbd) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Jul 2011 01:22:03 -0000 On Friday, June 17, 2011 08:18:03 pm Ben Kaduk wrote: > On Fri, Sep 25, 2009 at 8:39 AM, Ed Schouten wrote: > > Hi all, > > > > * Kostik Belousov wrote: > >> > Ah, it seems SDL also calls GIO_KEYMAP. Just rebuilding SDL should fix > >> > this. I promised to add a message to UPDATING as well, so I'll also > >> > mention SDL should be rebuilt as well. > >> > >> I consider this as a very strong argument to keep the existing ioctl > >> as is, and provide new ioctl that takes new table. > > > > I've attached a patch that should restore binary compatibility. I first > > thought this wasn't really needed, because most applications would use > > K_RAW instead of K_XLATE anyway. > > > > Just breaking binary compatibility with kbdcontrol(1) wouldn't have been > > too bad, but it turns out things like SDL use this as well. I've > > attached a patch that should restore binary compatibility. Anyone > > interested in testing this before I commit it to SVN? > > Replying to ancient history, it looks like this patch never got > committed? The Debian kFreeBSD folks have run into a similar issue: > http://lists.debian.org/debian-bsd/2011/06/msg00238.html > proposing > =============== > Upstream could do it properly, without ABI breaking, i.e. by > > #define GIO_KEYMAP_OLD _IOR('k', 6, keymap_t) > #define PIO_KEYMAP_OLD _IOW('k', 7, keymap_t) > ... > #define GIO_KEYMAP _IO('k', 16) > #define PIO_KEYMAP _IO('k', 17) > =============== > > Something to keep the ABI between 8 and 9 is probably still useful, > even at this juncture. I just asked the kFreeBSD folks to test Ed's patch and it does restore the ABI. Ed, can you commit this patch as it's been successfully tested now? -- John Baldwin