From owner-freebsd-acpi@FreeBSD.ORG Sun Apr 21 17:17:41 2013 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 37C6E219; Sun, 21 Apr 2013 17:17:41 +0000 (UTC) (envelope-from ben@b1c1l1.com) Received: from lancer.b1c1l1.com (lancer.b1c1l1.com [72.13.86.100]) by mx1.freebsd.org (Postfix) with ESMTP id 225AB1AC5; Sun, 21 Apr 2013 17:17:40 +0000 (UTC) Received: by lancer.b1c1l1.com (Postfix) with ESMTPSA id A76FD5C39; Sun, 21 Apr 2013 10:17:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=b1c1l1.com; s=default; t=1366564653; bh=6IpZnnxLGRy/ZcECriK+Vtz/Y6jU0qCYegGZuByueK8=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=eVZBkyqUKKOeOUh32kDHzIUg5f7Fhy3RjxTogzreToB1Tex07UA79oMuAj7jcgwKO ruosuNpyfuIiEy13tCZ4FHFRxLVNsQnb9YGJI5o6ISwlNxlklZ0fix71YyxN90o4SU boIs3wzlWlVHRAtt7kU3NZXhSzqzsTeSWDrLFBRQ= Date: Sun, 21 Apr 2013 10:17:28 -0700 From: Benjamin Lee To: John Baldwin Subject: Re: panic: acpi_pci_link_srs_from_crs: can't put non-ISA IRQ 20 in legacy IRQ resource type) Message-ID: <20130421101728.6fc33a96@b1c1l1.com> In-Reply-To: <201304200817.15189.jhb@freebsd.org> References: <20130418124940.47e3618a@b1c1l1.com> <201304191726.31089.jhb@freebsd.org> <20130419152110.213c7fbb@b1c1l1.com> <201304200817.15189.jhb@freebsd.org> X-Mailer: Claws Mail 3.9.0 (GTK+ 2.24.17; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/jgm4wesVYDIhurva5x.gei8"; protocol="application/pgp-signature" Cc: freebsd-acpi@freebsd.org X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Apr 2013 17:17:41 -0000 --Sig_/jgm4wesVYDIhurva5x.gei8 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Sat, 20 Apr 2013 08:17:15 -0400, John Baldwin wrote: > On Friday, April 19, 2013 06:21:10 PM Benjamin Lee wrote: > > On Fri, 19 Apr 2013 17:26:31 -0400, John Baldwin wrot= e: > > > On Friday, April 19, 2013 4:18:49 pm Benjamin Lee wrote: > > > > On Fri, 19 Apr 2013 11:31:49 -0400, John Baldwin = =20 > wrote: > > > > > On Thursday, April 18, 2013 3:49:40 pm Benjamin Lee wrote: > > > > > > I have a system that panics on boot with 10-CURRENT and boots w= ith > > > > > > many ACPI error messages and non-functional devices with > > > > > > 9.1-RELEASE. > > > > > >=20 > > > > > > Motherboard is Foxconn C51XEM2AA (NVIDIA nForce 590) desktop bo= ard. > > > >=20 > > > > [...] > > > >=20 > > > > > > Even though 9.1-RELEASE boots successfully, devices such as the > > > > > > ehci USB controller and SATA controller do not work. > > > > >=20 > > > > > Ugh, your BIOS does unexpected things. It uses a _CRS for these = pci > > > > > link devices that uses a "short" IRQ resource, but uses an extend= ed > > > > > IRQ > > >=20 > > > resource in > > >=20 > > > > > _PRS (and expects an extended one in _SRS). We use _CRS as a > > > > > template for > > >=20 > > > the > > >=20 > > > > > resource to build. > > > > >=20 > > > > > Try this patch. It's a bit hackish, but it forces us to not use = _CRS > > > > > as a template if _CRS uses a "short" IRQ resource, but the link > > > > > supports non- > > >=20 > > > ISA > > >=20 > > > > > IRQs. > > > >=20 > > > > [...] > > > >=20 > > > > Thanks, that fixed the panic and the system boots. Now it is > > > > complaining about AE_AML_BAD_RESOURCE_LENGTH and still unable to ro= ute > > > > IRQs, but it definitely looks better than the ACPI parsing errors i= n 9: > > > >=20 > > > > pcib0: allocated type 3 (0xdffff000-0xdfffffff) for rid 10 of > > > > pci0:0:10:0 pcib0: matched entry for 0.10.INTA (src \_SB_.PCI0.AUBA= :0) > > > > pci_link26: Picked IRQ 20 with weight 0 > > > > pci_link26: Unable to route IRQs: AE_AML_BAD_RESOURCE_LENGTH > > > >=20 > > > > Full boot -v output: > > > > http://www.b1c1l1.com/media/debug/20130419-10-patched- > > >=20 > > > boot.txt.gz > > >=20 > > > Can you add some printfs to the places that return the > > > AE_AML_BAD_RESOURCE_LENGTH to see which one is being triggered? (Just > > > look for that constant in sys/contrib/dev/acpica to find the possible > > > places.) > >=20 > > Is there a macro for dumping information about Resource or > > Resource->Data? Here's what I have for now at > > sys/contrib/dev/acpica/resources/rscalc.c line 237: > >=20 > > pcib0: matched entry for 0.10.INTA (src \_SB_.PCI0.AUBA:0) > > pci_link26: Picked IRQ 20 with weight 0 > > rscalc.c:237 > > Resource->Type: 7 > > Resource->Length: 0 > > pci_link26: Unable to route IRQs: AE_AML_BAD_RESOURCE_LENGTH > >=20 > > All of the errors are from there and look identical (Type 7, Length 0). > > Type 7 appears to be ACPI_RESOURCE_TYPE_END_TAG. >=20 > Ah, this is easy to fix then. It seems in sys/dev/acpica/acpi.c in=20 > acpi_AppendBufferResource() we didn't create the end tag correctly. > Can you try this in addition to the patch to acpi_pci_link.c: >=20 > Index: sys/dev/acpica/acpi.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- acpi.c (revision 249195) > +++ acpi.c (working copy) > @@ -2384,7 +2384,7 @@ > /* And add the terminator. */ > rp =3D ACPI_NEXT_RESOURCE(rp); > rp->Type =3D ACPI_RESOURCE_TYPE_END_TAG; > - rp->Length =3D 0; > + rp->Length =3D ACPI_RS_SIZE_MIN; > =20 > return (AE_OK); > } Thank you! I backed out my hacks and with your 2 patches 10-CURRENT boots successfully (with functional devices). Loading a custom ASL is not necessary. --=20 Benjamin Lee http://www.b1c1l1.com/ --Sig_/jgm4wesVYDIhurva5x.gei8 Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iQIcBAEBAgAGBQJRdB8sAAoJEHpz6H1iC6qDpPUQAIUfD5zmVYuWbxWUr4KZBV3I y03DA9UfffN4PQSbOnMTJR/RUAfVMDgOGLJJxFU+wuK0v3Nwr6PoVFUYqMd+Up9T 93BPjUZLU6iOiv5zin+BeBkZbAZk+FHju/0unuNJ9GPJjdyOI9kWPxTBbFn8swhi bj0TRidb33df5eV10YpBVceP8K5e2xANEVPf57/ymsckSmyWt7UTHxYfIXvccCKl 8P0vV6dJEFX/74ep5DF351ljZ8I+4bsaOLPgYlg88vdnge0FqRibmqKvmN5KsZWE +2HO+zF1L2t5d0bScqlUVqYP7Z+c0pHGF1dHy0WS30d9ro1G9GXhUwQikGf/N0Ik dedNbBEbjYTyI2GaOCGN+SbWcWVHMHps+Q3TOfT/7TmTVZAOLckHctPigOShtoNb zTyANfhE6Dol0Ql+bz+hp8gRlb0m7jTvvF7FL0u6IsLuH55tPP5OckGDlCmARkA3 LMCv5rkVxvoos4BCG38NA2gSluzigXT6IAFR6ifl0vov+Bzzg8CRpz2Z/VvmjNcZ z/xWa9RuAx4NUkla0Hc3DcT2b8z6ljYEsk1N3kCxldxlYmc7EBCQYGZcWvp6bABN alecyW8XKCVcltZ6RhZcGj2LanffbY+usYm0Zxchg09lDmDVcUXT0Byh49Xc5PZa cXwxtlWQA9XFVp1Wa5S4 =0HD8 -----END PGP SIGNATURE----- --Sig_/jgm4wesVYDIhurva5x.gei8-- From owner-freebsd-acpi@FreeBSD.ORG Mon Apr 22 11:06:39 2013 Return-Path: Delivered-To: freebsd-acpi@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id D0157500 for ; Mon, 22 Apr 2013 11:06:39 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id A7450105F for ; Mon, 22 Apr 2013 11:06:39 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.6/8.14.6) with ESMTP id r3MB6d36088983 for ; Mon, 22 Apr 2013 11:06:39 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.6/8.14.6/Submit) id r3MB6dKG088981 for freebsd-acpi@FreeBSD.org; Mon, 22 Apr 2013 11:06:39 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 22 Apr 2013 11:06:39 GMT Message-Id: <201304221106.r3MB6dKG088981@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: gnats set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-acpi@FreeBSD.org Subject: Current problem reports assigned to freebsd-acpi@FreeBSD.org X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Apr 2013 11:06:39 -0000 Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). The following is a listing of current problems submitted by FreeBSD users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Tracker Resp. Description -------------------------------------------------------------------------------- o kern/174766 acpi [acpi] Random acpi panic o kern/174504 acpi [ACPI] Suspend/resume broken on Lenovo x220 o kern/171305 acpi [acpi] acpi_tz0: _CRT value is absurd, ignored (256.0C o kern/165381 acpi [cpufreq] powerd(8) eats CPUs for breakfast o kern/164329 acpi [acpi] hw.acpi.thermal.tz0.temperature shows strange v o kern/163268 acpi [acpi_hp] [patch] fix driver detach in absence of CMI o kern/162859 acpi [acpi] ACPI battery/acline monitoring partialy working o kern/161715 acpi [acpi] Dell E6520 doesn't resume after ACPI suspend o kern/161713 acpi [acpi] Suspend on Dell E6520 o kern/160838 acpi [acpi] ACPI Battery Monitor Non-Functional o kern/160419 acpi [acpi_thermal] acpi_thermal kernel thread high CPU usa o kern/158689 acpi [acpi] value of sysctl hw.acpi.thermal.polling_rate ne o kern/154955 acpi [acpi] Keyboard or ACPI doesn't work on Lenovo S10-3 o kern/152438 acpi [acpi]: patch to acpi_asus(4) to add extra sysctls for o kern/152098 acpi [acpi] Lenovo T61p does not resume o i386/146715 acpi [acpi] Suspend works, resume not on a HP Probook 4510s o kern/145306 acpi [acpi]: Can't change brightness on HP ProBook 4510s o i386/143798 acpi [acpi] shutdown problem with SiS K7S5A o kern/143420 acpi [acpi] ACPI issues with Toshiba o kern/142009 acpi [acpi] [panic] Panic in AcpiNsGetAttachedObject o kern/139088 acpi [acpi] ACPI Exception: AE_AML_INFINITE_LOOP error o amd64/138210 acpi [acpi] acer aspire 5536 ACPI problems (S3, brightness, o i386/136008 acpi [acpi] Dell Vostro 1310 will not shutdown (Requires us o kern/132602 acpi [acpi] ACPI Problem with Intel SS4200: System does not o kern/123039 acpi [acpi] ACPI AML_BUFFER_LIMIT errors during boot a i386/122887 acpi [panic] [atkbdc] 7.0-RELEASE on IBM HS20 panics immed s kern/112544 acpi [acpi] [patch] Add High Precision Event Timer Driver f o kern/105537 acpi [acpi] problems in acpi on HP Compaq nc6320 o kern/91594 acpi [acpi] FreeBSD > 5.4 w/ACPI fails to detect Intel Pro/ o kern/73823 acpi [request] acpi / power-on by timer support o kern/56024 acpi ACPI suspend drains battery while in S3 31 problems total. From owner-freebsd-acpi@FreeBSD.ORG Wed Apr 24 16:46:22 2013 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 2CEAE484 for ; Wed, 24 Apr 2013 16:46:22 +0000 (UTC) (envelope-from mdg583@gmail.com) Received: from mail-ob0-x22a.google.com (mail-ob0-x22a.google.com [IPv6:2607:f8b0:4003:c01::22a]) by mx1.freebsd.org (Postfix) with ESMTP id F3F3B1FEB for ; Wed, 24 Apr 2013 16:46:21 +0000 (UTC) Received: by mail-ob0-f170.google.com with SMTP id eh20so1719953obb.1 for ; Wed, 24 Apr 2013 09:46:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:date:message-id:subject:from:to :content-type; bh=tFIAn5AEcTMt4N5klliQNCAcQnsFr4v2U2UEhaXgkxU=; b=rl7FkjXuDbt4Vr4xbqcvC9WueXmrc0QS0PLqaEqxU0lcsxFfYPvgbZ7MCqhtdOqrah yA35Llcol6w1SREznYBOMe8rFahDL4Kw1E59q/AI7W2rCuRcEnYVWCAAQHjdq1JAFsVp iosWq2TZl08rxAeCsZNuH4iqoh8zuLUxMTvb3ft9r+djV9CK0HV9+Z+pu8/vex81puw5 9St8OLDOjOAzWXeLHcStux0kdNabqIBTnk12/9Hn95WarfRpaNGDDXOM/EzLagxDzCzp 3nJLZpP+z2170za2WxPNBumZbjSqud7jBB4jTgIvzMBBWzMvG82ccMouktp/LeHrygzR rw0Q== MIME-Version: 1.0 X-Received: by 10.182.103.225 with SMTP id fz1mr13673954obb.53.1366821981606; Wed, 24 Apr 2013 09:46:21 -0700 (PDT) Received: by 10.182.76.41 with HTTP; Wed, 24 Apr 2013 09:46:21 -0700 (PDT) Date: Wed, 24 Apr 2013 09:46:21 -0700 Message-ID: Subject: Thinkpad x230 acpi_ibm From: Matthew Gibson To: freebsd-acpi@freebsd.org Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Apr 2013 16:46:22 -0000 Hello, I have a thinkpad x230. I have some of the issues others on this mailing list have discussed, such as no brightness controls, and some of the special buttons don't work. I have some experience with freebsd, but not a lot. I am running 9.1-RELEASE (r243825) on amd64. The main issue is similiar to http://lists.freebsd.org/pipermail/freebsd-acpi/2011-July/007227.html If I load the acpi_ibm module, it shows up in kldstat, but no message is given on the dmesg, and nothing appears in sysctl. Any help is appreciated. the volume buttons work, the speaker and microphone mute doesn't work. The brightness fn keys don't work. Also the power button doesn't seem to initiate a shutdown, even though I have hw.acpi.power_button_state: S5 Matthew From owner-freebsd-acpi@FreeBSD.ORG Wed Apr 24 16:59:25 2013 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id CA11FDBA; Wed, 24 Apr 2013 16:59:25 +0000 (UTC) (envelope-from hiren.panchasara@gmail.com) Received: from mail-ee0-f50.google.com (mail-ee0-f50.google.com [74.125.83.50]) by mx1.freebsd.org (Postfix) with ESMTP id 3B94610A8; Wed, 24 Apr 2013 16:59:23 +0000 (UTC) Received: by mail-ee0-f50.google.com with SMTP id e53so889491eek.37 for ; Wed, 24 Apr 2013 09:59:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=ifcM3rIUgFdTLf0URxs2v080pKuQOANy75b/+6sSZ2Y=; b=UxhMkIuoY0jffGhVj1dGagG5vVGKR6k5tbXgdeT7ronmFpzKbLTXQ7zcqQrjQHG0IA viK9N8BkTUHThm3jkkKELraWHjuDhFEqJtpaHQ7xKQ3X12tr2hgoaBnLBP86U3foVa6H aC3jX+5rqB4kGHpMHAtMftreP7Uy8ciOCYWyuru8Jbj+QuMgqOanjFIbCBGI2Ff31AIT 4pqEIfZsPS5y3B92nuc4A4wznM08xSAUUTchG0sFkTrlIRQHetPlF5tj+PsL929eU0Ys 4yqf19GCM1TmaNSU3JnY6oIT7f/YuHnr/AQaZz6BbSN76bcmxEaOyDhER96lfDnCOo4/ Qk6A== MIME-Version: 1.0 X-Received: by 10.14.206.129 with SMTP id l1mr20711269eeo.30.1366822757200; Wed, 24 Apr 2013 09:59:17 -0700 (PDT) Received: by 10.14.204.200 with HTTP; Wed, 24 Apr 2013 09:59:17 -0700 (PDT) In-Reply-To: References: <201304081930.r38JU1Ih054443@freefall.freebsd.org> <201304121142.02419.jhb@freebsd.org> Date: Wed, 24 Apr 2013 09:59:17 -0700 Message-ID: Subject: Re: kern/163268: [acpi_hp] [patch] fix driver detach in absence of CMI From: hiren panchasara To: John Baldwin Content-Type: text/plain; charset=UTF-8 Cc: freebsd-acpi@freebsd.org X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Apr 2013 16:59:25 -0000 On Fri, Apr 12, 2013 at 10:27 AM, hiren panchasara wrote: > On Fri, Apr 12, 2013 at 8:42 AM, John Baldwin wrote: >> >> On Monday, April 08, 2013 3:30:01 pm hiren panchasara wrote: >> > The following reply was made to PR kern/163268; it has been noted by GNATS. >> > >> > From: hiren panchasara >> > To: bug-followup@FreeBSD.org, yuri.pankov@gmail.com >> > Cc: >> > Subject: Re: kern/163268: [acpi_hp] [patch] fix driver detach in absence of >> CMI >> > Date: Mon, 8 Apr 2013 12:29:11 -0700 >> > >> > I do not see any apparent problem in the proposed patch. Unfortunately >> > I do not have an hp to play with. >> > >> > Can someone look at the patch and try or approve so that we can make >> > progress on this? >> >> The current patch would incorrectly remove the notification handler if it >> failed with EBUSY. I'm compiling the following to see if it builds. I also >> think it is a bit less invasive. I have no way to test it however: > > Just got an HP elitebook. I am not sure if it has the same cmi > interface or not to reproduce the problem. I am setting up X and all > at the moment. Once that's done, I can give this patch a try. John, I do not see myself trying this out anytime soon so please go ahead and commit the patch if you think this is the correct way. Do not want to keep you waiting on my testing. cheers, Hiren > > Thanks, > Hiren >> >> Index: dev/acpi_support/acpi_hp.c >> =================================================================== >> --- dev/acpi_support/acpi_hp.c (revision 248326) >> +++ dev/acpi_support/acpi_hp.c (working copy) >> @@ -574,28 +574,26 @@ >> static int >> acpi_hp_detach(device_t dev) >> { >> - int ret; >> + struct acpi_hp_softc *sc; >> >> ACPI_FUNCTION_TRACE((char *)(uintptr_t) __func__); >> - struct acpi_hp_softc *sc = device_get_softc(dev); >> - if (sc->has_cmi && sc->hpcmi_open_pid != 0) { >> - ret = EBUSY; >> - } >> - else { >> - if (sc->has_notify) { >> - ACPI_WMI_REMOVE_EVENT_HANDLER(dev, >> - ACPI_HP_WMI_EVENT_GUID); >> - } >> + sc = device_get_softc(dev); >> + if (sc->has_cmi && sc->hpcmi_open_pid != 0) >> + return (EBUSY); >> + >> + if (sc->has_notify) >> + ACPI_WMI_REMOVE_EVENT_HANDLER(dev, ACPI_HP_WMI_EVENT_GUID); >> + >> + if (sc->has_cmi) { >> if (sc->hpcmi_bufptr != -1) { >> sbuf_delete(&sc->hpcmi_sbuf); >> sc->hpcmi_bufptr = -1; >> } >> sc->hpcmi_open_pid = 0; >> destroy_dev(sc->hpcmi_dev_t); >> - ret = 0; >> } >> >> - return (ret); >> + return (0); >> } >> >> static int >> >> -- >> John Baldwin From owner-freebsd-acpi@FreeBSD.ORG Thu Apr 25 00:11:32 2013 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id F24D164C for ; Thu, 25 Apr 2013 00:11:32 +0000 (UTC) (envelope-from erichsfreebsdlist@alogt.com) Received: from alogt.com (alogt.com [69.36.191.58]) by mx1.freebsd.org (Postfix) with ESMTP id C16F1153B for ; Thu, 25 Apr 2013 00:11:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=alogt.com; s=default; h=Content-Transfer-Encoding:Content-Type:Mime-Version:References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date; bh=fHqx3+zn99vWzy8zxA/L6OUopZWIkRv3owPa7X+lVGA=; b=cJLLYh5jB/d3W4ttkq/OtneqJbbHaSb4Uq7AQnfXgWz8qyJ+sCuqyzDYoydUo185RmLxaN6EnNWsx2p7ZXlEe/8+Jb3tMOSQQ7CaAtwUhqiaWs1AS8da6r4iAkyijI1mHOXZLgQfFrSnFumX/ZnIuvpXm2Q3ENQm1X+7BenVTdA=; Received: from [122.129.203.50] (port=37178 helo=X220.ovitrap.com) by sl-508-2.slc.westdc.net with esmtpsa (SSLv3:DHE-RSA-AES128-SHA:128) (Exim 4.80) (envelope-from ) id 1UV9md-002Kn5-25; Wed, 24 Apr 2013 18:11:32 -0600 Date: Thu, 25 Apr 2013 07:11:27 +0700 From: Erich Dollansky To: Matthew Gibson Subject: Re: Thinkpad x230 acpi_ibm Message-ID: <20130425071127.7aa02e60@X220.ovitrap.com> In-Reply-To: References: X-Mailer: Claws Mail 3.9.0 (GTK+ 2.24.6; amd64-portbld-freebsd10.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - sl-508-2.slc.westdc.net X-AntiAbuse: Original Domain - freebsd.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - alogt.com X-Get-Message-Sender-Via: sl-508-2.slc.westdc.net: authenticated_id: erichsfreebsdlist@alogt.com X-Source: X-Source-Args: X-Source-Dir: Cc: freebsd-acpi@freebsd.org X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Apr 2013 00:11:33 -0000 Hi, On Wed, 24 Apr 2013 09:46:21 -0700 Matthew Gibson wrote: > Hello, > > I have a thinkpad x230. I have some of the issues others on this > mailing list have discussed, such as no brightness controls, and some > of the special buttons don't work. > > I have some experience with freebsd, but not a lot. > > I am running 9.1-RELEASE (r243825) on amd64. > > The main issue is similiar to > http://lists.freebsd.org/pipermail/freebsd-acpi/2011-July/007227.html > If I load the acpi_ibm module, it shows up in kldstat, but no message > is given on the dmesg, and nothing appears in sysctl. > > Any help is appreciated. > > the volume buttons work, the speaker and microphone mute doesn't > work. The brightness fn keys don't work. Also the power button > doesn't seem to initiate a shutdown, even though I have > hw.acpi.power_button_state: S5 > I use the following scripts to help me with this problem on a X220: http://www.alogt.com/freebsd/XonX220 starts X for me and http://www.alogt.com/freebsd/setbrightness is used to adjust brightness. You might have to adjust them as some modules might be already loaded at your machine. These scripts work for me on 10. Erich > Matthew > _______________________________________________ > freebsd-acpi@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-acpi > To unsubscribe, send any mail to > "freebsd-acpi-unsubscribe@freebsd.org" From owner-freebsd-acpi@FreeBSD.ORG Thu Apr 25 02:28:33 2013 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id AA9C871C; Thu, 25 Apr 2013 02:28:33 +0000 (UTC) (envelope-from robert.moore@intel.com) Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by mx1.freebsd.org (Postfix) with ESMTP id 7C3A41A7D; Thu, 25 Apr 2013 02:28:33 +0000 (UTC) Received: from azsmga002.ch.intel.com ([10.2.17.35]) by azsmga101.ch.intel.com with ESMTP; 24 Apr 2013 19:28:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.87,547,1363158000"; d="scan'208";a="231927741" Received: from fmsmsx106.amr.corp.intel.com ([10.19.9.37]) by AZSMGA002.ch.intel.com with ESMTP; 24 Apr 2013 19:28:26 -0700 Received: from fmsmsx153.amr.corp.intel.com ([169.254.9.79]) by FMSMSX106.amr.corp.intel.com ([169.254.6.143]) with mapi id 14.01.0355.002; Wed, 24 Apr 2013 19:28:26 -0700 From: "Moore, Robert" To: Benjamin Lee , John Baldwin Subject: RE: panic: acpi_pci_link_srs_from_crs: can't put non-ISA IRQ 20 in legacy IRQ resource type) Thread-Topic: panic: acpi_pci_link_srs_from_crs: can't put non-ISA IRQ 20 in legacy IRQ resource type) Thread-Index: AQHOPG391d2djyxEFEWgLAw8ZTDWIJjeIoGAgABQL4CAABLrgIAAD0UAgADpmYCAAeY2AIAE2ziA Date: Thu, 25 Apr 2013 02:28:25 +0000 Message-ID: <94F2FBAB4432B54E8AACC7DFDE6C92E36FE43F55@FMSMSX153.amr.corp.intel.com> References: <20130418124940.47e3618a@b1c1l1.com> <201304191726.31089.jhb@freebsd.org> <20130419152110.213c7fbb@b1c1l1.com> <201304200817.15189.jhb@freebsd.org> <20130421101728.6fc33a96@b1c1l1.com> In-Reply-To: <20130421101728.6fc33a96@b1c1l1.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.22.254.138] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "freebsd-acpi@freebsd.org" , "Zheng, Lv" , "Guan, Chao" X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Apr 2013 02:28:33 -0000 > Thank you! I backed out my hacks and with your 2 patches 10-CURRENT boot= s > successfully (with functional devices). Loading a custom ASL is not > necessary. Do you mean that the change of a WORD field to a BYTE field is no longer ne= cessary? If so, I would really like to see the buffer that is being sent to _SRS. Thanks, Bob > -----Original Message----- > From: owner-freebsd-acpi@freebsd.org [mailto:owner-freebsd- > acpi@freebsd.org] On Behalf Of Benjamin Lee > Sent: Sunday, April 21, 2013 10:17 AM > To: John Baldwin > Cc: freebsd-acpi@freebsd.org > Subject: Re: panic: acpi_pci_link_srs_from_crs: can't put non-ISA IRQ 20 > in legacy IRQ resource type) >=20 > On Sat, 20 Apr 2013 08:17:15 -0400, John Baldwin wrote: > > On Friday, April 19, 2013 06:21:10 PM Benjamin Lee wrote: > > > On Fri, 19 Apr 2013 17:26:31 -0400, John Baldwin > wrote: > > > > On Friday, April 19, 2013 4:18:49 pm Benjamin Lee wrote: > > > > > On Fri, 19 Apr 2013 11:31:49 -0400, John Baldwin > > > > > > > wrote: > > > > > > On Thursday, April 18, 2013 3:49:40 pm Benjamin Lee wrote: > > > > > > > I have a system that panics on boot with 10-CURRENT and > > > > > > > boots with many ACPI error messages and non-functional > > > > > > > devices with 9.1-RELEASE. > > > > > > > > > > > > > > Motherboard is Foxconn C51XEM2AA (NVIDIA nForce 590) desktop > board. > > > > > > > > > > [...] > > > > > > > > > > > > Even though 9.1-RELEASE boots successfully, devices such as > > > > > > > the ehci USB controller and SATA controller do not work. > > > > > > > > > > > > Ugh, your BIOS does unexpected things. It uses a _CRS for > > > > > > these pci link devices that uses a "short" IRQ resource, but > > > > > > uses an extended IRQ > > > > > > > > resource in > > > > > > > > > > _PRS (and expects an extended one in _SRS). We use _CRS as a > > > > > > template for > > > > > > > > the > > > > > > > > > > resource to build. > > > > > > > > > > > > Try this patch. It's a bit hackish, but it forces us to not > > > > > > use _CRS as a template if _CRS uses a "short" IRQ resource, > > > > > > but the link supports non- > > > > > > > > ISA > > > > > > > > > > IRQs. > > > > > > > > > > [...] > > > > > > > > > > Thanks, that fixed the panic and the system boots. Now it is > > > > > complaining about AE_AML_BAD_RESOURCE_LENGTH and still unable to > > > > > route IRQs, but it definitely looks better than the ACPI parsing > errors in 9: > > > > > > > > > > pcib0: allocated type 3 (0xdffff000-0xdfffffff) for rid 10 of > > > > > pci0:0:10:0 pcib0: matched entry for 0.10.INTA (src > > > > > \_SB_.PCI0.AUBA:0) > > > > > pci_link26: Picked IRQ 20 with weight 0 > > > > > pci_link26: Unable to route IRQs: AE_AML_BAD_RESOURCE_LENGTH > > > > > > > > > > Full boot -v output: > > > > > http://www.b1c1l1.com/media/debug/20130419-10-patched- > > > > > > > > boot.txt.gz > > > > > > > > Can you add some printfs to the places that return the > > > > AE_AML_BAD_RESOURCE_LENGTH to see which one is being triggered? > > > > (Just look for that constant in sys/contrib/dev/acpica to find the > > > > possible > > > > places.) > > > > > > Is there a macro for dumping information about Resource or > > > Resource->Data? Here's what I have for now at > > > sys/contrib/dev/acpica/resources/rscalc.c line 237: > > > > > > pcib0: matched entry for 0.10.INTA (src \_SB_.PCI0.AUBA:0) > > > pci_link26: Picked IRQ 20 with weight 0 > > > rscalc.c:237 > > > Resource->Type: 7 > > > Resource->Length: 0 > > > pci_link26: Unable to route IRQs: AE_AML_BAD_RESOURCE_LENGTH > > > > > > All of the errors are from there and look identical (Type 7, Length > 0). > > > Type 7 appears to be ACPI_RESOURCE_TYPE_END_TAG. > > > > Ah, this is easy to fix then. It seems in sys/dev/acpica/acpi.c in > > acpi_AppendBufferResource() we didn't create the end tag correctly. > > Can you try this in addition to the patch to acpi_pci_link.c: > > > > Index: sys/dev/acpica/acpi.c > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > --- acpi.c (revision 249195) > > +++ acpi.c (working copy) > > @@ -2384,7 +2384,7 @@ > > /* And add the terminator. */ > > rp =3D ACPI_NEXT_RESOURCE(rp); > > rp->Type =3D ACPI_RESOURCE_TYPE_END_TAG; > > - rp->Length =3D 0; > > + rp->Length =3D ACPI_RS_SIZE_MIN; > > > > return (AE_OK); > > } >=20 > Thank you! I backed out my hacks and with your 2 patches 10-CURRENT boot= s > successfully (with functional devices). Loading a custom ASL is not > necessary. >=20 >=20 > -- > Benjamin Lee > http://www.b1c1l1.com/ From owner-freebsd-acpi@FreeBSD.ORG Thu Apr 25 04:40:40 2013 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 9BE1CC00 for ; Thu, 25 Apr 2013 04:40:40 +0000 (UTC) (envelope-from sendtomatt@gmail.com) Received: from mail-pa0-f53.google.com (mail-pa0-f53.google.com [209.85.220.53]) by mx1.freebsd.org (Postfix) with ESMTP id 79FEF1EB4 for ; Thu, 25 Apr 2013 04:40:40 +0000 (UTC) Received: by mail-pa0-f53.google.com with SMTP id bh4so1613508pad.12 for ; Wed, 24 Apr 2013 21:40:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:message-id:date:from:user-agent:mime-version:to:cc :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=AVNvqMjbJgiSF8jv61jU6VMd629PxmYJaT+7EBDtARc=; b=jsuW904B14L3wSXxI1Mp4aXfqOK8E4c8O0FW9ZF5H6l4+wpI7KLNrLIslRmTnb8ppj 60GN0vbYqcMz0dBnkuPFhbMTG9Cb7SpibC4DBVsFcnyZ9JS9zh89adyboq03amZ6jTUX OD386MIfsCpjeM3d7S++3d3FuMctyTMRNpbZy6QL/uYhQfIEplArfg5UIfoLm2x4QYGZ RE4IfiGKeqIJaKuNdBLnsiP5kGYVF0eWeYcrBSkN/IjgpuABMezS6kFsG+SyI9vJKMAm dQD9Ab1NsJElOGtCnEeRq1COa+o5sUc7xl7onImeT5cQ81NdOtR35qO4jbT2Iszt0jrK /mCA== X-Received: by 10.68.134.36 with SMTP id ph4mr50934489pbb.181.1366864834269; Wed, 24 Apr 2013 21:40:34 -0700 (PDT) Received: from flatline.local (70-36-223-239.dsl.dynamic.sonic.net. [70.36.223.239]) by mx.google.com with ESMTPSA id aj2sm5701593pbc.1.2013.04.24.21.40.32 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 24 Apr 2013 21:40:33 -0700 (PDT) Message-ID: <5178B3B3.4060409@gmail.com> Date: Wed, 24 Apr 2013 21:40:19 -0700 From: matt User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/20130405 Thunderbird/17.0.5 MIME-Version: 1.0 To: Matthew Gibson Subject: Re: Thinkpad x230 acpi_ibm References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: freebsd-acpi@freebsd.org X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Apr 2013 04:40:40 -0000 On 04/24/13 09:46, Matthew Gibson wrote: > Hello, > > I have a thinkpad x230. I have some of the issues others on this mailing > list have discussed, such as no brightness controls, and some of the > special buttons don't work. > > I have some experience with freebsd, but not a lot. > > I am running 9.1-RELEASE (r243825) on amd64. > > The main issue is similiar to > http://lists.freebsd.org/pipermail/freebsd-acpi/2011-July/007227.html > If I load the acpi_ibm module, it shows up in kldstat, but no message is > given on the dmesg, and nothing appears in sysctl. > > Any help is appreciated. > > the volume buttons work, the speaker and microphone mute doesn't work. The > brightness fn keys don't work. Also the power button doesn't seem to > initiate a shutdown, even though I have > hw.acpi.power_button_state: S5 > > Matthew > _______________________________________________ > freebsd-acpi@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-acpi > To unsubscribe, send any mail to "freebsd-acpi-unsubscribe@freebsd.org" > . > Aside from scripts (which work great on X220), we need to figure out what is wrong with Lenovo and what is wrong with acpi_video and get them to meet in the middle. I've had marginal success rewriting acpi_handles for just the brightness methods, but basically Lenovo has some weird acpi locations that don't seem to work, or need a trapdoor we're not doing. Usually one does work, but acpi_video doesn't attach to the working ones. Matt From owner-freebsd-acpi@FreeBSD.ORG Fri Apr 26 14:50:26 2013 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 872C1233 for ; Fri, 26 Apr 2013 14:50:26 +0000 (UTC) (envelope-from sendtomatt@gmail.com) Received: from mail-pb0-x22a.google.com (mail-pb0-x22a.google.com [IPv6:2607:f8b0:400e:c01::22a]) by mx1.freebsd.org (Postfix) with ESMTP id 630311D96 for ; Fri, 26 Apr 2013 14:50:26 +0000 (UTC) Received: by mail-pb0-f42.google.com with SMTP id up7so1175062pbc.29 for ; Fri, 26 Apr 2013 07:50:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:message-id:date:from:user-agent:mime-version:to:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=232FYTXzlgttj/tDj3YAuIzqsNIX6qiqN5S0XFkEaFY=; b=bsJQu2X7hOXPWt0RQz34edY8Pk3ixZKejygWvIP9bxPgqRKHAB5N1zUwrZBNd6ikTz 1FEH5JowY1fOeAC6vEME8x8eCyw9p1ARlErXCRijwhhsxhXC2eML3uxEyMINh6gCteNI at2cHs+lERKKMHgc59nIpm4qyJdXdI3FbIzJF0uz9jmrioDUVKesuQz9FSBSj1/KAKcI UTpfNsAyUFF7nv6EEiuwiR3CRZJ6malQloRpHcyLI+oQiSx8Vjdlzxu64gSDjhUack9b 4lQLamv5nFOTR11jBGSJei6SA3gVPsFXPQY96RyeW1eDTXW0WkvD8xSY3sp8Gz3b98O6 eRCQ== X-Received: by 10.66.163.229 with SMTP id yl5mr31217866pab.104.1366987826172; Fri, 26 Apr 2013 07:50:26 -0700 (PDT) Received: from flatline.local (70-36-223-239.dsl.dynamic.sonic.net. [70.36.223.239]) by mx.google.com with ESMTPSA id dr4sm11990796pbb.19.2013.04.26.07.50.23 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 26 Apr 2013 07:50:25 -0700 (PDT) Message-ID: <517A9421.6010208@gmail.com> Date: Fri, 26 Apr 2013 07:50:09 -0700 From: matt User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/20130405 Thunderbird/17.0.5 MIME-Version: 1.0 To: Matthew Gibson , freebsd-acpi Subject: Re: Thinkpad x230 acpi_ibm References: <5178B3B3.4060409@gmail.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Apr 2013 14:50:26 -0000 On 04/25/13 10:46, Matthew Gibson wrote: > I updated to 9-stable and now the acpi_ibm sysctl tree is created. > Only a few of them seem to work. > There are some that could work but have different handles in the Lenovo ACPI vs IBM. For instance, there are per-interface RFKILLs in the X220 ACPI that aren't really exposed in our acpi ibm, among others (kills for GPS, WWAN, and I think WiMAX). I was hacking on this and the brightness, had to put it down for a moment. I might get a chance to look at some of this stuff later today. The brightness control will not work, as far as I know on Linux their thinkpad acpi driver skips its own brightness controls on these models in favor of ACPI control. So far I was able to make a patch for acpi_video that does work (the wrong way, by using \_SB.PCI0.VID for attach, but making the brightness calls to \_SB.PCI0.PEG.VID) and was testing a patch from John Baldwin to see if I could get acpi_video to attach directly to the PEG device. Matt From owner-freebsd-acpi@FreeBSD.ORG Fri Apr 26 18:40:01 2013 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 0EE9A8A0; Fri, 26 Apr 2013 18:40:01 +0000 (UTC) (envelope-from ben@b1c1l1.com) Received: from lancer.b1c1l1.com (lancer.b1c1l1.com [IPv6:2607:f358:1a:1a:1000::]) by mx1.freebsd.org (Postfix) with ESMTP id E65EE1808; Fri, 26 Apr 2013 18:40:00 +0000 (UTC) Received: by lancer.b1c1l1.com (Postfix) with ESMTPSA id 0A31B5C39; Fri, 26 Apr 2013 11:39:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=b1c1l1.com; s=default; t=1367001594; bh=mjxwRhdfGcfNWvQDTAiii/QQVMNAI1dI0LT7DZXLFyk=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=IK8rbwhmDVMBWcjjw0oBPffbA6Z3xB9zV5dF6qFdpYHqywNFQ9+ilCsWnzd9P0qwI lJZlR1IIWYa21f6vyAg1v8eXnWog+neDXK0aT3BucN1VyPBGw6Xx+p8oxatnPvzvWC ll8amxs+jcueErRAjHrZnxJGtGcZM85lYIlyTJJs= Date: Fri, 26 Apr 2013 11:39:48 -0700 From: Benjamin Lee To: "Moore, Robert" Subject: Re: panic: acpi_pci_link_srs_from_crs: can't put non-ISA IRQ 20 in legacy IRQ resource type) Message-ID: <20130426113948.10b5400e@b1c1l1.com> In-Reply-To: <94F2FBAB4432B54E8AACC7DFDE6C92E36FE43F55@FMSMSX153.amr.corp.intel.com> References: <20130418124940.47e3618a@b1c1l1.com> <201304191726.31089.jhb@freebsd.org> <20130419152110.213c7fbb@b1c1l1.com> <201304200817.15189.jhb@freebsd.org> <20130421101728.6fc33a96@b1c1l1.com> <94F2FBAB4432B54E8AACC7DFDE6C92E36FE43F55@FMSMSX153.amr.corp.intel.com> X-Mailer: Claws Mail 3.9.0 (GTK+ 2.24.17; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/rKA8.UnV9AqC75TlibC4AfP"; protocol="application/pgp-signature" Cc: "freebsd-acpi@freebsd.org" , "Guan, Chao" , "Zheng, Lv" X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Apr 2013 18:40:01 -0000 --Sig_/rKA8.UnV9AqC75TlibC4AfP Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Thu, 25 Apr 2013 02:28:25 +0000, "Moore, Robert" wrote: > > Thank you! I backed out my hacks and with your 2 patches 10-CURRENT bo= ots > > successfully (with functional devices). Loading a custom ASL is not > > necessary. >=20 > Do you mean that the change of a WORD field to a BYTE field is no longer = necessary? >=20 > If so, I would really like to see the buffer that is being sent to _SRS. Yes, the change of WORD to BYTE is not necessary with 10-CURRENT. I don't understand ACPI well enough to answer your followup. All I know is that there is some change in the ACPI parsing behavior between 9-STABLE (which triggers AE_AML_BUFFER_LIMIT in the broken _SRS method) and 10-CURRENT (which used to panic but after jhb's fixes now boots correctly). Could it be possible that _SRS is not being called at all with the new ACPI code? --=20 Benjamin Lee http://www.b1c1l1.com/ --Sig_/rKA8.UnV9AqC75TlibC4AfP Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iQIcBAEBAgAGBQJResn5AAoJEHpz6H1iC6qD3UMP/iU4UADsfi4EDpc9qsbfc1b9 AdsIolPA9EW7HR9ukVvKJwGA66FBD99BNZsV7i41IZAicXU9IwYTzRUGTJX+cbZR uG8egaDut9QPzLN8mlwoanVbyNOwcEmWCacYScbTtkoE2iyfLTzVPZy7uqJU3N3N EZHvz3FJfa5sXQ1FOeMdVW07Uj9LiGR/7YrkTCbjKTB9t0h9IEUPsnmJ5WeUuShW uBhnN9Q/vXw1hydiKzY+q7f9spiFi26UzzpOfdZkVDVtMn//PMJNiORKAytnFVUz s9N9xUJwmSmJP/VwEcNGZ+onqpQuEkYTtkeV97+yk3Ptb+IoKhOssW/xHlR/tUF5 OdzeAcH17bNEzzUzADS1WhnxB5K/utlm/EnpBUGDKJQOI4+gxi/wFZJtt4BEW6Kz 8f/nG9KbQxspGoiZSJ+krJpt9ILomteQ2AQJ7A0B97ncSRpmKxyJ7g4pyoDI0BUd KKjDX/k3iNFnFQCopw/5d3ubUEQeoc0OEBS486YVM2Q23hOZx02wmEW6w3KYelKv 7tIYdg0k0XHHXRUBUujG30RbeUgsq8J2qEyEAYWhyfUG1ShMpBIZM4t1ZS7/M8Kh 7bJuPSl9n5zeuPKadzgbxxevrbawLhrs5lR0Ma6a0Ismg+d4x+OVcyoFItE8o668 3bQQEsg3e3UfGbxiCh5K =n6vJ -----END PGP SIGNATURE----- --Sig_/rKA8.UnV9AqC75TlibC4AfP-- From owner-freebsd-acpi@FreeBSD.ORG Fri Apr 26 19:01:18 2013 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id A7612D01; Fri, 26 Apr 2013 19:01:18 +0000 (UTC) (envelope-from robert.moore@intel.com) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx1.freebsd.org (Postfix) with ESMTP id 5BF5918A4; Fri, 26 Apr 2013 19:01:17 +0000 (UTC) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP; 26 Apr 2013 12:01:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.87,559,1363158000"; d="scan'208";a="324717176" Received: from fmsmsx104.amr.corp.intel.com ([10.19.9.35]) by fmsmga001.fm.intel.com with ESMTP; 26 Apr 2013 11:59:22 -0700 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by FMSMSX104.amr.corp.intel.com (10.19.9.35) with Microsoft SMTP Server (TLS) id 14.1.355.2; Fri, 26 Apr 2013 11:59:22 -0700 Received: from fmsmsx153.amr.corp.intel.com ([169.254.9.79]) by FMSMSX155.amr.corp.intel.com ([169.254.5.136]) with mapi id 14.01.0355.002; Fri, 26 Apr 2013 11:59:20 -0700 From: "Moore, Robert" To: Benjamin Lee Subject: RE: panic: acpi_pci_link_srs_from_crs: can't put non-ISA IRQ 20 in legacy IRQ resource type) Thread-Topic: panic: acpi_pci_link_srs_from_crs: can't put non-ISA IRQ 20 in legacy IRQ resource type) Thread-Index: AQHOPG391d2djyxEFEWgLAw8ZTDWIJjeIoGAgABQL4CAABLrgIAAD0UAgADpmYCAAeY2AIAE2ziAgAMXcQD//4+sMA== Date: Fri, 26 Apr 2013 18:59:20 +0000 Message-ID: <94F2FBAB4432B54E8AACC7DFDE6C92E36FE44F8D@FMSMSX153.amr.corp.intel.com> References: <20130418124940.47e3618a@b1c1l1.com> <201304191726.31089.jhb@freebsd.org> <20130419152110.213c7fbb@b1c1l1.com> <201304200817.15189.jhb@freebsd.org> <20130421101728.6fc33a96@b1c1l1.com> <94F2FBAB4432B54E8AACC7DFDE6C92E36FE43F55@FMSMSX153.amr.corp.intel.com> <20130426113948.10b5400e@b1c1l1.com> In-Reply-To: <20130426113948.10b5400e@b1c1l1.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.22.254.140] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "freebsd-acpi@freebsd.org" , "Guan, Chao" , "Zheng, Lv" X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Apr 2013 19:01:18 -0000 > -----Original Message----- > From: Benjamin Lee [mailto:ben@b1c1l1.com] > Sent: Friday, April 26, 2013 11:40 AM > To: Moore, Robert > Cc: John Baldwin; freebsd-acpi@freebsd.org; Zheng, Lv; Guan, Chao > Subject: Re: panic: acpi_pci_link_srs_from_crs: can't put non-ISA IRQ 20 > in legacy IRQ resource type) >=20 > On Thu, 25 Apr 2013 02:28:25 +0000, "Moore, Robert" > wrote: > > > Thank you! I backed out my hacks and with your 2 patches 10-CURRENT > > > boots successfully (with functional devices). Loading a custom ASL > > > is not necessary. > > > > Do you mean that the change of a WORD field to a BYTE field is no longe= r > necessary? > > > > If so, I would really like to see the buffer that is being sent to _SRS= . >=20 > Yes, the change of WORD to BYTE is not necessary with 10-CURRENT. >=20 > I don't understand ACPI well enough to answer your followup. All I know > is that there is some change in the ACPI parsing behavior between 9-STABL= E > (which triggers AE_AML_BUFFER_LIMIT in the broken _SRS method) and 10- > CURRENT (which used to panic but after jhb's fixes now boots correctly). > Could it be possible that _SRS is not being called at all with the new > ACPI code? >=20 _SRS is called from the driver software, so ACPICA is not involved. It may = be that the resource descriptor is now a little longer and the WORD access = no longer goes beyond the end of the buffer. Still, I'm a bit worried about it anyway. >=20 > -- > Benjamin Lee > http://www.b1c1l1.com/