From owner-freebsd-testing@FreeBSD.ORG Sun Jul 21 13:20:49 2013 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 9F8671E4 for ; Sun, 21 Jul 2013 13:20:49 +0000 (UTC) (envelope-from julio@meroh.net) Received: from mail-lb0-f175.google.com (mail-lb0-f175.google.com [209.85.217.175]) by mx1.freebsd.org (Postfix) with ESMTP id 2A158BCA for ; Sun, 21 Jul 2013 13:20:48 +0000 (UTC) Received: by mail-lb0-f175.google.com with SMTP id r10so4580855lbi.20 for ; Sun, 21 Jul 2013 06:20:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-originating-ip:in-reply-to:references:from:date :message-id:subject:to:cc:content-type:x-gm-message-state; bh=OPeGNUckDI31xLB2kw2NhaH28i9Xetpziq9Ing2uK+Q=; b=K6eHS5OqsQDqwJT1mZ9jVJKs0UrlU6MPRJvnRyuUKm46ZD1Y+KAI4Qwl52prlTuhQz SDXMUsP5eWLeZVItP24LDMfr4X4MrLjxsRW5cf1DTuiaSH+dHGr1b8Ya9wrVp/GBiycm zd7KRhi48x+Ihug9yLP6CL1w/UhHs/ICHTdeUGt5XApAD0SDKIXhc7IX8T0bbbGOKfD9 WqcbrChF1FhpCOANHAKrR6+pI42KmglMtRgvYbt+zKNPXr9KPSMno3RHkJfGpv4BDch/ n2T0qn/gP1p/Z5bAc11tHKZfvqAFPCsBQgBqNDPReo+qUPgv2NQINzkqwv8DUxL9KaAj IBsg== X-Received: by 10.112.42.44 with SMTP id k12mr10569768lbl.63.1374412841433; Sun, 21 Jul 2013 06:20:41 -0700 (PDT) MIME-Version: 1.0 Received: by 10.112.204.7 with HTTP; Sun, 21 Jul 2013 06:20:20 -0700 (PDT) X-Originating-IP: [108.176.158.82] In-Reply-To: References: <20130719200017.GA79155@mastodon.meroh.net> From: Julio Merino Date: Sun, 21 Jul 2013 09:20:20 -0400 Message-ID: Subject: Re: Getting rid of the ATF tools To: Garrett Cooper Content-Type: text/plain; charset=ISO-8859-1 X-Gm-Message-State: ALoCoQmC+vbrPMKZjDLeur/Ws3XVNimAknNWEkr6M85hbrzkuodptdhwZWNXjPnTNyNXK8MQo0yQ Cc: freebsd-testing@freebsd.org, Rui Paulo X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Jul 2013 13:20:49 -0000 On Fri, Jul 19, 2013 at 5:13 PM, Garrett Cooper wrote: > On Fri, Jul 19, 2013 at 2:06 PM, Julio Merino wrote: >> OK. Note, however, that the entries in OptionalObsoleteFiles.inc are >> _outside_ of any MK* conditionals. Is there any case where they'd be >> ignored? (curiosity) > > It's cleanliness and consistency more than anything else as the tools > are being yanked (and I assume aren't coming back ever :D..). Adding > in logic to check for commands seems unnecessary as make does a > reasonable job with this already. Change done. I've also fixed share/man/ to not install some unneeded manual pages and done some more cleanups to my patch. > On the plus side you're getting rid of bmake-isms which will make > moving away from bmake a possibility in the future. I am against the > fact that ATF/Kyua/etc can't easily be backported without the mess > that's involved with converting the src tree over to bmake. It's > already made my life more annoyingly painful than necessary. I don't understand what the issue with bmake is. Neither ATF nor Kyua use make for anything -- and that's the whole point of having a tool that implements the runtime engine for the tests! The only place where bmake is used is in the NetBSD src tree to build the tests... so: unless you want to copy verbatim the bsd.test.mk from NetBSD and the various Makefiles from src/tests/ into FreeBSD, there shouldn't be any issue. FWIW, FreeBSD's and NetBSD's build systems are so different already that attempting to copy Makefiles verbatim isn't gonna work anyway :-/ -- Julio Merino / @jmmv