From owner-freebsd-apache@FreeBSD.ORG Sat Jul 19 15:15:15 2014 Return-Path: Delivered-To: apache@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 84DE75AA; Sat, 19 Jul 2014 15:15:15 +0000 (UTC) Received: from f10.opsec.eu (f10.opsec.eu [IPv6:2001:14f8:200:4::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 61A1023A8; Sat, 19 Jul 2014 15:15:14 +0000 (UTC) Received: from pi by f10.opsec.eu with local (Exim 4.82_1-5b7a7c0-XX (FreeBSD)) (envelope-from ) id 1X8WLs-0009jK-JO; Sat, 19 Jul 2014 17:15:08 +0200 Date: Sat, 19 Jul 2014 17:15:08 +0200 From: Kurt Jaeger To: olli hauer Subject: Re: www/p5-libapreq2: libtool fix, strip libs, pkg-plist followup, p5-fix Message-ID: <20140719151508.GB33102@f10.opsec.eu> References: <20140608081334.GK1427@f10.opsec.eu> <20140608083407.GL1427@f10.opsec.eu> <20140608083636.GM1427@f10.opsec.eu> <20140608085842.GO1427@f10.opsec.eu> <53945E98.3080408@gmx.de> <20140610094949.GY3484@f10.opsec.eu> <539752DE.5060208@gmx.de> MIME-Version: 1.0 In-Reply-To: <539752DE.5060208@gmx.de> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Content-Filtered-By: Mailman/MimeDel 2.1.18 Cc: Frederic Culot , skv@FreeBSD.org, apache@freebsd.org, Kurt Jaeger X-BeenThere: freebsd-apache@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Support of apache-related ports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Jul 2014 15:15:15 -0000 Hello, > > Back to my proposed change for www/libapreq2 and this question: > > > >>> Would it be more useful to make the slave port (p5-libapreq2) > >>> a seperate port depending on the other ? > > > > Looking at the pkg-plist and Makefile mess: Is it really useful > > to have this master/slave port or should I split and depend on libapreq2 ? Attached are two diffs for both ports that seperate them. > running a short grep over the tree shows there are only two libapreq2 consumers > - www/mod_amazon_proxy > - www/p5-libapreq2 > > but eleven p5-libapreq consumers > - net-mgmt/netdisco > - net-mgmt/netdot > - www/foswiki-ModPerlEngineContrib > - www/p5-Apache-Gallery > - www/p5-Apache2-SiteControl > - www/p5-CGI-Application-Plugin-Apache > - www/p5-HTML-Mason > - www/p5-Maypole > - www/rt38 > - www/rt40.cpan > - www/rt42.cpan I ran a bulk poudriere run with this: www/mod_amazon_proxy net-mgmt/netdisco net-mgmt/netdot www/foswiki-ModPerlEngineContrib www/p5-Apache-Gallery www/p5-Apache2-SiteControl www/p5-CGI-Application-Plugin-Apache www/p5-HTML-Mason www/p5-Maypole www/rt38 www/rt40 www/rt42 and DEFAULT_VERSIONS=perl5=5.20 apache=2.2 without problems on 10amd64 and 91amd64. Attached are the two diffs, please comment, and if it's OK, please approve. I'll also update 191161 for testing. -- pi@FreeBSD.org +49 171 3101372 6 years to go ! From owner-freebsd-apache@FreeBSD.ORG Sat Jul 19 16:07:47 2014 Return-Path: Delivered-To: apache@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 31A84CF5 for ; Sat, 19 Jul 2014 16:07:47 +0000 (UTC) Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mout.gmx.net", Issuer "TeleSec ServerPass DE-1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BEC332750 for ; Sat, 19 Jul 2014 16:07:46 +0000 (UTC) Received: from [192.168.0.100] ([87.139.233.65]) by mail.gmx.com (mrgmx001) with ESMTPSA (Nemesis) id 0LomuB-1Wb7120nmt-00goEM; Sat, 19 Jul 2014 18:02:23 +0200 Message-ID: <53CA9694.4040409@gmx.de> Date: Sat, 19 Jul 2014 18:02:28 +0200 From: olli hauer User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Kurt Jaeger Subject: Re: www/p5-libapreq2: libtool fix, strip libs, pkg-plist followup, p5-fix References: <20140608081334.GK1427@f10.opsec.eu> <20140608083407.GL1427@f10.opsec.eu> <20140608083636.GM1427@f10.opsec.eu> <20140608085842.GO1427@f10.opsec.eu> <53945E98.3080408@gmx.de> <20140610094949.GY3484@f10.opsec.eu> <539752DE.5060208@gmx.de> <20140719151508.GB33102@f10.opsec.eu> In-Reply-To: <20140719151508.GB33102@f10.opsec.eu> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:wadKBNUD4/wxikfj4gjmWQrvuuGfYLEWJKBtDgFWK2MYmo8+Mr3 j8G0AUsTkqKw1yexBVizy7igCondix7wer+MyCR9z3M1wFH9NhzAdIPuEVmOHa1ToMUOmbh Lu1eVORGBO5heGXxL+aJBvMJHyOd7aHVuxhJ+TJZp17HnUyBfTEdltHDiqgcSwJb4HbU+dO KqW+9hnl01ikTcJEYcg4Q== Cc: Frederic Culot , apache@freebsd.org, skv@FreeBSD.org X-BeenThere: freebsd-apache@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Support of apache-related ports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Jul 2014 16:07:47 -0000 On 2014-07-19 17:15, Kurt Jaeger wrote: > Hello, > >>> Back to my proposed change for www/libapreq2 and this question: >>> >>>>> Would it be more useful to make the slave port (p5-libapreq2) >>>>> a seperate port depending on the other ? >>> >>> Looking at the pkg-plist and Makefile mess: Is it really useful >>> to have this master/slave port or should I split and depend on libapreq2 ? > > Attached are two diffs for both ports that seperate them. > >> running a short grep over the tree shows there are only two libapreq2 consumers >> - www/mod_amazon_proxy >> - www/p5-libapreq2 >> >> but eleven p5-libapreq consumers >> - net-mgmt/netdisco >> - net-mgmt/netdot >> - www/foswiki-ModPerlEngineContrib >> - www/p5-Apache-Gallery >> - www/p5-Apache2-SiteControl >> - www/p5-CGI-Application-Plugin-Apache >> - www/p5-HTML-Mason >> - www/p5-Maypole >> - www/rt38 >> - www/rt40.cpan >> - www/rt42.cpan > > I ran a bulk poudriere run with this: > > www/mod_amazon_proxy > net-mgmt/netdisco > net-mgmt/netdot > www/foswiki-ModPerlEngineContrib > www/p5-Apache-Gallery > www/p5-Apache2-SiteControl > www/p5-CGI-Application-Plugin-Apache > www/p5-HTML-Mason > www/p5-Maypole > www/rt38 > www/rt40 > www/rt42 > > and DEFAULT_VERSIONS=perl5=5.20 apache=2.2 > > without problems on 10amd64 and 91amd64. > > Attached are the two diffs, please comment, and if it's OK, please > approve. > > I'll also update 191161 for testing. > Hi Kurt, seems some files are missing in the p5-libapreq2.diff >From the p5-libapreq2.diff Only in p5-libapreq2: distinfo Only in p5-libapreq2: files Only in p5-libapreq2: pkg-descr Only in p5-libapreq2: pkg-plist Can you shape a svn diff? $ mkdir fix_libapreq $ cd fix_libapreq $ svn checkout --depth empty svn+ssh://svn.freebsd.org/ports/head ports $ cd ports $ svn up --set-depth empty www $ svn up www/libapreq2 www/p5-libapreq2 # apply your patches $ svn diff > my.diff If your test build was OK feel free to commit your patches. -- olli From owner-freebsd-apache@FreeBSD.ORG Sat Jul 19 16:11:18 2014 Return-Path: Delivered-To: apache@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 1CEA8F14; Sat, 19 Jul 2014 16:11:18 +0000 (UTC) Received: from f10.opsec.eu (f10.opsec.eu [IPv6:2001:14f8:200:4::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 904C727FD; Sat, 19 Jul 2014 16:11:17 +0000 (UTC) Received: from pi by f10.opsec.eu with local (Exim 4.82_1-5b7a7c0-XX (FreeBSD)) (envelope-from ) id 1X8XE9-000MYd-0K; Sat, 19 Jul 2014 18:11:13 +0200 Date: Sat, 19 Jul 2014 18:11:12 +0200 From: Kurt Jaeger To: olli hauer Subject: Re: www/p5-libapreq2: libtool fix, strip libs, pkg-plist followup, p5-fix Message-ID: <20140719161112.GD33102@f10.opsec.eu> References: <20140608081334.GK1427@f10.opsec.eu> <20140608083407.GL1427@f10.opsec.eu> <20140608083636.GM1427@f10.opsec.eu> <20140608085842.GO1427@f10.opsec.eu> <53945E98.3080408@gmx.de> <20140610094949.GY3484@f10.opsec.eu> <539752DE.5060208@gmx.de> <20140719151508.GB33102@f10.opsec.eu> <53CA9694.4040409@gmx.de> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="adJ1OR3c6QgCpb/j" Content-Disposition: inline In-Reply-To: <53CA9694.4040409@gmx.de> Cc: Frederic Culot , skv@FreeBSD.org, apache@freebsd.org, Kurt Jaeger X-BeenThere: freebsd-apache@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Support of apache-related ports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Jul 2014 16:11:18 -0000 --adJ1OR3c6QgCpb/j Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi! > seems some files are missing in the p5-libapreq2.diff Ups, yes! Attached. > If your test build was OK feel free to commit your patches. Ok, will do. -- pi@FreeBSD.org +49 171 3101372 6 years to go ! --adJ1OR3c6QgCpb/j Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="libapreq2.svndiff" Index: Makefile =================================================================== --- Makefile (revision 362263) +++ Makefile (working copy) @@ -3,7 +3,7 @@ PORTNAME= libapreq2 PORTVERSION= 2.13 -PORTREVISION= 3 +PORTREVISION= 4 CATEGORIES= www devel MASTER_SITES= ${MASTER_SITE_APACHE_HTTPD} MASTER_SITE_SUBDIR=libapreq @@ -19,28 +19,11 @@ USE_AUTOTOOLS= autoconf CONFIGURE_ARGS+= --with-apache2-apxs=${APXS} --with-expat=${LOCALBASE} -MAKE_ENV+= MAKE=${MAKE_CMD} ## MakeMaker blows it without this +SHLIB_MAJOR= 11 +PLIST_SUB= SHLIB_MAJOR="${SHLIB_MAJOR}" -# www/p5-libapreq2 -.if defined (WITH_MODPERL2) -PLIST_SUB+= WITH_MODPERL2="" -PKGNAMEPREFIX= p5- -USES+= perl5 +post-stage: + ${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/libapreq2.so.3.8.0 + ${STRIP_CMD} ${STAGEDIR}${PREFIX}/libexec/apache22/mod_apreq2.so -P5_APREQ_DEPENDS+= ${APACHE_PKGNAMEPREFIX}mod_perl2>=0:${PORTSDIR}/www/mod_perl2 \ - p5-ExtUtils-XSBuilder>=0:${PORTSDIR}/devel/p5-ExtUtils-XSBuilder \ - p5-Parse-RecDescent>=0:${PORTSDIR}/devel/p5-Parse-RecDescent - -BUILD_DEPENDS+= ${P5_APREQ_DEPENDS} -RUN_DEPENDS+= ${P5_APREQ_DEPENDS} - -CONFIGURE_ARGS+= --enable-perl-glue --with-perl=${PERL5} - -post-patch: - @${REINPLACE_CMD} -i '' -e "s!%%APACHEINCLUDEDIR%%!${APACHEINCLUDEDIR}!" \ - ${WRKSRC}/glue/perl/Makefile.PL -.else -PLIST_SUB+= WITH_MODPERL2="@comment " -.endif - .include Index: pkg-plist =================================================================== --- pkg-plist (revision 362263) +++ pkg-plist (working copy) @@ -12,58 +12,8 @@ lib/libapreq2.so lib/libapreq2.so.3 lib/libapreq2.so.3.8.0 -%%WITH_MODPERL2%%%%PERL5_MAN3%%/APR::Request.3.gz -%%WITH_MODPERL2%%%%PERL5_MAN3%%/APR::Request::Apache2.3.gz -%%WITH_MODPERL2%%%%PERL5_MAN3%%/APR::Request::CGI.3.gz -%%WITH_MODPERL2%%%%PERL5_MAN3%%/APR::Request::Cookie.3.gz -%%WITH_MODPERL2%%%%PERL5_MAN3%%/APR::Request::Error.3.gz -%%WITH_MODPERL2%%%%PERL5_MAN3%%/APR::Request::Hook.3.gz -%%WITH_MODPERL2%%%%PERL5_MAN3%%/APR::Request::Param.3.gz -%%WITH_MODPERL2%%%%PERL5_MAN3%%/APR::Request::Parser.3.gz -%%WITH_MODPERL2%%%%PERL5_MAN3%%/Apache2::Cookie.3.gz -%%WITH_MODPERL2%%%%PERL5_MAN3%%/Apache2::Request.3.gz -%%WITH_MODPERL2%%%%PERL5_MAN3%%/Apache2::Upload.3.gz -%%WITH_MODPERL2%%%%SITE_PERL%%/%%PERL_ARCH%%/APR/Request.pm -%%WITH_MODPERL2%%%%SITE_PERL%%/%%PERL_ARCH%%/APR/Request.pod -%%WITH_MODPERL2%%%%SITE_PERL%%/%%PERL_ARCH%%/APR/Request/Apache2.pm -%%WITH_MODPERL2%%%%SITE_PERL%%/%%PERL_ARCH%%/APR/Request/Apache2.pod -%%WITH_MODPERL2%%%%SITE_PERL%%/%%PERL_ARCH%%/APR/Request/CGI.pm -%%WITH_MODPERL2%%%%SITE_PERL%%/%%PERL_ARCH%%/APR/Request/CGI.pod -%%WITH_MODPERL2%%%%SITE_PERL%%/%%PERL_ARCH%%/APR/Request/Cookie.pm -%%WITH_MODPERL2%%%%SITE_PERL%%/%%PERL_ARCH%%/APR/Request/Cookie.pod -%%WITH_MODPERL2%%%%SITE_PERL%%/%%PERL_ARCH%%/APR/Request/Error.pm -%%WITH_MODPERL2%%%%SITE_PERL%%/%%PERL_ARCH%%/APR/Request/Error.pod -%%WITH_MODPERL2%%%%SITE_PERL%%/%%PERL_ARCH%%/APR/Request/Hook.pm -%%WITH_MODPERL2%%%%SITE_PERL%%/%%PERL_ARCH%%/APR/Request/Hook.pod -%%WITH_MODPERL2%%%%SITE_PERL%%/%%PERL_ARCH%%/APR/Request/Param.pm -%%WITH_MODPERL2%%%%SITE_PERL%%/%%PERL_ARCH%%/APR/Request/Param.pod -%%WITH_MODPERL2%%%%SITE_PERL%%/%%PERL_ARCH%%/APR/Request/Parser.pm -%%WITH_MODPERL2%%%%SITE_PERL%%/%%PERL_ARCH%%/APR/Request/Parser.pod -%%WITH_MODPERL2%%%%SITE_PERL%%/%%PERL_ARCH%%/Apache2/Cookie.pm -%%WITH_MODPERL2%%%%SITE_PERL%%/%%PERL_ARCH%%/Apache2/Request.pm -%%WITH_MODPERL2%%%%SITE_PERL%%/%%PERL_ARCH%%/Apache2/Upload.pm -%%WITH_MODPERL2%%%%SITE_PERL%%/%%PERL_ARCH%%/auto/APR/Request/Apache2/Apache2.so -%%WITH_MODPERL2%%%%SITE_PERL%%/%%PERL_ARCH%%/auto/APR/Request/CGI/CGI.so -%%WITH_MODPERL2%%%%SITE_PERL%%/%%PERL_ARCH%%/auto/APR/Request/Cookie/Cookie.so -%%WITH_MODPERL2%%%%SITE_PERL%%/%%PERL_ARCH%%/auto/APR/Request/Error/Error.so -%%WITH_MODPERL2%%%%SITE_PERL%%/%%PERL_ARCH%%/auto/APR/Request/Hook/Hook.so -%%WITH_MODPERL2%%%%SITE_PERL%%/%%PERL_ARCH%%/auto/APR/Request/Param/Param.so -%%WITH_MODPERL2%%%%SITE_PERL%%/%%PERL_ARCH%%/auto/APR/Request/Parser/Parser.so -%%WITH_MODPERL2%%%%SITE_PERL%%/%%PERL_ARCH%%/auto/APR/Request/Request.so %%APACHEMODDIR%%/mod_apreq2.a %%APACHEMODDIR%%/mod_apreq2.so -%%WITH_MODPERL2%%@dirrm %%SITE_PERL%%/%%PERL_ARCH%%/auto/libapreq2 -%%WITH_MODPERL2%%@dirrmtry %%SITE_PERL%%/%%PERL_ARCH%%/auto/APR/Request/Parser -%%WITH_MODPERL2%%@dirrmtry %%SITE_PERL%%/%%PERL_ARCH%%/auto/APR/Request/Param -%%WITH_MODPERL2%%@dirrmtry %%SITE_PERL%%/%%PERL_ARCH%%/auto/APR/Request/Hook -%%WITH_MODPERL2%%@dirrmtry %%SITE_PERL%%/%%PERL_ARCH%%/auto/APR/Request/Error -%%WITH_MODPERL2%%@dirrmtry %%SITE_PERL%%/%%PERL_ARCH%%/auto/APR/Request/Cookie -%%WITH_MODPERL2%%@dirrmtry %%SITE_PERL%%/%%PERL_ARCH%%/auto/APR/Request/CGI -%%WITH_MODPERL2%%@dirrmtry %%SITE_PERL%%/%%PERL_ARCH%%/auto/APR/Request/Apache2 -%%WITH_MODPERL2%%@dirrmtry %%SITE_PERL%%/%%PERL_ARCH%%/auto/APR/Request -%%WITH_MODPERL2%%@dirrmtry %%SITE_PERL%%/%%PERL_ARCH%%/Apache2 -%%WITH_MODPERL2%%@dirrmtry %%SITE_PERL%%/%%PERL_ARCH%%/APR/Request -%%WITH_MODPERL2%%@dirrmtry %%SITE_PERL%%/%%PERL_ARCH%%/APR @dirrm include/apreq2 @dirrm %%APACHEINCLUDEDIR%%/apreq2 @dirrmtry %%APACHEINCLUDEDIR%% --adJ1OR3c6QgCpb/j Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="p5-libapreq2.svndiff" Index: Makefile =================================================================== --- Makefile (revision 362263) +++ Makefile (working copy) @@ -1,14 +1,52 @@ -# Created by: Autrijus Tang # $FreeBSD$ +PORTNAME= libapreq2 +PORTVERSION= 2.13 +PORTREVISION= 4 CATEGORIES= www perl5 devel +MASTER_SITES= ${MASTER_SITE_APACHE_HTTPD} +MASTER_SITE_SUBDIR=libapreq +DISTFILE= libapreq2-${PORTVERSION} +PKGNAMEPREFIX= p5- MAINTAINER= skv@FreeBSD.org -COMMENT= Generic Apache2 Request Library with perl binding +COMMENT= Perl binding for the Generic Apache2 Request Library -MASTERDIR= ${.CURDIR}/../libapreq2 +LICENSE= APACHE20 -WITH_MODPERL2= yes -MAKE_ENV+= MAKE=${MAKE_CMD} ## MakeMaker blows it without this +USES= gmake libtool perl5 +USE_APACHE= 22+ +USE_PERL5= fixpacklist +USE_LDCONFIG= yes +USE_AUTOTOOLS= autoconf +CONFIGURE_ARGS+= --with-apache2-apxs=${APXS} \ + --with-expat=${LOCALBASE} \ + --enable-perl-glue --with-perl=${PERL5} -.include "${MASTERDIR}/Makefile" +MAKE_ENV+= MAKE=${GMAKE} ## MakeMaker blows it without this + +BUILD_DEPENDS+= libapreq2>0:${PORTSDIR}/www/libapreq2 \ + ${APACHE_PKGNAMEPREFIX}mod_perl2>=0:${PORTSDIR}/www/mod_perl2 \ + p5-ExtUtils-XSBuilder>=0:${PORTSDIR}/devel/p5-ExtUtils-XSBuilder \ + p5-Parse-RecDescent>=0:${PORTSDIR}/devel/p5-Parse-RecDescent + +RUN_DEPENDS+= ${BUILD_DEPENDS} + +post-patch: + @${REINPLACE_CMD} -i '' -e "s!%%APACHEINCLUDEDIR%%!${APACHEINCLUDEDIR}!" \ + ${WRKSRC}/glue/perl/Makefile.PL +post-stage: + # remove all the non-perl stuff + ${RM} ${STAGEDIR}${PREFIX}/bin/apreq2-config + ${RM} -rf ${STAGEDIR}${PREFIX}/include/apreq2 + ${RM} ${STAGEDIR}${PREFIX}/include/apache22/apreq2/apreq_module_apache2.h + ${RM} ${STAGEDIR}${PREFIX}/lib/libapreq2* + ${RM} ${STAGEDIR}${PREFIX}/libexec/apache22/mod_apreq2* + ${FIND} ${STAGEDIR} -name '*.bs' -type f -size 0c -exec ${RM} {} \; + ${STRIP_CMD} ${STAGEDIR}${PREFIX}/${SITE_PERL_REL}/mach/auto/APR/Request/Request.so +.for i in Apache2 CGI Cookie Error Hook Param Parser + ${STRIP_CMD} \ + ${STAGEDIR}${PREFIX}/${SITE_PERL_REL}/mach/auto/APR/Request/${i}/${i}.so +.endfor + +.include Index: distinfo =================================================================== --- distinfo (revision 0) +++ distinfo (working copy) @@ -0,0 +1,2 @@ +SHA256 (libapreq2-2.13.tar.gz) = 5731e6833b32d88e4a5c690e45ddf20fcf969ce3da666c5627d775e92da0cf6e +SIZE (libapreq2-2.13.tar.gz) = 891320 Property changes on: distinfo ___________________________________________________________________ Added: svn:mime-type ## -0,0 +1 ## +text/plain \ No newline at end of property Added: fbsd:nokeywords ## -0,0 +1 ## +yes \ No newline at end of property Added: svn:eol-style ## -0,0 +1 ## +native \ No newline at end of property Index: files/patch-glue-Makefile.in =================================================================== --- files/patch-glue-Makefile.in (revision 0) +++ files/patch-glue-Makefile.in (working copy) @@ -0,0 +1,11 @@ +--- ./glue/Makefile.in.orig 2009-04-13 06:32:19.000000000 +0000 ++++ ./glue/Makefile.in 2009-04-13 06:32:29.000000000 +0000 +@@ -266,7 +266,7 @@ + + perl_install: + cd perl; INSTALL=1 @PERL@ @PERL_OPTS@ Makefile.PL -apxs @APACHE2_APXS@ @MM_OPTS@ +- cd perl; $(MAKE) install ++ cd perl; $(MAKE) pure_install + + perl_clean: + -cd perl; $(MAKE) clean Property changes on: files/patch-glue-Makefile.in ___________________________________________________________________ Added: svn:mime-type ## -0,0 +1 ## +text/plain \ No newline at end of property Added: fbsd:nokeywords ## -0,0 +1 ## +yes \ No newline at end of property Added: svn:eol-style ## -0,0 +1 ## +native \ No newline at end of property Index: files/patch-glue-perl-Makefile.PL =================================================================== --- files/patch-glue-perl-Makefile.PL (revision 0) +++ files/patch-glue-perl-Makefile.PL (working copy) @@ -0,0 +1,13 @@ +--- glue/perl/Makefile.PL.orig 2006-08-09 04:26:45.000000000 +0000 ++++ glue/perl/Makefile.PL 2008-08-25 18:07:08.000000000 +0000 +@@ -415,8 +450,8 @@ + 'NAME' => '$class', + 'VERSION' => '$version', + 'TYPEMAPS' => [qw(@$mp2_typemaps $typemap)], +- 'INC' => "-I$base_dir/glue/perl/xs -I$inc_dir -I$xs_dir $apache_includes", +- 'LIBS' => "$apreq_libs $apr_libs", ++ 'INC' => "-I$base_dir/glue/perl/xs -I$inc_dir -I$xs_dir $apache_includes -I\\\$(LOCALBASE)/%%APACHEINCLUDEDIR%%/modules/perl", ++ 'LIBS' => "$apreq_libs $apr_libs -L\\\$(LOCALBASE)/lib", + } ; + $txt .= "'depend' => $deps,\n" if ($deps) ; + $txt .= qq{ Property changes on: files/patch-glue-perl-Makefile.PL ___________________________________________________________________ Added: svn:mime-type ## -0,0 +1 ## +text/plain \ No newline at end of property Added: fbsd:nokeywords ## -0,0 +1 ## +yes \ No newline at end of property Added: svn:eol-style ## -0,0 +1 ## +native \ No newline at end of property Index: files/patch-library-Makefile.in =================================================================== --- files/patch-library-Makefile.in (revision 0) +++ files/patch-library-Makefile.in (working copy) @@ -0,0 +1,11 @@ +--- library/Makefile.in.orig ++++ library/Makefile.in +@@ -133,7 +133,7 @@ + INSTALL_STRIP_PROGRAM = @INSTALL_STRIP_PROGRAM@ + LDFLAGS = @LDFLAGS@ + LIBOBJS = @LIBOBJS@ +-LIBS = @LIBS@ ++LIBS = @LIBS@ -L$(prefix) + LIBTOOL = @LIBTOOL@ + LN_S = @LN_S@ + LTLIBOBJS = @LTLIBOBJS@ Property changes on: files/patch-library-Makefile.in ___________________________________________________________________ Added: fbsd:nokeywords ## -0,0 +1 ## +yes \ No newline at end of property Added: svn:eol-style ## -0,0 +1 ## +native \ No newline at end of property Added: svn:mime-type ## -0,0 +1 ## +text/plain \ No newline at end of property Index: files/patch-module-Makefile.in =================================================================== --- files/patch-module-Makefile.in (revision 0) +++ files/patch-module-Makefile.in (working copy) @@ -0,0 +1,11 @@ +--- module/Makefile.in.orig ++++ module/Makefile.in +@@ -43,7 +43,7 @@ + mkinstalldirs = $(install_sh) -d + CONFIG_HEADER = $(top_builddir)/include/apreq_config.h + CONFIG_CLEAN_FILES = +-PROGRAMS = $(noinst_PROGRAMS) ++PROGRAMS = + test_cgi_SOURCES = test_cgi.c + test_cgi_OBJECTS = test_cgi.$(OBJEXT) + test_cgi_LDADD = $(LDADD) Property changes on: files/patch-module-Makefile.in ___________________________________________________________________ Added: fbsd:nokeywords ## -0,0 +1 ## +yes \ No newline at end of property Added: svn:eol-style ## -0,0 +1 ## +native \ No newline at end of property Added: svn:mime-type ## -0,0 +1 ## +text/plain \ No newline at end of property Index: pkg-descr =================================================================== --- pkg-descr (revision 0) +++ pkg-descr (working copy) @@ -0,0 +1,11 @@ +p5-libapreq2 - Perl elements for the Generic Apache2 Request Library + +This package contains the Perl elements of the Generic Apache2 +Request Library. + + - parsing of application/x-www-form-urlencoded data + - parsing of multipart/form-data + - parsing of HTTP Cookies + +WWW: http://httpd.apache.org/apreq/ +WWW: http://search.cpan.org/dist/libapreq2/ Property changes on: pkg-descr ___________________________________________________________________ Added: fbsd:nokeywords ## -0,0 +1 ## +yes \ No newline at end of property Added: svn:eol-style ## -0,0 +1 ## +native \ No newline at end of property Added: svn:mime-type ## -0,0 +1 ## +text/plain \ No newline at end of property Index: pkg-plist =================================================================== --- pkg-plist (revision 0) +++ pkg-plist (working copy) @@ -0,0 +1,51 @@ +%%PERL5_MAN3%%/APR::Request.3.gz +%%PERL5_MAN3%%/APR::Request::Apache2.3.gz +%%PERL5_MAN3%%/APR::Request::CGI.3.gz +%%PERL5_MAN3%%/APR::Request::Cookie.3.gz +%%PERL5_MAN3%%/APR::Request::Error.3.gz +%%PERL5_MAN3%%/APR::Request::Hook.3.gz +%%PERL5_MAN3%%/APR::Request::Param.3.gz +%%PERL5_MAN3%%/APR::Request::Parser.3.gz +%%PERL5_MAN3%%/Apache2::Cookie.3.gz +%%PERL5_MAN3%%/Apache2::Request.3.gz +%%PERL5_MAN3%%/Apache2::Upload.3.gz +%%SITE_PERL%%/%%PERL_ARCH%%/APR/Request.pm +%%SITE_PERL%%/%%PERL_ARCH%%/APR/Request.pod +%%SITE_PERL%%/%%PERL_ARCH%%/APR/Request/Apache2.pm +%%SITE_PERL%%/%%PERL_ARCH%%/APR/Request/Apache2.pod +%%SITE_PERL%%/%%PERL_ARCH%%/APR/Request/CGI.pm +%%SITE_PERL%%/%%PERL_ARCH%%/APR/Request/CGI.pod +%%SITE_PERL%%/%%PERL_ARCH%%/APR/Request/Cookie.pm +%%SITE_PERL%%/%%PERL_ARCH%%/APR/Request/Cookie.pod +%%SITE_PERL%%/%%PERL_ARCH%%/APR/Request/Error.pm +%%SITE_PERL%%/%%PERL_ARCH%%/APR/Request/Error.pod +%%SITE_PERL%%/%%PERL_ARCH%%/APR/Request/Hook.pm +%%SITE_PERL%%/%%PERL_ARCH%%/APR/Request/Hook.pod +%%SITE_PERL%%/%%PERL_ARCH%%/APR/Request/Param.pm +%%SITE_PERL%%/%%PERL_ARCH%%/APR/Request/Param.pod +%%SITE_PERL%%/%%PERL_ARCH%%/APR/Request/Parser.pm +%%SITE_PERL%%/%%PERL_ARCH%%/APR/Request/Parser.pod +%%SITE_PERL%%/%%PERL_ARCH%%/Apache2/Cookie.pm +%%SITE_PERL%%/%%PERL_ARCH%%/Apache2/Request.pm +%%SITE_PERL%%/%%PERL_ARCH%%/Apache2/Upload.pm +%%SITE_PERL%%/%%PERL_ARCH%%/auto/%%AP_NAME%%/.packlist +%%SITE_PERL%%/%%PERL_ARCH%%/auto/APR/Request/Apache2/Apache2.so +%%SITE_PERL%%/%%PERL_ARCH%%/auto/APR/Request/CGI/CGI.so +%%SITE_PERL%%/%%PERL_ARCH%%/auto/APR/Request/Cookie/Cookie.so +%%SITE_PERL%%/%%PERL_ARCH%%/auto/APR/Request/Error/Error.so +%%SITE_PERL%%/%%PERL_ARCH%%/auto/APR/Request/Hook/Hook.so +%%SITE_PERL%%/%%PERL_ARCH%%/auto/APR/Request/Param/Param.so +%%SITE_PERL%%/%%PERL_ARCH%%/auto/APR/Request/Parser/Parser.so +%%SITE_PERL%%/%%PERL_ARCH%%/auto/APR/Request/Request.so +@dirrm %%SITE_PERL%%/%%PERL_ARCH%%/auto/libapreq2 +@dirrmtry %%SITE_PERL%%/%%PERL_ARCH%%/auto/APR/Request/Parser +@dirrmtry %%SITE_PERL%%/%%PERL_ARCH%%/auto/APR/Request/Param +@dirrmtry %%SITE_PERL%%/%%PERL_ARCH%%/auto/APR/Request/Hook +@dirrmtry %%SITE_PERL%%/%%PERL_ARCH%%/auto/APR/Request/Error +@dirrmtry %%SITE_PERL%%/%%PERL_ARCH%%/auto/APR/Request/Cookie +@dirrmtry %%SITE_PERL%%/%%PERL_ARCH%%/auto/APR/Request/CGI +@dirrmtry %%SITE_PERL%%/%%PERL_ARCH%%/auto/APR/Request/Apache2 +@dirrmtry %%SITE_PERL%%/%%PERL_ARCH%%/auto/APR/Request +@dirrmtry %%SITE_PERL%%/%%PERL_ARCH%%/Apache2 +@dirrmtry %%SITE_PERL%%/%%PERL_ARCH%%/APR/Request +@dirrmtry %%SITE_PERL%%/%%PERL_ARCH%%/APR Property changes on: pkg-plist ___________________________________________________________________ Added: svn:mime-type ## -0,0 +1 ## +text/plain \ No newline at end of property Added: fbsd:nokeywords ## -0,0 +1 ## +yes \ No newline at end of property Added: svn:eol-style ## -0,0 +1 ## +native \ No newline at end of property --adJ1OR3c6QgCpb/j-- From owner-freebsd-apache@FreeBSD.ORG Sat Jul 19 16:14:14 2014 Return-Path: Delivered-To: apache@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 52257F4D for ; Sat, 19 Jul 2014 16:14:14 +0000 (UTC) Received: from mout.gmx.net (mout.gmx.net [212.227.15.15]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mout.gmx.net", Issuer "TeleSec ServerPass DE-1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DAA9F2812 for ; Sat, 19 Jul 2014 16:14:13 +0000 (UTC) Received: from [192.168.0.100] ([87.139.233.65]) by mail.gmx.com (mrgmx001) with ESMTPSA (Nemesis) id 0Lk8CY-1WWRdR39pa-00c9SL; Sat, 19 Jul 2014 18:14:11 +0200 Message-ID: <53CA9958.80406@gmx.de> Date: Sat, 19 Jul 2014 18:14:16 +0200 From: olli hauer User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Kurt Jaeger Subject: Re: www/p5-libapreq2: libtool fix, strip libs, pkg-plist followup, p5-fix References: <20140608081334.GK1427@f10.opsec.eu> <20140608083407.GL1427@f10.opsec.eu> <20140608083636.GM1427@f10.opsec.eu> <20140608085842.GO1427@f10.opsec.eu> <53945E98.3080408@gmx.de> <20140610094949.GY3484@f10.opsec.eu> <539752DE.5060208@gmx.de> <20140719151508.GB33102@f10.opsec.eu> <53CA9694.4040409@gmx.de> In-Reply-To: <53CA9694.4040409@gmx.de> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:DgedXa2xG1L1M7RE0YHqHQ9asdAZ1HHYJ3jvZksEu652n9XOADJ 4kILmlwOQDHyH9Ysj65lvhnmV2jiNOfFYlpt9jnMsfQ/OwwMHu1EODvIStH/KikHvXVFX5/ DEwUrS/O+No2zNC3QmiLHnSqtGoKqKiducHo0rXQWQ9qgMSoKE8hIGKqfLDZlFMWm3TIAjc diYAl8e1kFy8guZUQZsRg== Cc: Frederic Culot , apache@freebsd.org, skv@FreeBSD.org X-BeenThere: freebsd-apache@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Support of apache-related ports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Jul 2014 16:14:14 -0000 On 2014-07-19 18:02, olli hauer wrote: > On 2014-07-19 17:15, Kurt Jaeger wrote: >> Hello, >> >>>> Back to my proposed change for www/libapreq2 and this question: >>>> >>>>>> Would it be more useful to make the slave port (p5-libapreq2) >>>>>> a seperate port depending on the other ? >>>> >>>> Looking at the pkg-plist and Makefile mess: Is it really useful >>>> to have this master/slave port or should I split and depend on libapreq2 ? >> >> Attached are two diffs for both ports that seperate them. >> >>> running a short grep over the tree shows there are only two libapreq2 consumers >>> - www/mod_amazon_proxy >>> - www/p5-libapreq2 >>> >>> but eleven p5-libapreq consumers >>> - net-mgmt/netdisco >>> - net-mgmt/netdot >>> - www/foswiki-ModPerlEngineContrib >>> - www/p5-Apache-Gallery >>> - www/p5-Apache2-SiteControl >>> - www/p5-CGI-Application-Plugin-Apache >>> - www/p5-HTML-Mason >>> - www/p5-Maypole >>> - www/rt38 >>> - www/rt40.cpan >>> - www/rt42.cpan >> >> I ran a bulk poudriere run with this: >> >> www/mod_amazon_proxy >> net-mgmt/netdisco >> net-mgmt/netdot >> www/foswiki-ModPerlEngineContrib >> www/p5-Apache-Gallery >> www/p5-Apache2-SiteControl >> www/p5-CGI-Application-Plugin-Apache >> www/p5-HTML-Mason >> www/p5-Maypole >> www/rt38 >> www/rt40 >> www/rt42 >> >> and DEFAULT_VERSIONS=perl5=5.20 apache=2.2 >> >> without problems on 10amd64 and 91amd64. >> >> Attached are the two diffs, please comment, and if it's OK, please >> approve. >> >> I'll also update 191161 for testing. >> > > Hi Kurt, > > seems some files are missing in the p5-libapreq2.diff > >>From the p5-libapreq2.diff > Only in p5-libapreq2: distinfo > Only in p5-libapreq2: files > Only in p5-libapreq2: pkg-descr > Only in p5-libapreq2: pkg-plist > > > Can you shape a svn diff? > > $ mkdir fix_libapreq > $ cd fix_libapreq > $ svn checkout --depth empty svn+ssh://svn.freebsd.org/ports/head ports > $ cd ports > $ svn up --set-depth empty www > $ svn up www/libapreq2 www/p5-libapreq2 > # apply your patches > $ svn diff > my.diff > > > If your test build was OK feel free to commit your patches. > In case you haven't received any feedback about p5-libapreq2 reset the MAINTAINER and go on. >From ports/svnadmin/access: r316225 | tabthorpe | 2013-04-22 14:31:12 +0200 (Mon, 22 Apr 2013) | 5 lines - Take skv's commit bit in for safe keeping -- olli