From owner-svn-src-stable-7@freebsd.org Tue Feb 2 19:29:31 2016 Return-Path: Delivered-To: svn-src-stable-7@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 26A67A99038; Tue, 2 Feb 2016 19:29:31 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id EAFA41410; Tue, 2 Feb 2016 19:29:30 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id u12JTT8C023083; Tue, 2 Feb 2016 19:29:29 GMT (envelope-from jhb@FreeBSD.org) Received: (from jhb@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id u12JTTaS023082; Tue, 2 Feb 2016 19:29:29 GMT (envelope-from jhb@FreeBSD.org) Message-Id: <201602021929.u12JTTaS023082@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: jhb set sender to jhb@FreeBSD.org using -f From: John Baldwin Date: Tue, 2 Feb 2016 19:29:29 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-7@freebsd.org Subject: svn commit: r295160 - stable/7/sys/kern X-SVN-Group: stable-7 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-stable-7@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for only the 7-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Feb 2016 19:29:31 -0000 Author: jhb Date: Tue Feb 2 19:29:29 2016 New Revision: 295160 URL: https://svnweb.freebsd.org/changeset/base/295160 Log: Return the timestamps from the corresponding namecache entry on a negative namecache hit. This was ommitted due to a merging error in r238913. The effect was to usually break caching of negative name lookups in the NFS client. Submitted by: bde Modified: stable/7/sys/kern/vfs_cache.c Modified: stable/7/sys/kern/vfs_cache.c ============================================================================== --- stable/7/sys/kern/vfs_cache.c Tue Feb 2 19:04:40 2016 (r295159) +++ stable/7/sys/kern/vfs_cache.c Tue Feb 2 19:29:29 2016 (r295160) @@ -530,6 +530,7 @@ negative_success: nchstats.ncs_neghits++; if (ncp->nc_flag & NCF_WHITE) cnp->cn_flags |= ISWHITEOUT; + cache_out_ts(ncp, tsp, ticksp); CACHE_UNLOCK(); return (ENOENT); From owner-svn-src-stable-7@freebsd.org Wed Feb 3 12:12:03 2016 Return-Path: Delivered-To: svn-src-stable-7@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DBD75A99643; Wed, 3 Feb 2016 12:12:03 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from mail110.syd.optusnet.com.au (mail110.syd.optusnet.com.au [211.29.132.97]) by mx1.freebsd.org (Postfix) with ESMTP id A8452F43; Wed, 3 Feb 2016 12:12:03 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from c211-30-166-197.carlnfd1.nsw.optusnet.com.au (c211-30-166-197.carlnfd1.nsw.optusnet.com.au [211.30.166.197]) by mail110.syd.optusnet.com.au (Postfix) with ESMTPS id 54B1F7800E7; Wed, 3 Feb 2016 23:11:55 +1100 (AEDT) Date: Wed, 3 Feb 2016 23:11:55 +1100 (EST) From: Bruce Evans X-X-Sender: bde@besplex.bde.org To: John Baldwin cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-7@freebsd.org Subject: Re: svn commit: r295160 - stable/7/sys/kern In-Reply-To: <201602021929.u12JTTaS023082@repo.freebsd.org> Message-ID: <20160203230906.C1511@besplex.bde.org> References: <201602021929.u12JTTaS023082@repo.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.1 cv=cK4dyQqN c=1 sm=1 tr=0 a=KA6XNC2GZCFrdESI5ZmdjQ==:117 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=kj9zAlcOel0A:10 a=BJb7wXAST1g5ecHwEB8A:9 a=CjuIK1q_8ugA:10 a=KNH-PBpkn6UA:10 X-BeenThere: svn-src-stable-7@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for only the 7-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Feb 2016 12:12:04 -0000 On Tue, 2 Feb 2016, John Baldwin wrote: > Log: > Return the timestamps from the corresponding namecache entry on a negative > namecache hit. This was ommitted due to a merging error in r238913. The > effect was to usually break caching of negative name lookups in the NFS > client. > > Submitted by: bde Thanks. FreeBSD-7 is now almost the fastest version in my makeworld on nfs benchmark :-). Bruce