From owner-svn-src-all@FreeBSD.ORG Wed Apr 29 23:04:32 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2F59C1065670; Wed, 29 Apr 2009 23:04:32 +0000 (UTC) (envelope-from jeff@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 1D6338FC0C; Wed, 29 Apr 2009 23:04:32 +0000 (UTC) (envelope-from jeff@FreeBSD.org) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id n3TN4Wb9095280; Wed, 29 Apr 2009 23:04:32 GMT (envelope-from jeff@svn.freebsd.org) Received: (from jeff@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id n3TN4WbH095279; Wed, 29 Apr 2009 23:04:32 GMT (envelope-from jeff@svn.freebsd.org) Message-Id: <200904292304.n3TN4WbH095279@svn.freebsd.org> From: Jeff Roberson Date: Wed, 29 Apr 2009 23:04:31 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r191676 - head/sys/kern X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Apr 2009 23:04:32 -0000 Author: jeff Date: Wed Apr 29 23:04:31 2009 New Revision: 191676 URL: http://svn.freebsd.org/changeset/base/191676 Log: - Fix non-SMP build by encapsulating idle spin logic in a macro. Pointy hat to: me Modified: head/sys/kern/sched_ule.c Modified: head/sys/kern/sched_ule.c ============================================================================== --- head/sys/kern/sched_ule.c Wed Apr 29 21:50:13 2009 (r191675) +++ head/sys/kern/sched_ule.c Wed Apr 29 23:04:31 2009 (r191676) @@ -2516,6 +2516,13 @@ sched_sizeof_thread(void) return (sizeof(struct thread) + sizeof(struct td_sched)); } +#ifdef SMP +#define TDQ_IDLESPIN(tdq) \ + ((tdq)->tdq_cg != NULL && ((tdq)->tdq_cg->cg_flags & CG_FLAG_THREAD) == 0) +#else +#define TDQ_IDLESPIN(tdq) 1 +#endif + /* * The actual idle process. */ @@ -2543,8 +2550,7 @@ sched_idletd(void *dummy) * loops while on SMT machines as this simply steals * cycles from cores doing useful work. */ - if ((tdq->tdq_cg->cg_flags & CG_FLAG_THREAD) == 0 && - switchcnt > sched_idlespinthresh) { + if (TDQ_IDLESPIN(tdq) && switchcnt > sched_idlespinthresh) { for (i = 0; i < sched_idlespins; i++) { if (tdq->tdq_load) break;