From owner-svn-src-all@FreeBSD.ORG Wed Feb 3 12:59:44 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6A1021065670; Wed, 3 Feb 2010 12:59:44 +0000 (UTC) (envelope-from rrs@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 5859A8FC1A; Wed, 3 Feb 2010 12:59:44 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id o13Cxidl000460; Wed, 3 Feb 2010 12:59:44 GMT (envelope-from rrs@svn.freebsd.org) Received: (from rrs@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id o13CxiK0000458; Wed, 3 Feb 2010 12:59:44 GMT (envelope-from rrs@svn.freebsd.org) Message-Id: <201002031259.o13CxiK0000458@svn.freebsd.org> From: Randall Stewart Date: Wed, 3 Feb 2010 12:59:44 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r203428 - head/lib/libc/mips/sys X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Feb 2010 12:59:44 -0000 Author: rrs Date: Wed Feb 3 12:59:44 2010 New Revision: 203428 URL: http://svn.freebsd.org/changeset/base/203428 Log: This fixes a bug found and fixed by JC. Basically no save was being done of the ra and gp pointers before we call the __error function. Obtained from: JC (c.jayachandran@gmail.com) Modified: head/lib/libc/mips/sys/ptrace.S Modified: head/lib/libc/mips/sys/ptrace.S ============================================================================== --- head/lib/libc/mips/sys/ptrace.S Wed Feb 3 12:35:42 2010 (r203427) +++ head/lib/libc/mips/sys/ptrace.S Wed Feb 3 12:59:44 2010 (r203428) @@ -42,14 +42,26 @@ __FBSDID("$FreeBSD$"); #endif /* LIBC_SCCS and not lint */ LEAF(ptrace) + .frame sp,40,ra + .mask 0x80000000, -8 #ifdef __ABICALLS__ .set noreorder .cpload t9 .set reorder #endif + subu sp, sp, 40 + sw ra, 32(sp) +#ifdef __ABICALLS__ + .cprestore 16 +#endif la t9, _C_LABEL(__error) # locate address of errno - jalr t9 + jalr t9 +#ifdef __ABICALLS__ + lw gp, 16(sp) +#endif sw zero, 0(v0) + lw ra, 32(sp) + addu sp, sp, 40 li v0, SYS_ptrace syscall bne a3, zero, 1f