From owner-freebsd-current@FreeBSD.ORG Sat May 1 15:03:39 2010 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id E0A7A106567B for ; Sat, 1 May 2010 15:03:39 +0000 (UTC) (envelope-from marius@alchemy.franken.de) Received: from alchemy.franken.de (alchemy.franken.de [194.94.249.214]) by mx1.freebsd.org (Postfix) with ESMTP id 6EAE98FC2B for ; Sat, 1 May 2010 15:03:39 +0000 (UTC) Received: from alchemy.franken.de (localhost [127.0.0.1]) by alchemy.franken.de (8.14.3/8.14.3/ALCHEMY.FRANKEN.DE) with ESMTP id o41F3Wvp075917; Sat, 1 May 2010 17:03:33 +0200 (CEST) (envelope-from marius@alchemy.franken.de) Received: (from marius@localhost) by alchemy.franken.de (8.14.3/8.14.3/Submit) id o41F3V75075916; Sat, 1 May 2010 17:03:31 +0200 (CEST) (envelope-from marius) Date: Sat, 1 May 2010 17:03:31 +0200 From: Marius Strobl To: pluknet Message-ID: <20100501150331.GA74398@alchemy.franken.de> References: <4BDAE7BD.4000503@feral.com> Mime-Version: 1.0 Content-Type: text/plain; charset=unknown-8bit Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.4.2.3i Cc: freebsd-scsi , FreeBSD Current , Matthew Jacob Subject: Re: mpt(4) MPI_EVENT_IR_RESYNC_UPDATE X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 01 May 2010 15:03:40 -0000 On Fri, Apr 30, 2010 at 06:50:26PM +0400, pluknet wrote: > On 30 April 2010 18:22, Matthew Jacob wrote: > > pluknet wrote: > > Seems good to me- why not trhow it freebsd-scsi? if nobody says no, I'll put > > it in > > Err.. I thought that list is dedicated for cam related stuff. > > [cc'ing scsi@ for better coverage. Sorry for cross-posting :/ ] > > > > >> --- RELENG_7_3/src/sys/dev/mpt/mpt_cam.c        2010-03-02 > >> 15:38:13.000000000 +0300 > >> +++ RELENG_7_3.ours/src/sys/dev/mpt/mpt_cam.c   2010-04-21 > >> 19:31:00.000000000 +0400 > >> @@ -2564,6 +2564,12 @@ mpt_cam_event(struct mpt_softc *mpt, req > >>                CAMLOCK_2_MPTLOCK(mpt); > >>                break; > >>        } > >> +       case MPI_EVENT_IR_RESYNC_UPDATE: > >> +       { > >> +               uint8_t resync = (data0 >> 16) & 0xff; > >> +               mpt_prt(mpt, "IR resync update %d completed\n", resync); > >> +               break; > >> +       } > >>        case MPI_EVENT_EVENT_CHANGE: > >>        case MPI_EVENT_INTEGRATED_RAID: > >>        case MPI_EVENT_SAS_DEVICE_STATUS_CHANGE: > >> > >> Another way - just hide such event since mptutil displays rebuild > >> progress. > >> > >> > Could you maybe avoid defining a variable inside a nested scope for consistency with the majority of the existing cases and in order to not violate style(9) unnecessarily? Marius Index: mpt_cam.c =================================================================== --- mpt_cam.c (revision 207463) +++ mpt_cam.c (working copy) @@ -2575,6 +2575,10 @@ mpt_cam_event(struct mpt_softc *mpt, request_t *re CAMLOCK_2_MPTLOCK(mpt); break; } + case MPI_EVENT_IR_RESYNC_UPDATE: + mpt_prt(mpt, "IR resync update %d completed\n", + (data0 >> 16) & 0xff); + break; case MPI_EVENT_EVENT_CHANGE: case MPI_EVENT_INTEGRATED_RAID: case MPI_EVENT_SAS_DEVICE_STATUS_CHANGE: