From owner-freebsd-ports@FreeBSD.ORG Thu May 8 08:24:47 2014 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 3A3251B5 for ; Thu, 8 May 2014 08:24:47 +0000 (UTC) Received: from mail-ob0-x22b.google.com (mail-ob0-x22b.google.com [IPv6:2607:f8b0:4003:c01::22b]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id EF802E2D for ; Thu, 8 May 2014 08:24:46 +0000 (UTC) Received: by mail-ob0-f171.google.com with SMTP id wn1so2644629obc.2 for ; Thu, 08 May 2014 01:24:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bluelife.at; s=google; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=vtiveRF4FCp1A3UgZ69q1d+qbCH6o+AlMIFl5Rm41bQ=; b=X+5agWraPvT2I0VlFrSgNEzN/Nncwu9bCzhzgJoIvujKdSfD+pPVh0xx2pIALBdQnh BE6FSIXEac6Df7VATJTJxYsmdPzMmAFS6ZA0m+Gvxy2NsGwJDEBCCwHZbVUpsPpf8bN5 lo7MsG8lZUdWYpGoLO1q0oXX/odzvED5qI4cs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=vtiveRF4FCp1A3UgZ69q1d+qbCH6o+AlMIFl5Rm41bQ=; b=NhcAEcQLPOO664+ZQmeUtf9c+aCh8j7uac7ZdAXUzA9wpzEq5CbNaYGpzFoB9xS+R6 //OtozKj7MjjNrvEkNU1MSOQQGjN+ANnIz6D7SYkx2rpadENdEr6K/6roT+uDbf6UKgM i+s5K8NyEUK0kvBIDN/BmBXXLh72qF9fid8ITJQmMmpIyIXRXn5Wr2LdUA74U+v63fIn W+QDCjmtzmrDu4FNySCOjG93ZG9HVjdSR5AuXvSh+RdZJUCB6On8aQ3bBv+tvggThqse GXHRSfW8iXhNRRFt3nQ4M0P4UQFlI8M47ZM/i2VF08yGKjCLwzp8RTlwZpAxSaeA55kc /fhQ== X-Gm-Message-State: ALoCoQngS0kLEPsmnqx5Lb5FG2FAB9CCV0PBnT5WmKHHDRUZ8mia3grMDDZ3Rloz1a+/F/zRqqu/ MIME-Version: 1.0 X-Received: by 10.182.219.167 with SMTP id pp7mr739692obc.85.1399537486261; Thu, 08 May 2014 01:24:46 -0700 (PDT) Received: by 10.76.154.136 with HTTP; Thu, 8 May 2014 01:24:46 -0700 (PDT) X-Originating-IP: [2001:470:1f15:673::1000] In-Reply-To: References: Date: Thu, 8 May 2014 10:24:46 +0200 Message-ID: Subject: Re: Make loosing a variable (emulators/virtualbox-ose-additions) From: =?UTF-8?Q?Bernhard_Fr=C3=B6hlich?= To: Melvyn Sopacua Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: ports X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 May 2014 08:24:47 -0000 I have just seen that jkim has committed a different fix that should help with that issue. Could you please test to see if it works for you? On Sun, May 4, 2014 at 10:32 PM, Melvyn Sopacua wrote: > Hi Bernhard, > > On Sun, 4 May 2014, Bernhard Fr=C3=B6hlich wrote: > >> Am 04.05.2014 20:44 schrieb "Melvyn Sopacua" : >>> >>> >>> Hi, >>> >>> emulators/virtualbox-ose-additions always fails for me in the stage >>> installation, so today I looked a bit further: >>> >>> Bad: >>> install -o root -g wheel -m 444 >>> >> >> /usr/obj/ports/usr/ports/emulators/virtualbox-ose-additions/work/Virtual= Box-4.3.10/out/freebsd.amd64/release/bin/additions/vboxvideo_drv_.so >>> >>> >> >> /usr/obj/ports/usr/ports/emulators/virtualbox-ose-additions/work/stage/u= sr/local/lib/xorg/modules/drivers/vboxvideo_drv.so >>> >>> >>> Good: >>> install -o root -g wheel -m 444 >>> >> >> /usr/obj/ports/usr/ports/emulators/virtualbox-ose-additions/work/Virtual= Box-4.3.10/out/freebsd.amd64/release/bin/additions/vboxvideo_drv_17.so >>> >>> >> >> /usr/obj/ports/usr/ports/emulators/virtualbox-ose-additions/work/stage/u= sr/local/lib/xorg/modules/drivers/vboxvideo_drv.so >>> >>> >>> The difference between bad and good are the 17 missing in the shared >>> object name. The bad line is created in a clean build and the good line >>> if one invokes the install target immediately after that failed one. >>> >>> Is make really loosing a variable here or could this be a parallelizati= on >> >> issue in the upstream build system? >> >> That command is part of the port makefile so it's for sure not an upstre= am >> bug. Sounds like the xserver version that is used there is not read >> properly in some case. > > > I see and makes sense (Mk/bsd.xorg.mk): > .if exists(${LOCALBASE}/bin/X) > XSERVER_VER!=3D ${LOCALBASE}/bin/X -version 2>&1 | sed -n 's;^X\.Org X > Server \([^ ]*\).*;\1;p' > .endif > > ${LOCALBASE}/bin/X won't exist when this is evaluated, unless you cut up > the build stages into a separate make depends followed by make install. > > I believe setting a default that is in sync with x11-servers/xorg-server > in bsd.xorg.mk will fix all cases, since if it doesn't exist the > dependency installed will be provided by that port and if it does, you > got the one that was installed by the user. --=20 Bernhard Fr=C3=B6hlich http://www.bluelife.at/