From owner-cvs-all Sun Nov 5 19:27:17 2000 Delivered-To: cvs-all@freebsd.org Received: from palrel3.hp.com (palrel3.hp.com [156.153.255.226]) by hub.freebsd.org (Postfix) with ESMTP id 03B3F37B4D7; Sun, 5 Nov 2000 19:27:12 -0800 (PST) Received: from adlmail.cup.hp.com (adlmail.cup.hp.com [15.0.100.30]) by palrel3.hp.com (Postfix) with ESMTP id 8EF4212D; Sun, 5 Nov 2000 19:27:11 -0800 (PST) Received: from cup.hp.com (p1000180.nsr.hp.com [15.109.0.180]) by adlmail.cup.hp.com (8.9.3 (PHNE_18546)/8.9.3 SMKit7.02) with ESMTP id TAA00320; Sun, 5 Nov 2000 19:27:10 -0800 (PST) Message-ID: <3A06250E.E752CF4B@cup.hp.com> Date: Sun, 05 Nov 2000 19:27:10 -0800 From: Marcel Moolenaar Organization: Hewlett-Packard X-Mailer: Mozilla 4.73 [en] (X11; U; Linux 2.2.12 i386) X-Accept-Language: en MIME-Version: 1.0 To: "John W. De Boskey" Cc: "David O'Brien" , "Jordan K. Hubbard" , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src Makefile References: <200011052244.OAA60716@freefall.freebsd.org> <20001105161514.A7914@dragon.nuxi.com> <20001105193652.A14868@bsdwins.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG "John W. De Boskey" wrote: > > ----- David O'Brien's Original Message ----- > > On Sun, Nov 05, 2000 at 02:44:49PM -0800, Jordan K. Hubbard wrote: > > > jkh 2000/11/05 14:44:49 PST > > > > > > Modified files: (Branch: RELENG_4) > > > . Makefile > > > Log: > > > removed duplicated "start" message for world target. > > > > Adding the duplicated "start" message was intentional -- so it would be > > easy to see how long the `make world' took. > > > > Personally I prefer the duplicated message and would like to see it > > return. With it I then don't have to either save the output to a file to > > see how long it took, or the times I do save the build output, I don't > > have to go looking thru the output file. > > > > -- > > -- David (obrien@FreeBSD.org) > > GNU is Not Unix / Linux Is Not UniX > > I have to agree with David. I have code which depends on these > values at the end of the world/release logs. > > May I be so bold to ask where this was discussed beforehand? > I'd like to see other folks' pros and cons. From Jordan's point of view it makes sense to remove the duplicate at the end. Having the start, milestones and finish in the proper order without duplicates, makes the grep more pleasing. From David's point of view, it make sense to know when it started if you would only see the last lines of the output. Only in this case the time elapsed is the information that's actaully wanted. If we combine these views, we have a "start" mesage at the beginning and use that and the "end" message to synthesize the elapsed time, which we emit after the "end" message. This should work, no matter what viewpoint is taken, right? -- Marcel Moolenaar mail: marcel@cup.hp.com / marcel@FreeBSD.org tel: (408) 447-4222 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message