From owner-svn-src-all@FreeBSD.ORG Tue May 19 19:11:27 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 9A0E0246; Tue, 19 May 2015 19:11:27 +0000 (UTC) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 753E818D1; Tue, 19 May 2015 19:11:27 +0000 (UTC) Received: from ralph.baldwin.cx (pool-173-54-116-245.nwrknj.fios.verizon.net [173.54.116.245]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 5E764B97A; Tue, 19 May 2015 15:11:26 -0400 (EDT) From: John Baldwin To: src-committers@freebsd.org Cc: svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r283120 - in head: lib/libpmc sys/dev/hwpmc sys/sys Date: Tue, 19 May 2015 15:06:40 -0400 Message-ID: <1908963.8Har9SZnS7@ralph.baldwin.cx> User-Agent: KMail/4.14.3 (FreeBSD/10.1-STABLE; KDE/4.14.3; amd64; ; ) In-Reply-To: <201505191858.t4JIwJft016661@svn.freebsd.org> References: <201505191858.t4JIwJft016661@svn.freebsd.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Tue, 19 May 2015 15:11:26 -0400 (EDT) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 May 2015 19:11:27 -0000 On Tuesday, May 19, 2015 06:58:19 PM John Baldwin wrote: > Author: jhb > Date: Tue May 19 18:58:18 2015 > New Revision: 283120 > URL: https://svnweb.freebsd.org/changeset/base/283120 > > Log: > Use fixed enum values for PMC_CLASSES(). > > This removes one of the frequent causes of ABI breakage when new CPU > types are added to hwpmc(4). > > Differential Revision: https://reviews.freebsd.org/D2586 > Reviewed by: davide, emaste, gnn (earlier version) > MFC after: 2 weeks The ABI was already broken today with the ARMv8 counters. Merging this to stable will break the ABI there as well. Since PMC_SOFT always gets renumbered it always breaks pmcccontrol -L when this enum is updated. I believe it has already been broken in once stable/10. My preference would be that we only MFC this the next time we want to add a new class to 10 to avoid being too disruptive. At the time the new class is added, then this change could be merged as well. -- John Baldwin