From owner-cvs-all  Wed Apr 25 15:34:51 2001
Delivered-To: cvs-all@freebsd.org
Received: from ipcard.iptcom.net (ipcard.iptcom.net [212.9.224.5])
	by hub.freebsd.org (Postfix) with ESMTP
	id 6F1FD37B424; Wed, 25 Apr 2001 15:34:40 -0700 (PDT)
	(envelope-from sobomax@FreeBSD.org)
Received: from vic.sabbo.net (dialup10-34.iptelecom.net.ua [212.9.228.98])
	by ipcard.iptcom.net (8.9.3/8.9.3) with ESMTP id BAA25882;
	Thu, 26 Apr 2001 01:34:34 +0300 (EEST)
	(envelope-from sobomax@FreeBSD.org)
Received: from FreeBSD.org (big_brother.vega.com [192.168.1.1])
	by vic.sabbo.net (8.11.3/8.11.2) with ESMTP id f3PMY4X70093;
	Thu, 26 Apr 2001 01:34:04 +0300 (EEST)
	(envelope-from sobomax@FreeBSD.org)
Message-ID: <37239858.A427E4FD@FreeBSD.org>
Date: Mon, 26 Apr 1999 01:34:00 +0300
From: Maxim Sobolev <sobomax@FreeBSD.org>
Organization: Vega International Capital
X-Mailer: Mozilla 4.77 [en] (WinNT; U)
X-Accept-Language: uk,ru,en
MIME-Version: 1.0
To: "David E. O'Brien" <obrien@FreeBSD.org>
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/usr.sbin/pkg_install/add main.c
References: <200104251911.f3PJBAv31212@freefall.freebsd.org>
Content-Type: text/plain; charset=koi8-r
Content-Transfer-Encoding: 7bit
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

"David E. O'Brien" wrote:

> obrien      2001/04/25 12:11:09 PDT
>
>   Modified files:
>     usr.sbin/pkg_install/add main.c
>   Log:
>   Add /usr/X11R6/bin to the exported PATH.  If /usr/local/bin is there,
>   /usr/X11R6/bin should be there.  This helps all the ports that need to
>   run `mkfontdir' and error out as many port maintainers do not realize
>   `mkfontdir' isn't in the path.

Please note that /usr/local/bin was added into exported PATH for entirely
different purposes. In some cases it might be necessary for tar(1) to find
bzip2(1) command when working with bzip2-compressed packages. IMO, addition
of the /usr/X11R6/bin into there serves no useful purpose, and could be ever
harmful as it will encourage bad porting practices. It would be better to
fix the real source of the problem, especially considering that the not
PATH-clean ports could be easily identified by greping PLISTS in the ports
collection using standard tools.

-Maxim


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message