From owner-cvs-all Tue Apr 2 8: 9:54 2002 Delivered-To: cvs-all@freebsd.org Received: from mail17.speakeasy.net (mail17.speakeasy.net [216.254.0.217]) by hub.freebsd.org (Postfix) with ESMTP id CB01037B47D for ; Tue, 2 Apr 2002 08:09:16 -0800 (PST) Received: (qmail 14036 invoked from network); 2 Apr 2002 16:09:15 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) by mail17.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP for ; 2 Apr 2002 16:09:15 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.11.6/8.11.6) with ESMTP id g32GA2v19387; Tue, 2 Apr 2002 11:10:02 -0500 (EST) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.2 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20020402122111.A20507@wantadilla.lemis.com> Date: Tue, 02 Apr 2002 11:09:17 -0500 (EST) From: John Baldwin To: "Greg 'groggy' Lehey" Subject: Re: cvs commit: src/sys/conf options src/sys/kern kern_ktr.c src Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, Jake Burkholder Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 02-Apr-2002 Greg 'groggy' Lehey wrote: > On Sunday, 31 March 2002 at 21:35:26 -0800, Jake Burkholder wrote: >> jake 2002/03/31 21:35:26 PST >> >> Modified files: >> sys/conf options >> sys/kern kern_ktr.c >> sys/sys ktr.h >> sys/sparc64/sparc64 genassym.c >> Log: >> ktr changes to improve performance and make writing a userland utility to >> dump the trace buffer feasible. >> - Remove KTR_EXTEND. This changes the format of the trace entries when >> activated, making writing a userland tool which is not tied to a >> specific >> kernel configuration difficult. >> >> These changes will break gdb macros to decode the extended version >> of the trace buffer which are floating around. Users of these >> macros should either use the show ktr command in ddb, or use the >> userland utility which can be run on a core dump. > > I really think this is wrong. It removes a very useful debugging > tool. IIRC it was possible to disable KTR_EXTEND when necessary. > Even if not, it was still an option, and I think it should remain one. > There are plenty of places where you won't be able to use the userland > tool. In which case you can use 'show ktr' in DDB or a simple macro in gdb. This doesn't preclude using a macro in gdb, it just makes the macro a bit more complicated. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message