From owner-freebsd-current@FreeBSD.ORG Thu Jun 26 12:03:19 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EC49237B401; Thu, 26 Jun 2003 12:03:18 -0700 (PDT) Received: from spider.deepcore.dk (cpe.atm2-0-56339.0x50c6aa0a.abnxx2.customer.tele.dk [80.198.170.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6045843F3F; Thu, 26 Jun 2003 12:03:17 -0700 (PDT) (envelope-from sos@spider.deepcore.dk) Received: (from sos@localhost) by spider.deepcore.dk (8.12.8p1/8.12.8) id h5QJ3Guv019672; Thu, 26 Jun 2003 21:03:16 +0200 (CEST) (envelope-from sos) From: Soeren Schmidt Message-Id: <200306261903.h5QJ3Guv019672@spider.deepcore.dk> In-Reply-To: <20030626184848.46DB137B401@hub.freebsd.org> To: Bill Paul Date: Thu, 26 Jun 2003 21:03:16 +0200 (CEST) X-Mailer: ELM [version 2.4ME+ PL98b (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=ISO-8859-1 cc: imp@FreeBSD.ORG cc: current@FreeBSD.ORG cc: sos@FreeBSD.ORG Subject: Re: Heads up: checking in change to ata-card.c X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Jun 2003 19:03:19 -0000 I do have problems with the wording you use in the comments in that patch mentioned below, I will even say that I will remove that as soon as it appears *and* shoot the committer so it doesn't happen again to use your choice of wording.. Now, I dont think this way is productive at all, and would appreciate if we could have a civilized way of doing this instead... This is exactly the crap that makes one wonder if the time used on the project is well spent... -Søren It seems Bill Paul wrote: > A long time ago, circa FreeBSD 4.3, my Sony PCMCIA CD-ROM drive with > brain-damaged Teac ATA controller drive worked, and the people were > content and all was right with the land. Then my 4.4 CD set arrived, > and I was disappointed to find the install kernel would lock up after > the driver was probed. Complaints were made and epithets were hurled, > and lo, in 4.5-RELEASE, all was well once again. > > Then came 4.6-RELEASE, and it was broken again. > > Then came 4.6.2, and it was still broken. > > And in 4.7. > > And 4.8. > > And 5.0. (Yeah yeah, shut up.) > > I just got my 5.1-RELEASE CDs and guess what? My CD-ROM drive STILL > doesn't work!!! > > Guys, there's nothing more frustrating than getting a brand new CD > set in the mail and not being able to install via CD. So I'm not leaving > it up to chance anymore. I have a patch to make my drive work here: > > http://www.freebsd.org/~wpaul/ata-card.c.diff-5.1 > > I have no idea what the altio port remapping goop in ata_pccard_probe() > is supposed to accomplish, but I'm telling you all right now, it doesn't > work with my drive. I have specifically added to code to skip the > remapping for drives with the product string of "NinjaATA-" (the problem > with the Teac controller is that its vendor/product ID is 0xffff/0xffff, > so there's really no better way to indentify it). This patch changes > this: > > ata2: < NinjaATA-> at port 0x180-0x187,0x386-0x387 irq 9 function 0 config 33 on pccard0 > device_probe_and_attach: ata2 attach returned 6 > > Into this: > > ata2: < NinjaATA-> at port 0x180-0x187,0x386-0x387 irq 9 function 0 config 33 on pccard0 > acd0: CDROM at ata2-master PIO4 > > Now, I'm sending out this notification that I _WILL_ check this patch in > before I leave the office today. I'm not asking for permission. I've been > waiting for half a dozen releases for this to get fixed. When 5.2-RELEASE > arrives in my mailbox, it _WILL_ install from CD-ROM on my laptop or so > help me I will find the responsible parties and force them to listen to > RMS sing "Free The Software" -- _live_ -- until their ears bleed. > > I have tested this patch. It compiles. It works. I can mount CDs > successfully and transfer stuff from them to my heart's content. I've > reduced the change down to the absolute minimum and insured that it > won't affect any other drives except mine. It's going in. Period. > I am not leaving it up for debate, because if I do, all that will > happen is that people will argue over what the more "correct" fix > should be, and at this point I _just_ _don't_ _care_. I want my > drive to work, and this does it. Understand? Good. > > This concludes my announcement. Thank you all for your attention. Don't > forget to tip the waitress. > > -Bill > > P.S.: Be sure to join us next time when I ream out whoever it was that > broke support for my 3Com 3c575C cardbus ethernet NIC. > > -- > ============================================================================= > -Bill Paul (510) 749-2329 | Senior Engineer, Master of Unix-Fu > wpaul@windriver.com | Wind River Systems > ============================================================================= > "If stupidity were a handicap, you'd have the best parking spot." > ============================================================================= >