From owner-cvs-all@FreeBSD.ORG Mon Aug 16 15:32:39 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2195B16A4D0; Mon, 16 Aug 2004 15:32:39 +0000 (GMT) Received: from harmony.village.org (rover.village.org [168.103.84.182]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9589A43D4C; Mon, 16 Aug 2004 15:32:38 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.12.11/8.12.11) with ESMTP id i7GFUssT061165; Mon, 16 Aug 2004 09:30:54 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Mon, 16 Aug 2004 09:31:15 -0600 (MDT) Message-Id: <20040816.093115.53587779.imp@bsdimp.com> To: jhb@freebsd.org From: "M. Warner Losh" In-Reply-To: <200408160951.12155.jhb@FreeBSD.org> References: <20040816052054.GR991@funkthat.com> <20040816054318.GF980@green.homeunix.org> <200408160951.12155.jhb@FreeBSD.org> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: green@freebsd.org cc: gurney_j@resnet.uoregon.edu cc: src-committers@freebsd.org cc: cvs-all@freebsd.org cc: cvs-src@freebsd.org Subject: Re: cvs commit: src/sys/cam/scsi scsi_target.c src/sys/dev/mii mii.c src/sys/fs/fifofs fifo_vnops.c src/sys/gnu/ext2fs ext2_vnops.c src/sys/kern init_main.c kern_conf.c kern_descrip.c kern_event.c kern_exec.c kern_exit.c kern_fork.c kern_sig.c sys_pipe.c tty.c ... X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Aug 2004 15:32:39 -0000 In message: <200408160951.12155.jhb@FreeBSD.org> John Baldwin writes: : On Monday 16 August 2004 01:43 am, Brian Fundakowski Feldman wrote: : > On Sun, Aug 15, 2004 at 10:20:55PM -0700, John-Mark Gurney wrote: : > > Brian Fundakowski Feldman wrote this message on Sun, Aug 15, 2004 at 22:38 : -0400: : > > > On Sun, Aug 15, 2004 at 06:51:08PM -0700, John-Mark Gurney wrote: : > > > > sure, I'd like a quick peak at the patch though (if it takes me more : > > > > than a day, go ahead and commit). : > > > : > > > I'd very much like you to look it over. I haven't tested it, just made : > > > the stylistic changes. If it were more complete (i.e. satisfy bde), : > > > every spurious blank line (that is, all of them inside functions which : > > > are not between variable declarations and code) would be gone, too, but : > > > that can be kind of harsh. : > > : > > As was pointed out... blank lines at the top of functions w/o variables : > > are mandated by style(9)... : > : > The manpage is either wrong or misleading, so either way, I'm waiting : > to hear from bde. : : I've never been confused on that topic Brian. Just accept it and move on. It has come up about a dozen times and matches large parts of the tree that style(9) was designed to document. Warner