From owner-freebsd-emulation@FreeBSD.ORG Wed Mar 2 21:09:24 2011 Return-Path: Delivered-To: freebsd-emulation@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 48B2E106566B; Wed, 2 Mar 2011 21:09:24 +0000 (UTC) (envelope-from jamesbrandongooch@gmail.com) Received: from mail-ww0-f50.google.com (mail-ww0-f50.google.com [74.125.82.50]) by mx1.freebsd.org (Postfix) with ESMTP id 8272E8FC0A; Wed, 2 Mar 2011 21:09:22 +0000 (UTC) Received: by wwb31 with SMTP id 31so582561wwb.31 for ; Wed, 02 Mar 2011 13:09:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=AOyttBJmy1w14LwlLMCPJfLgeMSdf9leztBQqbiokwg=; b=NUs12SANucMefDHc4O2TLeYgf4o2xHb+gtAqFzNsaSNFhCJL8cODdeqRK50YVhG4Wi GTlG6AQM/RBjopTJOsaC7XJXV7ua9BkbHXtu4MIMUViyKhQMbEJ1TIT59tYkSkKKdFmy lKadkZ31hu5FplZBL0Z+c4nmPvBFP5EA0Ou98= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=VuK2mXwV/DcaIOnNpTX9OAWKVJM/Q6+FP/bFg4mLQ+JUiyiN/v8iG0JdZ14LrLYzs5 O4BuZtQr1tktaWOiDwWeS51o/YFZQefvIrHXjnPoox01RfoKywcH9aOWceKj89/KdwYi mevpvBc7QGoXJjR9EnkEpR+u2diyKqrOfe1bc= MIME-Version: 1.0 Received: by 10.216.158.21 with SMTP id p21mr1071734wek.99.1299100161622; Wed, 02 Mar 2011 13:09:21 -0800 (PST) Received: by 10.216.25.72 with HTTP; Wed, 2 Mar 2011 13:09:21 -0800 (PST) In-Reply-To: <8b39481bb24314e2d543b7544f12a447@bluelife.at> References: <86oc77heqk.fsf@kopusha.home.net> <4D3D2DE9.2060004@freebsd.org> <86tygwy9p0.fsf@kopusha.home.net> <4D3F8357.2070005@freebsd.org> <62fcd16074e526547c3417a8f259174e@bluelife.at> <8662tbkahz.fsf@zhuzha.ua1> <4c9ee35c7798936a1e35259d72af781c@bluelife.at> <8b39481bb24314e2d543b7544f12a447@bluelife.at> Date: Wed, 2 Mar 2011 15:09:21 -0600 Message-ID: From: Brandon Gooch To: Bernhard Froehlich Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-emulation@freebsd.org, Julian Elischer , freebsd-virtualization@freebsd.org Subject: Re: VirtualBox + VIMAGE X-BeenThere: freebsd-emulation@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Development of Emulators of other operating systems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Mar 2011 21:09:24 -0000 On Wed, Mar 2, 2011 at 2:52 PM, Bernhard Froehlich wrot= e: > On Wed, 02 Mar 2011 21:31:45 +0100, Bernhard Froehlich wrote: >> On Wed, 2 Mar 2011 08:30:01 -0600, Brandon Gooch wrote: >>> On Wed, Jan 26, 2011 at 5:19 PM, Bernhard Froehlich >>> wrote: >>>> On Wed, 26 Jan 2011 16:25:28 +0200, Mikolaj Golub wrote: >>>>> On Wed, 26 Jan 2011 10:22:40 +0100 Bernhard Froehlich wrote: >>>>> >>>>> =A0BF> Sounds like it's my turn now. Which FreeBSD version is require= d to be >>>>> =A0BF> able to use it? >>>>> >>>>> As Bjoern noted it is for __FreeBSD_version >=3D 800500. >>>>> >>>>> =A0BF> Is VIMAGE enabled per default and what happens if VIMAGE is di= sabled - >>>>> =A0BF> does it at least build fine with that patch? >>>>> >>>>> We have VIMAGE disabled by default. >>>>> >>>>> I have added to src/VBox/HostDrivers/VBoxNetFlt/freebsd/Makefile: >>>>> >>>>> .if defined(VIMAGE) >>>>> =A0CFLAGS +=3D -DVIMAGE >>>>> .endif >>>>> >>>>> So to build the driver for VIMAGE enabled kernel one should run >>>>> >>>>> VIMAGE=3D1 make >>>>> >>>>> If VIMAGE variable is not defined the module for VIMAGE disabled kern= el will >>>>> be built. >>>> >>>> http://home.bluelife.at/patches/virtualbox-ose-kmod-devel-VIMAGE.diff >>>> >>>> I've integrated it a bit better into the VirtualBox build system, adde= d >>>> the ports stuff and updated the patch for VirtualBox 4.0.2. >>>> >>>> It is currently unclear to me why you add VIMAGE to CFLAGS but nowhere >>>> check for VIMAGE in VBoxNetFlt-freebsd.c. Shouldn't we add a check for >>>> VIMAGE in the #if defined line or is this already done somewhere deep = in >>>> the included headers? >>>> >>>> -- >>>> Bernhard Froehlich >>>> http://www.bluelife.at/ >>> >>> I managed to completely miss your patch posted this thread, so I just >>> gave it a try on bluelife's virtualbox-ose-kmod svn r1239; it's >>> working well. I've started each of my guests with bridged networking >>> to be sure, and I see no panic (or any other anomaly) during boot or >>> normal operation. >>> >>> Do you have plans on merging the patch soon? >> >> It's not committed because it doesn't work. What i have tested so far >> is with stock 8.2-REL so without VIMAGE. >> >> enabled VIMAGE option on stock 8.2-REL: bridging works fine >> disabled VIMAGE option on stock 8.2-REL: crashes vm with an assert >> >> Expression: !pPatchToGuestRec >> Location =A0: >> /usr/home/decke/blueports/emulators/virtualbox-ose/work/VirtualBox-4.0.4= _OSE/src/VBox/VMM/VMMR3/PATM.cpp(116 >> 6) void patmr3AddP2GLookupRecord(VM*, _PATCHINFO*, uint8_t*, RTRCPTR, >> PATM_LOOKUP_TYPE, bool) > > It looks like that assert is not related to the VIMAGE patch. Works > fine now since half an hour. > >> Could someone with an VIMAGE kernel please test the patch? Just >> configure a VM with bridging and let it transfer a few bytes. Once with >> the option enabled and once disabled. I've had a machine running a linux guest for almost a day, bridging with a VIMAGE kernel, while capturing traffic on the virtual interface (and performing a few other tasks) -- so far, so good. No panics, and no anomalies. I surely don't know what the above mentioned assert is about; I haven't seen such a panic myself. -Brandon