From owner-svn-ports-head@FreeBSD.ORG Wed Aug 29 09:56:52 2012 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C854E106564A; Wed, 29 Aug 2012 09:56:52 +0000 (UTC) (envelope-from mad@madpilot.net) Received: from micro.madpilot.net (micro.madpilot.net [88.149.173.206]) by mx1.freebsd.org (Postfix) with ESMTP id 1CCD28FC1A; Wed, 29 Aug 2012 09:56:52 +0000 (UTC) Received: from micro.madpilot.net (localhost [127.0.0.1]) by micro.madpilot.net (Postfix) with ESMTP id 3X6MgQ6Bbnz2JB; Wed, 29 Aug 2012 11:56:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=madpilot.net; h= user-agent:in-reply-to:content-disposition:content-type :content-type:mime-version:references:message-id:subject:subject :from:from:date:date:received:received; s=mail; t=1346234208; x= 1348048609; bh=LVf7qbOOVIXqqwMmlEVR47vydvZ3WfBWxHNiwCHtiEs=; b=S UDNzEORWUSBkjBPVMVqlLpJRruOP9cJsGecIePpOV90m43at6QOc2thc7TroIvn6 l/B0cU7MqlKESFK2F0sjkZaf+WRhEH9VykvO2Sjql4lYHSfNfhrsBO9kQebFfRIk aZY1QUU/td3zmyGqRlcQdKaEAkp11w5oDkcf+anz/c= X-Virus-Scanned: amavisd-new at madpilot.net Received: from micro.madpilot.net ([127.0.0.1]) by micro.madpilot.net (micro.madpilot.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 4GqZaLSVac_k; Wed, 29 Aug 2012 11:56:48 +0200 (CEST) Received: by micro.madpilot.net (Postfix, from userid 1000) id 3X6MgN2T4Rz2J9; Wed, 29 Aug 2012 11:56:48 +0200 (CEST) Date: Wed, 29 Aug 2012 11:56:48 +0200 From: Guido Falsi To: Alexey Dokuchaev Message-ID: <20120829095648.GB59512@micro.madpilot.net> References: <201208281203.q7SC3jU7063943@svn.freebsd.org> <20120828145248.GC87067@FreeBSD.org> <503D1845.4090509@FreeBSD.org> <20120829021251.GA13534@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120829021251.GA13534@FreeBSD.org> X-Operating-System: FreeBSD 9.1-PRERELEASE User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org, Chris Rees , Thomas Abthorpe , Tijl Coosemans Subject: Re: svn commit: r303278 - in head/games/simutrans: . files X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Aug 2012 09:56:53 -0000 On Wed, Aug 29, 2012 at 02:12:51AM +0000, Alexey Dokuchaev wrote: > On Tue, Aug 28, 2012 at 09:08:53PM +0100, Chris Rees wrote: > > On 28/08/2012, Guido Falsi wrote: > > > On 08/28/12 16:52, Alexey Dokuchaev wrote: > > >>> + ${INSTALL_SCRIPT} ${FILESDIR}/simutrans.desktop \ > > >>> ${PREFIX}/share/applications/simutrans.desktop > > >> > > >> Why does .desktop file have to have +x bit? > > > > > > I contacted the maintainer, [...] in his own words: > > > > > > Basically KDE counts .desktop files without +x in the user's own desktop > > > as dangerous and warns about this. If a user drags an icon from system > > > wide menu to the desktop it gets copied with same permissions(no +x). > > > KDE people seem to think this is useful to protect from downloaded files. > > > > > > Maintainer is ok to modify the port back to installing without +x if > > > that's the consensus. I also have no problem modifying it if having > > > .desktop files with +x is a problem. > > > > > > Perhaps someone more knowledgeable about KDE than me could also comment > > > on this. > > > > I'm not quite sure that it's a problem-- Alexey has noticed that it's > > unusual to have +X files... but you've provided a perfectly adequate > > explanation :) > > > > Alexey, does this explanation satisfy you too? > > It does, however, it means that we've been installing .desktop files with > wrong permissions for a long time in the past, and no one spoke up. This is > strange, and should be investigated. I also support the idea to hear some > competent answer from KDE people. For start, I'm curious if KDE wants +x > bit on .desktop files within ${HOME}, where protection against malicious or > downloaded files makes sense, or across entire filesystem? > > In any case, I want one standard way of installing .desktop files, either > with (although I a bit worry about +x on a file what cannot be directly > executed), or without (looks better, but possible security implications are > more important). I agree this needs some analysis. I'll leave the games/simutrans port as is then. I'll followup this discussion, Hoping we can come to a consensus about .desktop files. -- Guido Falsi