From owner-freebsd-current@FreeBSD.ORG Wed Apr 11 14:32:15 2007 Return-Path: X-Original-To: current@freebsd.org Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 0774F16A401; Wed, 11 Apr 2007 14:32:15 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.freebsd.org (Postfix) with ESMTP id 8937813C469; Wed, 11 Apr 2007 14:32:14 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from zion.baldwin.cx (zion.baldwin.cx [192.168.0.7]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l3BEW6M4075077; Wed, 11 Apr 2007 10:32:09 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Giorgos Keramidas Date: Wed, 11 Apr 2007 10:21:43 -0400 User-Agent: KMail/1.9.4 References: <4608A5D9.2010902@root.org> <200704101922.08255.jhb@freebsd.org> <20070411092104.GD1675@kobe.laptop> In-Reply-To: <20070411092104.GD1675@kobe.laptop> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200704111021.44494.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [192.168.0.1]); Wed, 11 Apr 2007 10:32:09 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/3067/Wed Apr 11 06:21:12 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: current@freebsd.org, Ariff Abdullah , S?ren Schmidt , Nate Lawson Subject: Re: recent commits break via 8235 ata X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Apr 2007 14:32:15 -0000 On Wednesday 11 April 2007 05:21, Giorgos Keramidas wrote: > On 2007-04-10 19:22, John Baldwin wrote: > >On Tuesday 10 April 2007 16:13, Nate Lawson wrote: > >>Giorgos Keramidas wrote: > >>> This is the change which stops snd_hda from working here: > >>> > >>> % Revision Changes Path > >>> % 1.233 +39 -55 src/sys/dev/acpica/acpi.c > >>> > >>> If I update my kernel sources to Wed Mar 21 14:39:39 2007 +0000 > >>> (including the sys/modules/padlock/Makefile commit of Sam Leffler, to > >>> fix the kernel build from Wed Mar 21 17:37:13 2007 +0000), I can see > >>> that the snd_hda driver probes my sound card correctly. > >>> > >>> Updating after the commit shown above, breaks snd_hda. > >> > >> I just finished a binsearch and can verify this exact commit causes the > >> problem for my ATA also. I'll spend some more time debugging it later. > >> > >> John, can I back out rev 1.233 of acpi.c until you return since it > >> prevents some machines from booting? > > > > Well, it most likely means there are other bugs that just happen to > > not break with the older stuff. Are you sure that just this one > > change fixes things rather than the changes to the nexus drivers? > > For snd_hda on my Toshiba laptop, I can verify that reverting this > changeset only makes snd_hda probe correctly again. I resynced to last > night's HEAD version of CVS, reverted this change only, and the snd_hda > drives still probes correctly. Rebuilding with rev 1.233 of acpi.c > results in the same failure to attach with: > > pcm0: hdac_get_capabilities: Invalid rirb size (0) > device_attach: pcm0 attach returned 6 Can you get boot verbose dmesg for both kernels? -- John Baldwin