From owner-freebsd-ports-bugs@FreeBSD.ORG  Mon Jan  9 18:50:13 2006
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
X-Original-To: freebsd-ports-bugs@hub.freebsd.org
Delivered-To: freebsd-ports-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 1901416A41F
	for <freebsd-ports-bugs@hub.freebsd.org>;
	Mon,  9 Jan 2006 18:50:13 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id CF6E543D4C
	for <freebsd-ports-bugs@hub.freebsd.org>;
	Mon,  9 Jan 2006 18:50:12 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k09IoCYP011528
	for <freebsd-ports-bugs@freefall.freebsd.org>;
	Mon, 9 Jan 2006 18:50:12 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k09IoCnW011527;
	Mon, 9 Jan 2006 18:50:12 GMT (envelope-from gnats)
Date: Mon, 9 Jan 2006 18:50:12 GMT
Message-Id: <200601091850.k09IoCnW011527@freefall.freebsd.org>
To: freebsd-ports-bugs@FreeBSD.org
From: Peter Kerwien <peter@kerwien.homeip.net>
Cc: 
Subject: Re: ports/91451: lftp may segfaults when linked with Readline 5.0
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Peter Kerwien <peter@kerwien.homeip.net>
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 09 Jan 2006 18:50:13 -0000

The following reply was made to PR ports/91451; it has been noted by GNATS.

From: Peter Kerwien <peter@kerwien.homeip.net>
To: "Dmitry A. Yanko" <fm@cross-road.org.ua>
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/91451: lftp may segfaults when linked with Readline 5.0
Date: Mon, 09 Jan 2006 19:50:08 +0100

 Patch does not fix this problem!
 
 root@freebsd# lftp
 lftp :~> open ftp.sunet.se
 lftp ftp.sunet.se:~> cd pub/Linux/kernel.org/Segmentation fault: 11 
 (core dumped)
 root@freebsd# lftp
 lftp :~> version
 LFTP | Version 3.3.5 | Copyright (c) 1996-2005 Alexander V. Lukyanov
 
 LFTP is free software, covered by the GNU General Public License, and 
 you are
 welcome to change it and/or distribute copies of it under certain 
 conditions.
 There is absolutely no warranty for LFTP.  See COPYING for details.
 
 Send bug reports and questions to <lftp@uniyar.ac.ru>.
 
 Libraries used: Readline 5.0, Expat 1.95.8, OpenSSL 0.9.7e-p1 25 Oct 2004
 
 Dmitry A. Yanko wrote:
 
 >Attached patch from author seems to solve a problem.
 >
 >
 >  
 >
 >------------------------------------------------------------------------
 >
 >diff -ruN lftp.orig/files/patch-complete.cc lftp/files/patch-complete.cc
 >--- lftp.orig/files/patch-complete.cc	Thu Jan  1 03:00:00 1970
 >+++ lftp/files/patch-complete.cc	Mon Jan  9 18:40:22 2006
 >@@ -0,0 +1,24 @@
 >+--- src/complete.cc.orig	Wed Nov  3 10:37:44 2004
 >++++ src/complete.cc	Mon Jan  9 18:38:59 2006
 >+@@ -660,7 +660,7 @@
 >+ 	    type=REMOTE_DIR;
 >+ 	 goto really_remote;
 >+       }
 >+-
 >++   really_local:
 >+       ArgV arg("", ResMgr::Query("cmd:cls-completion-default", 0));
 >+       fso.parse_argv(&arg);
 >+ 
 >+@@ -729,7 +729,11 @@
 >+    case REMOTE_FILE:
 >+    case REMOTE_DIR: {
 >+       if(!remote_completion && !force_remote)
 >+-	 break; // local
 >++      {
 >++	 if(type==REMOTE_DIR)
 >++	    type=LOCAL_DIR;
 >++	 goto really_local;
 >++      }
 >+    really_remote:
 >+       if(!strncmp(text,"bm:",3) && !strchr(text,'/'))
 >+       {
 >  
 >