From owner-freebsd-gnome@freebsd.org Tue Jun 7 04:15:11 2016 Return-Path: Delivered-To: freebsd-gnome@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 184C7B6D436 for ; Tue, 7 Jun 2016 04:15:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 037141E98 for ; Tue, 7 Jun 2016 04:15:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id F3476B6D434; Tue, 7 Jun 2016 04:15:10 +0000 (UTC) Delivered-To: gnome@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id F2E4CB6D433 for ; Tue, 7 Jun 2016 04:15:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E368C1E97 for ; Tue, 7 Jun 2016 04:15:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u574FA21033546 for ; Tue, 7 Jun 2016 04:15:10 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: gnome@FreeBSD.org Subject: [Bug 209675] graphics/inkscape: Fix build with libc++ 3.8.0 Date: Tue, 07 Jun 2016 04:15:11 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: gnome@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jun 2016 04:15:11 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D209675 --- Comment #1 from commit-hook@freebsd.org --- A commit references this bug: Author: truckman Date: Tue Jun 7 04:14:38 UTC 2016 New revision: 416493 URL: https://svnweb.freebsd.org/changeset/ports/416493 Log: Fix type for abs() calls in graphics/inkscape During the exp-run in bug 208158, it was found that graphics/inkscape gives errors with libc++ 3.8.0: libavoid/connector.cpp:888:29: error: call to 'abs' is ambiguous COLA_ASSERT(abs(i->pathNext->id.objID - i->id.objID) !=3D= 2); ^~~ This is because abs() is called with unsigned arguments. Fix it by casting the arguments to the appropriate signed types. This mimics what happens with older libraries where the only version of abs() was the one in , which is prototyped: int abs(int) The expression used in ConnRef::generatePath() is not strictly correct because it depends on details of integer overflow that are undefined by the C++ standard. PR: 209675 Submitted by: dim Changes: head/graphics/inkscape/files/ head/graphics/inkscape/files/patch-src_libavoid_connector.cpp head/graphics/inkscape/files/patch-src_ui_tools_flood-tool.cpp --=20 You are receiving this mail because: You are the assignee for the bug.=