From owner-cvs-all@FreeBSD.ORG Tue Mar 8 16:14:28 2005 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1FB3016A4CE; Tue, 8 Mar 2005 16:14:28 +0000 (GMT) Received: from www.portaone.com (support.portaone.com [195.70.151.35]) by mx1.FreeBSD.org (Postfix) with ESMTP id 43D5743D2D; Tue, 8 Mar 2005 16:14:27 +0000 (GMT) (envelope-from sobomax@portaone.com) Received: from [192.168.0.254] ([192.168.2.2]) (authenticated bits=0) by www.portaone.com (8.12.11/8.12.11) with ESMTP id j28GEPR4008388 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 8 Mar 2005 17:14:25 +0100 (CET) (envelope-from sobomax@portaone.com) Message-ID: <422DCF52.6080109@portaone.com> Date: Tue, 08 Mar 2005 18:14:10 +0200 From: Maxim Sobolev Organization: Porta Software Ltd User-Agent: Mozilla Thunderbird 1.0 (Windows/20041206) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Alfred Perlstein References: <200503070726.j277Qhp5059059@repoman.freebsd.org> <20050308012939.GP11079@elvis.mu.org> In-Reply-To: <20050308012939.GP11079@elvis.mu.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV 0.80/685/Wed Jan 26 10:08:24 2005 clamav-milter version 0.80j on www.portaone.com X-Virus-Status: Clean cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/compat/linux linux_socket.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Mar 2005 16:14:28 -0000 Alfred Perlstein wrote: > Why not just expand our API to do this as well? It shouldn't be > that hard and then we'll gain the additional functionality. I have been erroneously assuming that it would be much harder to do, but closer investigation is revealed that it's very simple to do. Committed, thank you for suggestion! Regards, Maxim > > * Maxim Sobolev [050306 23:26] wrote: > >>sobomax 2005-03-07 07:26:43 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/compat/linux linux_socket.c >> Log: >> Handle MSG_NOSIGNAL flag in linux_send() by setting SO_NOSIGPIPE on socket >> for the duration of the send() call. Such approach may be less than ideal >> in threading environment, when several threads share the same socket and it >> might happen that several of them are calling linux_send() at the same time >> with and without SO_NOSIGPIPE set. >> >> However, such race condition is very unlikely in practice, therefore this >> change provides practical improvement compared to the previous behaviour. >> >> PR: kern/76426 >> Submitted by: Steven Hartland >> MFC after: 3 days >> >> Revision Changes Path >> 1.56 +25 -2 src/sys/compat/linux/linux_socket.c > >