From owner-cvs-src@FreeBSD.ORG Fri Apr 6 20:11:50 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 66B2616A405; Fri, 6 Apr 2007 20:11:50 +0000 (UTC) (envelope-from eischen@vigrid.com) Received: from mail.ntplx.net (mail.ntplx.net [204.213.176.10]) by mx1.freebsd.org (Postfix) with ESMTP id 1815213C46A; Fri, 6 Apr 2007 20:11:49 +0000 (UTC) (envelope-from eischen@vigrid.com) Received: from sea.ntplx.net (sea.ntplx.net [204.213.176.11]) by mail.ntplx.net (8.14.0/8.14.0/NETPLEX) with ESMTP id l36JrFST023133; Fri, 6 Apr 2007 15:53:15 -0400 (EDT) X-Virus-Scanned: by AMaViS and Clam AntiVirus (mail.ntplx.net) X-Greylist: Message whitelisted by DRAC access database, not delayed by milter-greylist-3.0 (mail.ntplx.net [204.213.176.10]); Fri, 06 Apr 2007 15:53:15 -0400 (EDT) Date: Fri, 6 Apr 2007 15:53:15 -0400 (EDT) From: Daniel Eischen X-X-Sender: eischen@sea.ntplx.net To: Alexander Kabaev In-Reply-To: <200704061945.l36JjHKn009142@repoman.freebsd.org> Message-ID: References: <200704061945.l36JjHKn009142@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libc/resolv Symbol.map res_debug.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Apr 2007 20:11:50 -0000 On Fri, 6 Apr 2007, Alexander Kabaev wrote: > kan 2007-04-06 19:45:17 UTC > > FreeBSD src repository > > Modified files: > lib/libc/resolv Symbol.map res_debug.c > Log: > __p_rcode_syms is declared as external in resolv.conf, so it cannot be > redeclared as static in res_debug.c. > > Make __p_rcode_syms global and add it to Symbol map. The rest of > __p_??_syms are already global. > > Choice of FBSD_1.0 version for these debug symbols seems strange and > should be revisited before symbol versioning is enabled for libc.so.7. Why don't you put them in the private namespace (FBSDprivate) if they are only used for debugging? -- DE