From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Jan 9 20:20:09 2006 Return-Path: X-Original-To: freebsd-ports-bugs@hub.freebsd.org Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E95BA16A41F for ; Mon, 9 Jan 2006 20:20:08 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1D01F43D55 for ; Mon, 9 Jan 2006 20:20:04 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k09KK3To034759 for ; Mon, 9 Jan 2006 20:20:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k09KK3QU034758; Mon, 9 Jan 2006 20:20:03 GMT (envelope-from gnats) Resent-Date: Mon, 9 Jan 2006 20:20:03 GMT Resent-Message-Id: <200601092020.k09KK3QU034758@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, "Andreas Kohn" Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 959CA16A41F for ; Mon, 9 Jan 2006 20:19:08 +0000 (GMT) (envelope-from andreas@syndrom23.de) Received: from vs159088.vserver.de (syndrom23.de [62.75.159.88]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0435E43D46 for ; Mon, 9 Jan 2006 20:19:07 +0000 (GMT) (envelope-from andreas@syndrom23.de) Received: from klamath.syndrom23.de ([212.204.44.203]) (authenticated bits=0) by vs159088.vserver.de (8.12.8/8.12.8) with ESMTP id k09KIrBo007143 for ; Mon, 9 Jan 2006 21:19:02 +0100 Message-Id: <1136837945.1687@klamath.syndrom23.de> Date: Mon, 9 Jan 2006 21:19:05 +0100 From: "Andreas Kohn" To: "FreeBSD gnats submit" X-Send-Pr-Version: gtk-send-pr 0.4.6 Cc: Subject: ports/91566: [MAINTAINER-UPDATE] x11-wm/transset-df: fix build on 4.x, USE_GETOPT_LONG X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jan 2006 20:20:09 -0000 >Number: 91566 >Category: ports >Synopsis: [MAINTAINER-UPDATE] x11-wm/transset-df: fix build on 4.x, USE_GETOPT_LONG >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: maintainer-update >Submitter-Id: current-users >Arrival-Date: Mon Jan 09 20:20:03 GMT 2006 >Closed-Date: >Last-Modified: >Originator: Andreas Kohn >Release: FreeBSD 7.0-CURRENT i386 >Organization: >Environment: System: FreeBSD 7.0-CURRENT #21: Mon Jan 2 22:03:29 CET 2006 root@klamath.syndrom23.de:/usr/obj/usr/src/sys/KLAMATH >Description: Daniel reported that transset-df doesn't build on his FreeBSD 4.x system, and the error message points to getopt(). I have no 4.x system, but I assume that adding USE_GETOPT_LONG should fix the build in this case. Also for 4.x, move some variable declaration up, to please gcc 2.95. >How-To-Repeat: Try to compile transset-df on 4.x/with gcc 2.95 >Fix: --- transset-df-4.x.diff begins here --- Index: files/patch-transSet.c =================================================================== --- files/patch-transSet.c (revision 0) +++ files/patch-transSet.c (revision 505) @@ -0,0 +1,27 @@ +--- transSet.c.orig Mon Jan 9 21:09:08 2006 ++++ transSet.c Mon Jan 9 21:10:27 2006 +@@ -121,6 +121,11 @@ + {"verbose",0,NULL,'v'}, + {0,0,0,0} + }; ++ unsigned char *data; ++ ++ Atom actual; ++ int format; ++ unsigned long n, left; + + /* wonderful utility */ + Setup_Display_And_Screen(&argc, argv); +@@ -228,12 +233,6 @@ + target_win = Select_Window(dpy); + } + +- unsigned char *data; +- +- Atom actual; +- int format; +- unsigned long n, left; +- + if (!gotd) d=0.75; + + /* get property */ Index: Makefile =================================================================== --- Makefile (revision 503) +++ Makefile (revision 505) @@ -16,6 +16,7 @@ USE_X_PREFIX= yes ALL_TARGET= transset-df MAKE_ARGS= CFLAGS="${CFLAGS}" +USE_GETOPT_LONG=yes PLIST_FILES= bin/transset-df --- transset-df-4.x.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted: