From owner-freebsd-bugs@FreeBSD.ORG Tue Nov 20 23:10:00 2012 Return-Path: Delivered-To: freebsd-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id D93B05C3 for ; Tue, 20 Nov 2012 23:10:00 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id AE5858FC12 for ; Tue, 20 Nov 2012 23:10:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id qAKNA0ql036888 for ; Tue, 20 Nov 2012 23:10:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id qAKNA0M8036886; Tue, 20 Nov 2012 23:10:00 GMT (envelope-from gnats) Resent-Date: Tue, 20 Nov 2012 23:10:00 GMT Resent-Message-Id: <201211202310.qAKNA0M8036886@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Garrett Cooper Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 82B72250 for ; Tue, 20 Nov 2012 23:00:30 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id 6AC6D8FC15 for ; Tue, 20 Nov 2012 23:00:30 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.5/8.14.5) with ESMTP id qAKN0Urf011513 for ; Tue, 20 Nov 2012 23:00:30 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.5/8.14.5/Submit) id qAKN0UvP011512; Tue, 20 Nov 2012 23:00:30 GMT (envelope-from nobody) Message-Id: <201211202300.qAKN0UvP011512@red.freebsd.org> Date: Tue, 20 Nov 2012 23:00:30 GMT From: Garrett Cooper To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Subject: bin/173744: [PATCH] rtsold usage message contains non-sensical -a option in interface required mode usage X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Nov 2012 23:10:01 -0000 >Number: 173744 >Category: bin >Synopsis: [PATCH] rtsold usage message contains non-sensical -a option in interface required mode usage >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Nov 20 23:10:00 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Garrett Cooper >Release: 10-CURRENT >Organization: EMC Isilon >Environment: FreeBSD forza.west.isilon.com 9.1-PRERELEASE FreeBSD 9.1-PRERELEASE #2 r243289: Mon Nov 19 13:30:09 PST 2012 root@forza.west.isilon.com:/usr/obj/usr/src/sys/FORZA amd64 >Description: -a should be omitted from the mode when one or more interfaces are specified... $ rtsold --help rtsold: illegal option -- - usage: rtsold [-adDfFm1] [-O script-name] [-P pidfile] [-R script-name] interfaces... <-- WRONG usage: rtsold [-dDfFm1] [-O script-name] [-P pidfile] [-R script-name] -a .. like noted in the manpage... RTSOLD(8) FreeBSD System Manager's Manual RTSOLD(8) NAME rtsold, rtsol -- router solicitation daemon SYNOPSIS rtsold [-dDfFmu1] [-O script-name] [-p pidfile] [-R script-name] <-- CORRECT interface ... rtsold [-dDfFmu1] [-O script-name] [-p pidfile] [-R script-name] -a rtsol [-dDu] [-O script-name] [-R script-name] interface ... rtsol [-dDu] [-O script-name] [-R script-name] -a >How-To-Repeat: >Fix: Patch attached with submission follows: Index: usr.sbin/rtsold/rtsold.c =================================================================== --- usr.sbin/rtsold/rtsold.c (revision 243323) +++ usr.sbin/rtsold/rtsold.c (working copy) @@ -839,7 +839,7 @@ usage(void) { #ifndef SMALL - fprintf(stderr, "usage: rtsold [-adDfFm1] [-O script-name] " + fprintf(stderr, "usage: rtsold [-dDfFm1] [-O script-name] " "[-P pidfile] [-R script-name] interfaces...\n"); fprintf(stderr, "usage: rtsold [-dDfFm1] [-O script-name] " "[-P pidfile] [-R script-name] -a\n"); >Release-Note: >Audit-Trail: >Unformatted: