From owner-cvs-all@FreeBSD.ORG Wed Apr 26 06:05:17 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 26CB816A404; Wed, 26 Apr 2006 06:05:17 +0000 (UTC) (envelope-from sobomax@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E7B0443D49; Wed, 26 Apr 2006 06:05:16 +0000 (GMT) (envelope-from sobomax@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id k3Q65GV2095550; Wed, 26 Apr 2006 06:05:16 GMT (envelope-from sobomax@repoman.freebsd.org) Received: (from sobomax@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id k3Q65GZZ095546; Wed, 26 Apr 2006 06:05:16 GMT (envelope-from sobomax) Message-Id: <200604260605.k3Q65GZZ095546@repoman.freebsd.org> From: Maxim Sobolev Date: Wed, 26 Apr 2006 06:05:16 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/atkbdc atkbd.c atkbdc.c atkbdc_isa.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Apr 2006 06:05:17 -0000 sobomax 2006-04-26 06:05:16 UTC FreeBSD src repository Modified files: sys/dev/atkbdc atkbd.c atkbdc.c atkbdc_isa.c Log: Use the same method for detecting actual presence of AT-style keyboard controller as we use in boot blocks (querying status register until bit 1 goes off). If that doesn't happed during reasonable period assume that the hardware doesn't have AT-style keyboard controller. This makes FreeBSD working almost OOB on MacBook Pro (still there are issues with putting second CPU core on-line, but since installation CD comes with UP kernel with this change one should be able to install FreeBSD without playing tricks with hints). Other legacy-free hardware (e.g. IBM NetVista S40) should benefit from this as well, but since I don't have any I can't verify. It should make no difference on the ordinary i386 hardware (since in that case that hardware already would be having an issues with A20 routines in boot blocks). I don't know much about AT-style keyboard controller on other platforms (and don't have dedicated access to one), therefore, the code is restricted to i386 for now. I suspect that amd64 may need this as well, but I would rather leave this decision to someone who knows better about the platform(s) in question. I have tested this change on as many "ordinary i386 boxes" as I can get my hands on, and it doesn't create any false negatives on hardware with AT-style keyboard present. MFC after: 1 month Revision Changes Path 1.48 +6 -5 src/sys/dev/atkbdc/atkbd.c 1.23 +24 -0 src/sys/dev/atkbdc/atkbdc.c 1.34 +31 -0 src/sys/dev/atkbdc/atkbdc_isa.c