From owner-freebsd-current@FreeBSD.ORG Wed Apr 11 17:59:31 2007 Return-Path: X-Original-To: current@freebsd.org Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 745F016A409 for ; Wed, 11 Apr 2007 17:59:31 +0000 (UTC) (envelope-from nate@root.org) Received: from root.org (root.org [67.118.192.226]) by mx1.freebsd.org (Postfix) with ESMTP id 6194313C457 for ; Wed, 11 Apr 2007 17:59:31 +0000 (UTC) (envelope-from nate@root.org) Received: (qmail 75185 invoked from network); 11 Apr 2007 17:10:08 -0000 Received: from ppp-71-139-28-99.dsl.snfc21.pacbell.net (HELO ?10.0.0.235?) (nate-mail@71.139.28.99) by root.org with ESMTPA; 11 Apr 2007 17:10:08 -0000 Message-ID: <461D1669.4010404@root.org> Date: Wed, 11 Apr 2007 10:10:01 -0700 From: Nate Lawson User-Agent: Thunderbird 1.5.0.7 (X11/20061027) MIME-Version: 1.0 To: Giorgos Keramidas References: <4608A5D9.2010902@root.org> <20070406211229.GB1078@kobe.laptop> <461BEFD6.2050302@root.org> <200704101922.08255.jhb@freebsd.org> <20070411092104.GD1675@kobe.laptop> In-Reply-To: <20070411092104.GD1675@kobe.laptop> X-Enigmail-Version: 0.94.1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Ariff Abdullah , S?ren Schmidt , current@freebsd.org Subject: Re: recent commits break via 8235 ata X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Apr 2007 17:59:31 -0000 Giorgos Keramidas wrote: > On 2007-04-10 19:22, John Baldwin wrote: >> On Tuesday 10 April 2007 16:13, Nate Lawson wrote: >>> Giorgos Keramidas wrote: >>>> This is the change which stops snd_hda from working here: >>>> >>>> % Revision Changes Path >>>> % 1.233 +39 -55 src/sys/dev/acpica/acpi.c >>>> >>>> If I update my kernel sources to Wed Mar 21 14:39:39 2007 +0000 >>>> (including the sys/modules/padlock/Makefile commit of Sam Leffler, to >>>> fix the kernel build from Wed Mar 21 17:37:13 2007 +0000), I can see >>>> that the snd_hda driver probes my sound card correctly. >>>> >>>> Updating after the commit shown above, breaks snd_hda. >>> I just finished a binsearch and can verify this exact commit causes the >>> problem for my ATA also. I'll spend some more time debugging it later. >>> >>> John, can I back out rev 1.233 of acpi.c until you return since it >>> prevents some machines from booting? >> Well, it most likely means there are other bugs that just happen to >> not break with the older stuff. Are you sure that just this one >> change fixes things rather than the changes to the nexus drivers? > > For snd_hda on my Toshiba laptop, I can verify that reverting this > changeset only makes snd_hda probe correctly again. I resynced to last > night's HEAD version of CVS, reverted this change only, and the snd_hda > drives still probes correctly. Rebuilding with rev 1.233 of acpi.c > results in the same failure to attach with: > > pcm0: hdac_get_capabilities: Invalid rirb size (0) > device_attach: pcm0 attach returned 6 > Me too, just this one rev fixes my ATA. -- Nate