From owner-cvs-all Sun Oct 28 1:43: 6 2001 Delivered-To: cvs-all@freebsd.org Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by hub.freebsd.org (Postfix) with ESMTP id 85F6137B401; Sun, 28 Oct 2001 01:42:58 -0700 (PDT) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.11.6/8.11.6) with ESMTP id f9S8gPS31876; Sun, 28 Oct 2001 09:42:25 +0100 (CET) (envelope-from phk@critter.freebsd.dk) To: Greg Lehey Cc: mjacob@feral.com, Jonathan Lemon , "Andrey A. Chernov" , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: Causing known breakage (was: cvs commit: src/sys/kern kern_conf.c subr_disk.c) In-Reply-To: Your message of "Sun, 28 Oct 2001 19:02:25 +1030." <20011028190225.A88146@monorchid.lemis.com> Date: Sun, 28 Oct 2001 09:42:24 +0100 Message-ID: <31874.1004258544@critter.freebsd.dk> From: Poul-Henning Kamp Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message <20011028190225.A88146@monorchid.lemis.com>, Greg Lehey writes: >On Sunday, 28 October 2001 at 9:28:44 +0100, Poul-Henning Kamp wrote: >> In message <20011028085000.O8085@wantadilla.lemis.com>, Greg Lehey writes: >> >>> I can't be bothered looking for a rule that says you shouldn't commit >>> anything which will knowingly cause breakage, but if it's not in the >>> book, it should be. First ensure that cause of the breakage gets >>> fixed, or fix it yourself. >> >> The kernel itself has been whining at making this mistake since >> 11 sep 2000. >> >> That should be more than sufficient warning for anyone. > >So why haven't you fixed it? Because it is not my task to fix all broken drivers. The message is "WARNING: driver mistake ..." for a very good reason. For instance, I can see the bogus code (mentioned earlier) in asr.c but since I have no hardware I cannot test my hypothesis that the entire driverinit function can be removed. >Seriously, though, you've got to admit that's rather irrelevant to the >statement. Huh ? -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message