From owner-freebsd-bugs@FreeBSD.ORG Tue May 22 03:00:24 2012 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AEEA210656F0 for ; Tue, 22 May 2012 03:00:24 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id D02208FC14 for ; Tue, 22 May 2012 03:00:12 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q4M30C7A056991 for ; Tue, 22 May 2012 03:00:12 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q4M30CGb056990; Tue, 22 May 2012 03:00:12 GMT (envelope-from gnats) Resent-Date: Tue, 22 May 2012 03:00:12 GMT Resent-Message-Id: <201205220300.q4M30CGb056990@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Mark Linimon Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 9A0571065677 for ; Tue, 22 May 2012 02:59:28 +0000 (UTC) (envelope-from linimon@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 83E0A8FC0A for ; Tue, 22 May 2012 02:59:28 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q4M2xSxv056816 for ; Tue, 22 May 2012 02:59:28 GMT (envelope-from linimon@freefall.freebsd.org) Received: (from linimon@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q4M2xSHY056814; Tue, 22 May 2012 02:59:28 GMT (envelope-from linimon) Message-Id: <201205220259.q4M2xSHY056814@freefall.freebsd.org> Date: Tue, 22 May 2012 02:59:28 GMT From: Mark Linimon To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: kern/168211: [kernel] [patch] uma_core.c is missing at least one (possibly two) sleep counts X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Mark Linimon List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 May 2012 03:00:24 -0000 >Number: 168211 >Category: kern >Synopsis: [kernel] [patch] uma_core.c is missing at least one (possibly two) sleep counts >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue May 22 03:00:12 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Mark Linimon >Release: FreeBSD 9.0-STABLE i386 >Organization: FreeBSD >Environment: System: FreeBSD freefall.freebsd.org 9.0-STABLE FreeBSD 9.0-STABLE #6 r235139: Tue May 8 21:19:03 UTC 2012 simon@freefall.freebsd.org:/usr/obj/usr/src/sys/FREEFALL i386 >Description: In at least one case the zone sleep counts are not being incremented. I'n not sure about the second; someone who understands this better will have to review. >How-To-Repeat: >Fix: Index: uma_core.c =================================================================== RCS file: /home/FreeBSD/ncvs/src/sys/vm/uma_core.c,v retrieving revision 1.173 diff -u -r1.173 uma_core.c --- uma_core.c 27 Jan 2012 20:18:31 -0000 1.173 +++ uma_core.c 22 May 2012 02:55:49 -0000 @@ -770,6 +770,7 @@ if (waitok == M_NOWAIT) goto out; mtx_unlock(&uma_mtx); + zone->uz_sleeps++; // XXX MCL msleep(zone, zone->uz_lock, PVM, "zonedrain", 1); mtx_lock(&uma_mtx); } @@ -2196,6 +2197,7 @@ zone->uz_flags |= UMA_ZFLAG_FULL; if (flags & M_NOWAIT) break; + // XXX MCL no sleep count is kept track of here! msleep(keg, &keg->uk_lock, PVM, "keglimit", 0); continue; } >Release-Note: >Audit-Trail: >Unformatted: