From owner-freebsd-current Wed Feb 13 4: 6:28 2002 Delivered-To: freebsd-current@freebsd.org Received: from draco.macsch.com (draco.macsch.com [192.73.8.1]) by hub.freebsd.org (Postfix) with ESMTP id 1C44B37B400 for ; Wed, 13 Feb 2002 04:06:19 -0800 (PST) Received: from mailmuc.muc.eu.mscsoftware.com (mailmuc.muc.macsch.com [161.34.37.20]) by draco.macsch.com (8.9.3/8.9.3) with ESMTP id EAA05778; Wed, 13 Feb 2002 04:01:25 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by mailmuc.muc.eu.mscsoftware.com (8.11.2/8.11.2/SuSE Linux 8.11.1-0.5) with ESMTP id g1DC5W113690; Wed, 13 Feb 2002 13:05:32 +0100 Cc: Munehiro Matsuda , Georg.Koltermann@mscsoftware.com, freebsd-current@FreeBSD.ORG, vsilyaev@mindspring.com Content-Type: text/plain; charset=US-ASCII Date: Wed, 13 Feb 2002 13:04:55 +0100 From: Georg-W Koltermann In-Reply-To: <20020212021229.4D61D9F363@okeeffe.bestweb.net> Message-ID: MIME-Version: 1.0 (generated by SEMI 1.13.7 - "Awazu") Organization: MSC Software Received: from hunter.muc.macsch.com by mailmuc.muc.eu.mscsoftware.com (AvMailGate-6.12.0.0) id 13671-538EE4D1; Wed, 13 Feb 2002 13:04:58 +0100 Received: from hunter.muc.macsch.com (localhost.muc.macsch.com [127.0.0.1]) by hunter.muc.macsch.com (8.11.6/8.11.6) with ESMTP id g1DC4tt01434; Wed, 13 Feb 2002 13:04:56 +0100 (CET) (envelope-from Georg.Koltermann@mscsoftware.com) References: <20020212021229.4D61D9F363@okeeffe.bestweb.net> Subject: Re: [FIXED] /dev/rtc not configured message when starting VMWare2 on -current To: Takanori Saneto User-Agent: Wanderlust/2.4.1 (Stand By Me) SEMI/1.13.7 (Awazu) FLIM/1.13.2 (Kasanui) Emacs/20.7 (i386--freebsd) MULE/4.0 (HANANOEN) X-AntiVirus: OK! AvMailGate Version 6.12.1.11 at mailmuc has not found any known virus in this email. X-Attribution: gwk Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Yes, that seems to fix it, although I had a spontaneous system lockup while I was running with this patch. I have no idea wether the lockup was connected to that patch; I am running that code again right now and it does not lockup. Many thanks to Munehiro and Takanori. Maybe someone else with a VMWare license could retest and then commit it? -- Regards, Georg. At Sun, 10 Feb 2002 03:01:57 +0900, Takanori Saneto wrote: > > Re: "Re: /dev/rtc not configured message when starting VMWare2 on -current" > In article <20020209002638L.haro@h4.dion.ne.jp>, > Munehiro Matsuda wrote: > >I have a hack^Wpatch that should fix your problem. > > I think you need to prevent returning the value of uninitialized > variable (``error'') when no error should be returned. > > How about following patch? (just added "error = 0;" line) > > Index: rtc.c > =================================================================== > RCS file: /export/cvsup/cvs/ports/emulators/rtc/files/rtc.c,v > retrieving revision 1.6 > diff -u -r1.6 rtc.c > --- rtc.c 16 Sep 2001 07:05:18 -0000 1.6 > +++ rtc.c 9 Feb 2002 17:54:44 -0000 > @@ -266,10 +266,32 @@ > { > int error; > > +#if __FreeBSD_version >= 500023 > +dev_t dev; > +struct rtc_softc *sc; > + > + if (rtc_sc!=NULL) > + return (EINVAL); > + > + dev = make_dev(&rtc_cdevsw, 0, UID_ROOT, GID_WHEEL, 0644, DEVICE_NAME); > + if (dev==NULL) > + return (EINVAL); > + > + MALLOC(sc, struct rtc_softc*, sizeof(*sc), M_DEVBUF, M_WAITOK); > + if (sc==NULL) > + return (EINVAL); > + > + bzero(sc, sizeof(*sc)); > + rtc_sc = sc; > + dev->si_drv1 = sc; /* Link together */ > + sc->dev = dev; > + error = 0; > +#else > error = cdevsw_add(&rtc_cdevsw); > if (error) > return error; > > +#endif > return error; > } > > > -- > さねを (SANETO Takanori) // [趣味] 本業をすること // > ・・・・・・・・・・・・・・・・・ // Bonjour Chapeau // > // [本業] 趣味に走ること // > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe freebsd-current" in the body of the message > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe freebsd-current" in the body of the message To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message