From owner-svn-src-all@FreeBSD.ORG Wed Apr 17 21:00:12 2013 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id AC967583; Wed, 17 Apr 2013 21:00:12 +0000 (UTC) (envelope-from jlh@FreeBSD.org) Received: from caravan.chchile.org (caravan.chchile.org [178.32.125.136]) by mx1.freebsd.org (Postfix) with ESMTP id 7586F770; Wed, 17 Apr 2013 21:00:12 +0000 (UTC) Received: by caravan.chchile.org (Postfix, from userid 1000) id 28175C31D8; Wed, 17 Apr 2013 21:00:11 +0000 (UTC) Date: Wed, 17 Apr 2013 23:00:11 +0200 From: Jeremie Le Hen To: Brooks Davis Subject: Re: svn commit: r249549 - in stable/9/sys: amd64/conf i386/conf Message-ID: <20130417210011.GD30222@caravan.chchile.org> Mail-Followup-To: Brooks Davis , Jeremy Chadwick , src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-stable@FreeBSD.org, svn-src-stable-9@FreeBSD.org References: <201304161609.r3GG9SID009937@svn.freebsd.org> <20130416161919.GA80626@icarus.home.lan> <20130417125433.GC30222@caravan.chchile.org> <20130417193538.GB9331@icarus.home.lan> <20130417194706.GA30583@lor.one-eyed-alien.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130417194706.GA30583@lor.one-eyed-alien.net> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: Jeremy Chadwick , svn-src-stable@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, svn-src-stable-9@FreeBSD.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Apr 2013 21:00:12 -0000 On Wed, Apr 17, 2013 at 02:47:06PM -0500, Brooks Davis wrote: > > > I will spend some time to figure out exactly how to reproduce this. > > > > Going from recent memory (~2 weeks ago), I encountered it on my VPS box > > (which does run ntpd, just FYI): > > > > 1. Initially installed with 9.1-RELEASE, > > 2. Upgraded to stable/9 (using svn), > > 3. WITHOUT_CDDL=true and WITHOUT_ZFS=true added to /etc/src.conf > > 4. world/kernel rebuilt/reinstalled/etc. (this includes make delete-old, > > as per instructions in src/Makefile -- which would delete > > /usr/bin/ctfconvert) > > 5. Fast forward many months > > 6. Removed WITHOUT_CDDL=true from src.conf > > 7. Encountered the above issue ("ctfconvert: not found") during > > buildkernel > > 8. Rebuilt kernel again -- same error > > 9. Removed WITHOUT_ZFS=true from src.conf > > 10. Rebuilt kernel again -- worked > > > > This could mean WITHOUT_ZFS=true has some bearing on this situation, but > > I don't see how/why, as WITHOUT_CDDL is supposed to be the "trigger" for > > ctf* utilities. I did poke around the Makefiles and framework a bit > > but didn't have any epiphanies. > > > > Like I said -- I'll try to reproduce the exact scenario. > > Looking at Makefile.inc1 around line 1164 (on HEAD), ctfconvert and > cftmerge are bootstrap tools only when they don't exist at all on the > host. The code there should be expanded to bootstrap for cases where > the installed ones are known to be broken (virtually all prior versions > given recent fixes) as well as when they aren't present on the host > system. Do you have an idea how we can identify whether the installed ctfconvert(1) is broken or not? I think in Jeremy's case we cannot rely on OSRELDATE given that right before he built and installed world with WITHOUT_CDDL, so ctfconvert and OSRELDATE are not in sync. Why not just always add ctfconvert to bootstrap tools when it is needed? I don't know how long it takes to build though, but it is probably nothing compared to LLVM ;-). -- Jeremie Le Hen Scientists say the world is made up of Protons, Neutrons and Electrons. They forgot to mention Morons.