From owner-freebsd-current@FreeBSD.ORG Thu Jan 12 21:27:48 2012 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 50300106564A for ; Thu, 12 Jan 2012 21:27:48 +0000 (UTC) (envelope-from danismostlikely@gmail.com) Received: from mail-ww0-f50.google.com (mail-ww0-f50.google.com [74.125.82.50]) by mx1.freebsd.org (Postfix) with ESMTP id DA74C8FC15 for ; Thu, 12 Jan 2012 21:27:47 +0000 (UTC) Received: by mail-ww0-f50.google.com with SMTP id dr11so2596383wgb.31 for ; Thu, 12 Jan 2012 13:27:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type; bh=kJ1oUIjwOiGPJyhMPTDTF6LRLPX2Mw9LH3pw1gJHfuE=; b=JYhpxR/HbxONJpgbpiQnkOHPLa4XWJfnGpCMpFdwwbEuwsCqOLhjN4cF9ruesbMcmu +tNajslKji4IbAw1L/DPhOfGYsDLw6X5fAXsbaoWp3yGbwqfEEm8BATNG4DvB52f+oEF 8tRDMxLPCqB99RO8o954od0Sr92Dp+GBR6gYU= MIME-Version: 1.0 Received: by 10.180.101.101 with SMTP id ff5mr3489886wib.14.1326401951117; Thu, 12 Jan 2012 12:59:11 -0800 (PST) Received: by 10.180.103.193 with HTTP; Thu, 12 Jan 2012 12:59:11 -0800 (PST) Date: Thu, 12 Jan 2012 14:59:11 -0600 Message-ID: From: Dan McGregor To: freebsd-current@freebsd.org Content-Type: multipart/mixed; boundary=f46d0442829c202fe804b65b059a X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Subject: ctlstat not building with clang X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jan 2012 21:27:48 -0000 --f46d0442829c202fe804b65b059a Content-Type: text/plain; charset=ISO-8859-1 Building world with clang now (as of r229997) no longer compiles because ctlstat was imported into the tree. The error is: clang -O2 -pipe -I/usr/src/usr.bin/ctlstat/../../sys -std=gnu99 -fstack-protector -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls -Wold-style-definition -Wno-pointer-sign -c /usr/src/usr.bin/ctlstat/ctlstat.c /usr/src/usr.bin/ctlstat/ctlstat.c:149:35: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security] fprintf(error ? stderr : stdout, ctlstat_usage); ^~~~~~~~~~~~~ 1 error generated. *** Error code 1 Stop in /usr/src/usr.bin/ctlstat How do people feel about the attached patch that turns a call to fprintf to fputs? --f46d0442829c202fe804b65b059a Content-Type: text/x-diff; charset=US-ASCII; name="ctlstat.patch" Content-Disposition: attachment; filename="ctlstat.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gxc9edo40 SW5kZXg6IGN0bHN0YXQuYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBjdGxzdGF0LmMgICAocmV2aXNpb24gMjMw MDI2KQorKysgY3Rsc3RhdC5jICAgKHdvcmtpbmcgY29weSkKQEAgLTE0Niw3ICsxNDYsNyBAQAog c3RhdGljIHZvaWQKIHVzYWdlKGludCBlcnJvcikKIHsKLSAgICAgICBmcHJpbnRmKGVycm9yID8g c3RkZXJyIDogc3Rkb3V0LCBjdGxzdGF0X3VzYWdlKTsKKyAgICAgICBmcHV0cyhjdGxzdGF0X3Vz YWdlLCBlcnJvciA/IHN0ZGVyciA6IHN0ZG91dCk7CiB9CiAKIHN0YXRpYyBpbnQK --f46d0442829c202fe804b65b059a--