From owner-cvs-all@FreeBSD.ORG Tue Apr 19 18:10:41 2005 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1338116A4CE; Tue, 19 Apr 2005 18:10:41 +0000 (GMT) Received: from mail.ntplx.net (mail.ntplx.net [204.213.176.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id AAB3743D48; Tue, 19 Apr 2005 18:10:40 +0000 (GMT) (envelope-from deischen@freebsd.org) Received: from sea.ntplx.net (sea.ntplx.net [204.213.176.11]) j3JIAdLn018906; Tue, 19 Apr 2005 14:10:39 -0400 (EDT) Date: Tue, 19 Apr 2005 14:10:39 -0400 (EDT) From: Daniel Eischen X-X-Sender: eischen@sea.ntplx.net To: Hajimu UMEMOTO In-Reply-To: <200504191441.j3JEfD8K003270@repoman.freebsd.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Virus-Scanned: by AMaViS and Clam AntiVirus (mail.ntplx.net) cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libc/net getproto.c getprotoent.c getprotoname.c netdb_private.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Daniel Eischen List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Apr 2005 18:10:41 -0000 On Tue, 19 Apr 2005, Hajimu UMEMOTO wrote: > ume 2005-04-19 14:41:13 UTC > > FreeBSD src repository > > Modified files: > lib/libc/net getproto.c getprotoent.c getprotoname.c > netdb_private.h > Log: > - add getproto{byname,bynumber,ent}_r for internal use within libc. > - make getproto{byname,bynumber,ent} thread-safe. Stop polluting the namespace. If the externally visible functions you add are not in a standard and are only for use within libc, they need to be prefixed with "_" or "__". I haven't paid attention to your other commits in libc, but please go back and fix other occurrences if there are any. Or make them static if they can be. -- DE