From owner-cvs-src@FreeBSD.ORG Sat Jun 14 08:02:10 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from green.bikeshed.org (freefall.freebsd.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 5B47A37B405; Sat, 14 Jun 2003 08:02:10 -0700 (PDT) Received: from green.bikeshed.org (localhost [127.0.0.1]) by green.bikeshed.org (8.12.9/8.12.9) with ESMTP id h5EF29mX002091; Sat, 14 Jun 2003 11:02:09 -0400 (EDT) (envelope-from green@green.bikeshed.org) Received: from localhost (green@localhost)h5EF297V002087; Sat, 14 Jun 2003 11:02:09 -0400 (EDT) Message-Id: <200306141502.h5EF297V002087@green.bikeshed.org> X-Mailer: exmh version 2.6.3 04/04/2003 with nmh-1.0.4 To: Yar Tikhiy In-Reply-To: Message from Yar Tikhiy <20030614141608.GA48900@comp.chem.msu.su> From: "Brian F. Feldman" Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Sat, 14 Jun 2003 11:02:09 -0400 Sender: green@green.bikeshed.org cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/libexec/getty main.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Jun 2003 15:02:11 -0000 Yar Tikhiy wrote: > On Sat, Jun 14, 2003 at 01:26:48AM -0700, Brian Feldman wrote: > > green 2003/06/14 01:26:48 PDT > > > > FreeBSD src repository > > > > Modified files: > > libexec/getty main.c > > Log: > > In the last clean-up of this code, the fact that the default tty mode > > information could only be gleaned from the the tty descriptor itself > > was neglected, so never did the tty's default settings get copied from > > the kernel. Specifically, this caused all manner of ctrl-keys to not > > work. Fix this by calling dogettytab() in all the proper places, and > > retrieving the terminfo temporarily in dogettytab(). > > Thank you for fixing my bug before I had time to take a look at it. > > However, your fix seems to have at least one drawback. Consider > the following scenario: A gettytab(5) entry containing control > character settings is used to initialize a terminal. Then another > gettytab(5) entry is selected from autobaud() or portselector(), > or through the "nx" capability. Since the current set of control > characters is read from the terminal driver each time to get the > default values, it will poison the actual defaults. I think I've > nearly made a fix for this, which will reduce the number of > tcgetattr(3) calls as well. That's ok, I knew it didn't do EXACTLY the same thing, but it shouldn't actually do any behavior detrimental to the user. I know the more involved fix means you should probably take a copy of the tmode initially and store that as the one to initialize default values from, but I wasn't sure how you'd want to organize that. -- Brian Fundakowski Feldman \'[ FreeBSD ]''''''''''\ <> green@FreeBSD.org \ The Power to Serve! \ Opinions expressed are my own. \,,,,,,,,,,,,,,,,,,,,,,\